From patchwork Fri Nov 24 20:35:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 31662 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90E052BA7; Fri, 24 Nov 2017 21:36:39 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0049.outbound.protection.outlook.com [104.47.36.49]) by dpdk.org (Postfix) with ESMTP id 3D12B2A6C; Fri, 24 Nov 2017 21:36:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E1velwMDZpyCrsek5JMX2bctr5vswbWUHYc0WyF+rg0=; b=RhT8Ff5DjqA3V3Eo95/9Cpd47ZuPQxLEm1YsJygInkl9bKvWh0U4qkxP997MaJdoa0x9RH5DF1V8W6V7bJvnpESOP0RHubvq40SJb2inVOCueWjIZompm3SvnAURXBI8Kz+497YIbQiDvLnjy2AjNsNwLTTgGWEEuGJ7dZp5bt4= Received: from cavium.com (198.186.0.2) by MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Fri, 24 Nov 2017 20:36:35 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Harish Patil , Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Fri, 24 Nov 2017 12:35:43 -0800 Message-Id: <1511555745-13793-4-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com> References: <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: DM5PR2001CA0004.namprd20.prod.outlook.com (2603:10b6:4:16::14) To MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:MWHPR0701MB3833; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 3:U9hQS1AEhhGr33CrfqQQX1lRqjKaCQS8yRwZEHK27iiDNRGSZgCLiEA/8Im0shkhb/D4wikZRK4YzSW0p9ckmiSz0OX5z6n9C/pFeIisOxxtF36HFrlNfetVJK4dIIjvJDkOlN6djy2712MhS8PgBo6k/0gBDu+jNlbghOUTmFteq4fTi7Lb6E18UxBjXH58VA88YvupbFFGpNCmXKPcyIQQaTJfCOczPcFk3s45Lohx6RTCU+PHRh8SeXK6I869; 25:pbkVjzeb+NA1JG6iqBpidxrpp/5p/eZMbTrkCs5iqyPX1Pa3pFZSxPWz7m3xpJlyWNcDxfsXqdlLjngqCvH17hqS++H3+TwzePMnZk8XuLJKKJNspf6jpE126b/zcXwmWGRSosSGPBkNsGqJMsUFoHPU/P6bYbb57LsC4aceQDpBRFMpPg1g33AGG1aaAjTnAdap/V8uQ4bB6qizLQtXspxU2lflPSKLj0kcuKCXS0Zs6QVKiYvjm9Td9ETbJ5JCMZJ1Vdqdv4sYKiG7PDh3zTYzR34KsftujNl0xgknOUtG38eBG84aprvCqhEcpbjaHYUsrydwbBgvO37G4YchmQ==; 31:VlEy8fylyhZ5Myz7fP5Bpa45E8RoSDvyEhf34bky8x0BKpgjkLrBSuqDp+YRJvqIWkm0tLPLKCGN7Toti2AECiVVWNXF6KVDQuZgoyBSPzXr9o0eFTN34A9iXmldtRuLS2SwP4k/MzPEB+K1RJ8aH/MahFoA+RsMetyJEYBVW7skF+GJODACwz+2XLlDVvJINIhJlWFmAPHx9L6Oh3oszP6gOwZnACiTFyqy7DSx9As= X-MS-TrafficTypeDiagnostic: MWHPR0701MB3833: X-MS-Office365-Filtering-Correlation-Id: c1f2d3e4-ce0c-413f-1c30-08d5337b0e9d X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 20:GPgVyMcFYYFbjSEalUoBBbzW7PLRSNhbtE9TX/F8PyP7tC3NxShszL8yP90IwoQvFUfP/1R9MyHljvEzvq0YbHf2dp7IZH3vSeRB4anQLewun5r3Vh9yOEu7/ULx9USZuntaoUMvF1dqeHagZnYZDFJWDlkmPId+1kmknr1YZNvfyhdMfsaNY16Tk8zUl/kGq+dvwE9vcwOKYzUcJ1DWjsVmUsFKBlSRj5JEsjcFj8lmmBACHxpPaOEiVSpQhjKXqw5ihgRUtmvIi0jPySJuuh7UWZ4x0/2QyJJKQ42urhUCJHIbOFTmYhE69npfGsGDmifZSdy9CSxU3W6OSQV1/HTRhDGNgv1ScKOro/N9b5TOmd9xUuhu9hBDWr121aa1j/eb98JwjNISEs4b2aAougiHpFCayMhI9DBqC4DmrfPhtb/r5pViH1Jt8jhGtfVJXlaYgmTB6ejGUz1iZEHEILr5VcwnKNNwqApKEYOoM+zyMGws7OEEjvJzSD3gzXCX; 4:nRdPrJ20duGRw0paNULWwRnNSkl/drANQ/kcDNMIRhBlg2fWTKiK/dEP1Vrn8u0rENYFk7ChZGHDRDl6vJwraWTKDqUODD1NvbFK4jsTysu4wNsI5U55qXqdm3aVH3FxcUNr64/6nOPv0aALD858d6NMAnXx+AevtXKhlSze/ejgp75zB+pNv2rMCqTYpnRxKA9Sr4BaRF/YAeIUmdVWgs77XbMoc4rpK+Uh9wBsEpG2h1udecccR6//UwtGuVoe6hoYtSMkn79EIWM6JB8kBA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(93006095)(93001095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(20161123555025)(6072148)(201708071742011); SRVR:MWHPR0701MB3833; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR0701MB3833; X-Forefront-PRVS: 05015EB482 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(366004)(199003)(189002)(21086003)(305945005)(97736004)(7736002)(50986999)(81166006)(76176999)(81156014)(2351001)(50226002)(105586002)(8676002)(33646002)(450100002)(2361001)(101416001)(66066001)(7696005)(36756003)(106356001)(68736007)(47776003)(16586007)(316002)(6116002)(3846002)(5660300001)(2906002)(48376002)(50466002)(52116002)(69596002)(8936002)(4720700003)(4326008)(6666003)(72206003)(2950100002)(6916009)(53936002)(478600001)(189998001)(16526018)(25786009)(51416003)(86362001)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3833; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3833; 23:aMGULBBHvjTjwTJ43WGYkkCufIcCm//fVUIGcSj?= hs/2bKlfHVeaFeoGDuD2JO00bBxNOGjNhidEGsawxNbqNzYRtEasX7oJSMdg9d5ONGEPejueURd8sDgzYwXnFFOaF12AXsrU896mNQ58VfSntGx06DULzArHVhjLfb+S2ZnsITT8Z0KjuleScii9hS3JP/KxvKRHeTC4dz6FoLR4UriNjNpjRjiSI34DadWlrUHGvKMVN87gJDRTaQFlLeGHlswNnW69ECbM9ZlQM8Vm7beKDkbi9+1NVYQalkaCBZVwS+PMVpbr1JTNb8jG32eXfwmMOYYY3JKT3mQfhyuHB4djEtoJvkizzkK/fyEVUun11YP+qgzbKMDaxHr51W50AKBNQbOIWJbvsMaBUaU/XkmLv11EEJDAHFmkXHor/KsPh83teyUocv+6OC/rdildLP+voOZJlQt7JtTuDZp5yUV8a5th8O2Iu9rj8+sg/YYi+tuLNSViqM30vqsdu8hn48D9R5siTE7kMNWIYgJcE4y5Zha0heAURb3Wr38jPAOYDc49frgtz7OCYBFCPJ/ugwX25y/BzCAzE8yYIJXdsZQ7ectbWxErbFMUBZexq6W7uSndXJ/r6DYrCcqwZAV7IgI8Wavfsn89iwuk6sCjDZCQJvaMsmUZASaZgBSvOA+gWM9oJ7eHulCy5dqlxadNWzZqil0g6hEpnEAI5oYMoj25IPtQQAamMRvCVuF/CZMjjXX3mY5pBIT6qZ1Sg8soDSMufc+F2WL+FGf1IgKJktdyjXqe9SuGC18tmaAlolMzSsYqqejMZso/zO+KuDz9hJ2ZsslEAa1tzjnX5f85rORuIL9deNAfnJCzNV/op4Es5PJCCnaFzXvOpJQ8KnIBP+MhgzsfrDvaoGVzw6n+1kDjjP/G8b8e0Pv2rXDae75UZHm3TyC0JUZJtw+5vC7q4uJVhaJoWhmHvuEcgMSY48BrRCG9j2x0JzhccGPjAtPO3QHjL1C/vGVmd3eGC2UF6c6amBBGaUZLo4vie4s/W+ZzOQ3cTXeSfqfpBTeJ0y7dLPPfeK6DKwBZ8dIq68r11tJCyLdurPiLugQKzxrHE8RMmB0p04fKG0awx1Ss0ukStHznU0aYJzZXzd5YzR9AdnDX9oHrHDfVti1MkVAdowJlW/yi5BhxEh/VeGUf165+hEWMcKDPb+6mE31xBSKvtZJkABPbbTQFNHpD5tXQC/Q== X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 6:mTkia8WMpz9x2jVJRnJp33mX8aXGpFfhRVeLu9Mehe9YgFDk2gvJHg3Ev1sz+agOASNedYG0s9fawsRsvMAHB/sUHrIrJ6TGkDc0yB6M0wf1Xy7kkH3bItUCmjgS3m5G8ASx/tx04nUrq8iF6U9GfsxhJJemO5s0XGwZz+6NuuXmGukhETVbNCp6qHUJSOZi0AlC0uV6xtOBev14sGDBXojWveuRQMPsAv8GJyu8pFIZT/yafvHqDOmRGC4sR3trGW/zB7Capma9nbE5Xtny4OWBR/WpsZOqsC2pTAILibbUJ7X/WpBWcmRuKWzonshtF9P6iDceYunIeSrIG01C42ZXGNhL7qHzMbsaXLLBA44=; 5:SHMJbE7KOkWsWGU4Yrn0O302gkcXbNWkcr/6SkEjXTPq/bTneeT1D7jtTSlRHxXvRBnH/b45AwOz3UDynin2z3uM3KQs6g/dbHf1DiWHLCfzxYoQQetpbJAxWgRJSoP5akN0EKQyi3xp4SnvQmUlgtprLYSeEo5Sjdj3+gPn7h8=; 24:b/bBYjgeUMmziooz4qADOaoCVjDUPXWDLX0ty4XH52bioIlVu29WZElJHlawRjgciUX/CTretyKVZa3sK9gSZc+fwo4bGcy2+JIvfGI36eY=; 7:nvRWp7Oez9tkqvZ2H/xjxPeUy0HNXEhA9ucuRc6v/sGVVVpFv6d86JQQaC24P3lOiB9SmBmQwoNO/c/36E+2aj2p3W62qtWM+nKZRGx1hkthGWX25EfhuhlUkr9PXja79jevhij+KzvUopf/Xx9Na5F2FL+gX5dr+ZGEdfWCAVak+Lffe9KIORPPhgSf+n9MRCGgI6zS0GU/FdT5zL2PvJkGQqZjmFbSgTBIBYV6840hML+sb7JyxS7dkgWjEkx+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2017 20:36:35.6808 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1f2d3e4-ce0c-413f-1c30-08d5337b0e9d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3833 Subject: [dpdk-dev] [PATCH 3/5] net/qede: fix to reject config with no Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Harish Patil The qede firmware expects minimum one RX queue to be created, otherwise it results in firmware exception. So a check is added to prevent that. Fixes: ec94dbc57362 ("qede: add base driver") Cc: stable@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index cc473d6..0128cec 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1233,6 +1233,14 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) } } + /* We need to have min 1 RX queue.There is no min check in + * rte_eth_dev_configure(), so we are checking it here. + */ + if (eth_dev->data->nb_rx_queues == 0) { + DP_ERR(edev, "Minimum one RX queue is required\n"); + return -EINVAL; + } + /* Sanity checks and throw warnings */ if (rxmode->enable_scatter) eth_dev->data->scattered_rx = 1;