From patchwork Tue Nov 28 12:19:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 31715 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E249A324A; Tue, 28 Nov 2017 13:20:04 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0045.outbound.protection.outlook.com [104.47.1.45]) by dpdk.org (Postfix) with ESMTP id 3A1E82B9E; Tue, 28 Nov 2017 13:20:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TWXPWZppNhTHUflCXyC9Ps9gx//vMEt9MWlaK4nRgLg=; b=lYPNzB406kzEEz2mw9V/T2IGZ8WE5SRyNHd3K/FPgYUPqp8vBgCgAKTgdCKNITVYPMTVDOjdBMmlWg10qpxqZzSICKskMTxVjqTTIlXrxldlhUgxIoG0olRT8ccuzC11MxF32YG4afXukitQIb1jX08ISL9JIkHxJBD+EdmNt8M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3653.eurprd05.prod.outlook.com (2603:10a6:209:9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Tue, 28 Nov 2017 12:19:59 +0000 From: Matan Azrad To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 28 Nov 2017 12:19:23 +0000 Message-Id: <1511871570-16826-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1511871570-16826-1-git-send-email-matan@mellanox.com> References: <1511871570-16826-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6P193CA0012.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::22) To AM6PR0502MB3653.eurprd05.prod.outlook.com (2603:10a6:209:9::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4fed09cb-7ceb-4568-4c08-08d5365a586f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603199); SRVR:AM6PR0502MB3653; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3653; 3:/vgSiaIx+lKwAChnfwo82HT+RTF5lK4NaiRSZIu1lNZg5JGifLqNcB9tW4VGy6CiTQVQGw4Rz+GEt7rxGdqC2hDWnxUUNnKCe7cJyHymOwrrvZ0fuJKoHXrwBzW64PIZgEhxpctWGE/Jx985YdAaFTSzdYDpbfubYG/d/Mh5J/hpEe+rYOOZxDFzQEt+nz8NnYcNbbpn6Vd/nGEiVhIsyjA79Ngyme9JMHn1zYZnFxE1ot8UN0HBlzZ5dLzm74ch; 25:Gkn8aZ5TNmN+lskMsLPfoxwvDiA8wv1lJoGOyag2K3TtaPaFjzIMBWOJjBY8rM1Ajfm8I0+Mv3xsxs/7JiQI6TE0/bOoGpdHMkVFDj9pCVBYJrHTJlANa2OlUd+CqAty1FXCuCax0Wd/yxAbgeVb70OKCsX4kxR1TFVQpCkQiqRfQliPo4HmjMUR/9TdUfUxWhVRRGf1fWWBxvBRkWuS5PvaG7dL30AtbJsbZ59SJvmeONmv6QzXiumoD8kPyGM1Ro7ZsaMQRCFJGtI7tp5QKHsk3q+6C3g0fjFH0EbNigC6PjkniB2BfRPhHW25WkYwIGvlxwRFofr882rmTyZYqHC4OE9KfjGFimPYlkH4Hvg=; 31:Rfcs7wE0BlEkh+nAN01IWQvSIa9ZPnoMDtnwX5ZGkmTY0MyKgAWg8t4Fq6X2a9qAjwFLaq9yTj3If8CtROUU1ni/j1wrH32QCRVf1O1cOen0mtk2y5S5Ndg0K4XGdSyopcvkcHWX2TF02WJQ+fbqP/HB2j+qgfofOoAtDTyblDt929H81kE6S7bhn+tFUU9PqpXvSarpMg4n5HymHasVESI+E8bttUbvGqHd/zVh+f4= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3653: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3653; 20:NRBKHE0AS8P4pm/oaks9saAcRaycUH+KD5c5X4ftgNImJmhJjhP7re0YdB1kqnH9Int5Lct8aqK+JGa3T1EwSWnf5IfiJbTapo6dI0qaOtww/6xmbHQykQQFa8g4jForswPmvks2pSfMu/l96V5A7nysncvp/EoWP3P/D51EYGDO99An4dJiyOw0sNB6VT3btuNI242f2SeJWVlp4yrBi9aneH0nI3QJc+noUy/aG+PWapbhGWtXyR5bgfeLpw42Kygy60/wck8wCeiSFbPtiMaxQLuEihjYUtIS2CPDLnbaeM6iG6f2O/sElqiB/oaiDSLadm0lpHUzHhWjuu3ONXZB7n2RzPwnQEPALCZ1AIxu0IppdNIVxlbSWVm+ShHCIzK6hXLcxhDYdpdS59FRBsBDQFbXP6N00xLQtJkNbynGuyr0G0aUKMJXCROIdBtMH37fW90xKZLNOb3oTrJV5O1LvbO2tzblc+nIzKiFxGNRKXJwHK1DPxoBwE/t03gx; 4:NP6GSuCu+PZT9ehFb7Lo4LKd5ddjoAkBEUnSl/oIKRUYSAyCmm1dTkOJyxzbWEQmRphB071yFCaCXt+QZ8+QgCDsgnYqbPL/9iyc3ppgyUdIeQ5H+MhK3kdBXoDm+dihOLkVxrDRHPcRKOcDbGW5QSjmVu2jWEdEdcslIo1pkTeAw+TMCwjNUepRxWD+tgR9Ico2bXDzsWSC4uqh+DxPHYkn/AgseiDebBPImO6lCXJog51A2Ksmmg+J8kPzxsYmj63VgQ2MBtRD0VQeYdwTAQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM6PR0502MB3653; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3653; X-Forefront-PRVS: 0505147DDB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(366004)(39860400002)(199003)(189002)(101416001)(76176999)(86362001)(50986999)(4720700003)(8676002)(81166006)(81156014)(6666003)(36756003)(55016002)(33646002)(106356001)(105586002)(2950100002)(6916009)(4326008)(478600001)(189998001)(48376002)(25786009)(68736007)(2906002)(50466002)(52116002)(21086003)(53936002)(8936002)(47776003)(33026002)(66066001)(5660300001)(50226002)(6116002)(3846002)(316002)(7736002)(305945005)(97736004)(51416003)(69596002)(7696005)(16586007)(16526018); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3653; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3653; 23:0XESKujmOb7gChdJDm8CpDBTk/+/KJeudPg8yvp?= bZB05h3eiKeVVGpiBW+So/bFL9JkvPA8FdjNYyNr+pGwYzEt/wm3j5UKSkzSvNxgVrX0sJI6eDMp9wf8lI+qPGjqSDQ+79Ekboby8UhFuyFFWQcYOXl+nUmQ78g8ZZsDhifyB+w46aBnDe1Nz5ogVTtTxXzsRS+iMkS+M5KDXudlldzHxM7vmsPd/a9/ChL4GC2egzLnDBsIbVQYv8TM7nTzaxb0VwIeqb8UsbzAU9KczRRBp90tGMwANSdAMTDOhYH5KgCaEMghG5QGebB7iq0lO4si26BRJWkRWP7+YX+iXql9X9Hus8ljo3KXYThgEmzEQqEsjksEr2pELcidbjsSuf/WthSDoaWYztWx9PH5LccFN3WhFlBYdVJMrCDmfNrXA9RTypIMPRlPM9nvSfIG/SOwG4CvURx1kGvq7K9Ojglgn3C50S4SUCfQb/KC86rb7kk29Xk97xoDYPSZv9CXCVMyPGnGOROvfUhFcsMHRYoLkTRMEpsgBuBjValjrAy+GSmCHytEeWYanNZBO17w6IMi6fjt/0QnuQ0oFpyR/E5PYkJ4rx5qwIA07FBIOblqJrozWIJK7NolW6BsO3z9P8EFB10uQhHnGT61O2eTyKyyuu0zH4mzVBHqumb86z7GAmIe1htIN0Uop4zMP24D4cnFK6XdFowQDyMMD8bnbE8Wl39NO28LzyyBZpUTfaq7dDV+bES1R3Juc28ttR6/jsWmnLfG0pXF8H/yqNug/6/OlhPVy5L39YVfn6fcN3rG1/uPgGUa9gGjRnEZko9mgeE0anmqkpKyMjeWcPblgv6nU4M1ySK3vcdLyL+fvBD2rvXGVEdREsDJiYtRNKBXqJvm3lp6gHV7t1zIeQMDV8tuOcrHa1eiHCjBiINayLux7QifBAjXmCQMsGwfbF9CrLnSTiWuc0CWUr93gHhE1FrSw7KyoOWzZXtJGDCXXqD1mkS0xPrYHL2o4hXbookZw4RPtJ/mwRQ39Xmxx691zQkwTrEF4RBGdfSaBENvHfO4SljhHBMBp5Pym2yrd+uxDYgoiZP8VMykgGr9YVOKRjwvpzWx8muQD2UoH09akiqXjD9zyafNSNDF/Bnhjr1JbQcxel9Hpk2h3o0/6Y7NqVfqavKu8e2oewyhM66yflFE= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3653; 6:GOVwJXEQrBHXPXlAB+HA/TFn1jSzvKCQeTuAGqK7CmOjOSiqc23R8eNU9wxkkZpskjJ4uwgnkNXZRWkV9sXuXIsyJwwE4aoBQQVLyfn5lVRPCBzQ+jhbeYAJZ5AFaZkP0mdmMSx3XBNuv33uUPqa1Q+a33ppktyOBi9G51jjmgVbPOoc54H/KbnvCRi71htZR8GrkGgRw2/fRy/uccaV7RhGNba6s1aIYy4PXEKpdkCQt/k7zslkl5OnhcAjHT6DPbZ7c5ObR7zG9Y/4M3LDQ04rIQ/+xGc9nDCIUWEfgzXfEK2yFO8KRYoQj3hdXIxr+dmndQvX478vR75DLTrc00ZjdCWabXybappZ21csLn4=; 5:yuIOLF5yLiD9I3EHMga5nx3SaRIC1FWqeTSTRXo3TaQVZFFKMkM8VV0+gGOPjb6x2WsgIRvRiCD2EkC2xs28SeIVryBAGP8w+RhnFefWxRf6U+o43q1b3Xqe7PfZkhlW7azM/Yg1jVnTlGdkvJ9yknGVJjEDSvkoWOeCrWAxGgY=; 24:dWkEHAgc84kXvKYQUS5h8fRsv25f/tbEhHJ8aONrhw+6T2QM2o3S8hh6wP7OlT5prEUrWVNof2E0XobmO9R+dBr412yfr5eX4VpXcy7cIAs=; 7:UCHuZ9rl4B+/GjL0fWj9vkTQE8r4jRYMCwLoYdYpYjz/AgBBndd45f80RJDkZ7wL6dxSpHpiyXXJwYVhOD09MExVTuxEoB++fYjLsZ4gorccPcvd0u64wf0QTGenbELWW3lLCXf5tDS59+z+5uHlfMdOMsrt5DfKPBPP9Rac/om9Vebj9ftIRXXFrTlVNnDeB3DIAtm2etMqslbokEl0LTVwVo7DnwnrJxHM3BUdwapVefLhOyDM+Pv5C/rzWLth SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 12:19:59.4407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fed09cb-7ceb-4568-4c08-08d5365a586f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3653 Subject: [dpdk-dev] [PATCH 1/8] net/mlx4: fix Tx packet drop application report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When invalid lkey is sent to HW, HW sends an error notification in completion function. The previous code wouldn't crash but doesn't add any application report in case of completion error, so application cannot know that packet actually was dropped in case of invalid lkey. Return back the lkey validation to Tx path. Fixes: 2eee458746bc ("net/mlx4: remove error flows from Tx fast path") Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index 2bfa8b1..0d008ed 100644 --- a/drivers/net/mlx4/mlx4_rxtx.c +++ b/drivers/net/mlx4/mlx4_rxtx.c @@ -468,7 +468,6 @@ struct pv { /* Memory region key (big endian) for this memory pool. */ lkey = mlx4_txq_mp2mr(txq, mlx4_txq_mb2mp(sbuf)); dseg->lkey = rte_cpu_to_be_32(lkey); -#ifndef NDEBUG /* Calculate the needed work queue entry size for this packet */ if (unlikely(dseg->lkey == rte_cpu_to_be_32((uint32_t)-1))) { /* MR does not exist. */ @@ -486,7 +485,6 @@ struct pv { (sq->head & sq->txbb_cnt) ? 0 : 1); return -1; } -#endif /* NDEBUG */ if (likely(sbuf->data_len)) { byte_count = rte_cpu_to_be_32(sbuf->data_len); } else { @@ -636,7 +634,6 @@ struct pv { /* Memory region key (big endian). */ lkey = mlx4_txq_mp2mr(txq, mlx4_txq_mb2mp(buf)); dseg->lkey = rte_cpu_to_be_32(lkey); -#ifndef NDEBUG if (unlikely(dseg->lkey == rte_cpu_to_be_32((uint32_t)-1))) { /* MR does not exist. */ @@ -655,7 +652,6 @@ struct pv { elt->buf = NULL; break; } -#endif /* NDEBUG */ /* Never be TXBB aligned, no need compiler barrier. */ dseg->byte_count = rte_cpu_to_be_32(buf->data_len); /* Fill the control parameters for this packet. */