From patchwork Fri Dec 1 15:19:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Duszynski X-Patchwork-Id: 31874 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B8EF7CE7; Fri, 1 Dec 2017 16:20:14 +0100 (CET) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id EE9CD7CC4 for ; Fri, 1 Dec 2017 16:20:11 +0100 (CET) Received: by mail-lf0-f65.google.com with SMTP id x204so12079459lfa.11 for ; Fri, 01 Dec 2017 07:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=503w18s96XEjSv+cIR6HpYzC6QTj3v8U1zbj4I7kdYA=; b=ZwVk5yGMzEDpY0TRDZNt0kcXs//2iqPxr1lPk4GuUO84X4XRxOZzAcDcRQsz2lAMgy wweQc+C2Bi/kaiW/N3wq3fSRXUAdh9n2ZlM68NLwncwIiSJeSIHXcPDg75aiO/BVa1qW N0BUr5fM1K3Ak+Bu7qbXrjoYfMlfC5/lGa2fo0p4gvynGRPzX2k8eXFQOheTjBYErwW8 03WrGxwezeWM+x/TpNf7vV1TunIYecsxaBtpKio/NUBGjyIrymtRlABJjD3wSiBay6fg NIF++6AdDlBrDvymKb3Zc/yosjcEtmhOmJgIcQVvfYnwlpEczmdIZFmbXUSco3rvd8nd ep7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=503w18s96XEjSv+cIR6HpYzC6QTj3v8U1zbj4I7kdYA=; b=DZ4mIT/NF+PQ3zre++PxfwBUTtJYq66t2lddXQQTSE9xQm7Dp1hJQgl7SNOj9r0Cpd KeXfEJrMNJeLC6MmUJcW7zKUSoOszEi/UgfcLdXDNnnCEjFjXJP3Md4wK2Od8X7lzwgc 6BqwQkxG/XECWUT4RclFIxbwJvo/N65Nci42s1yiG3R6f+0a5drsVtKqAdgea8pjil+V uoF+KQb2a/MIT5TjZRWu73cJvnaVnRzb2eT6WihA2VJSJVqrgMRNzdRCD0SJcaiadckA GOEiDEtg5uMohCOHGMstxpMoB64cWlDFrjqG13jgBah43lTFffKP/qEyyIJjGXOB9Noi YPfg== X-Gm-Message-State: AJaThX5OUR4koD9fkTSM7LFJdcjfdzo83mcw49p6OIXRYzF28SIKFwwg FDmwPQTsNCUHy8BOFIMyfoz0H1mLGcA= X-Google-Smtp-Source: AGs4zMZmJNrYfS15howDnzNDJkwPDgA7xloAc/pPArfaeZb6tzJQS8OxW7EEdu8THsN3Fol53K14/g== X-Received: by 10.25.168.205 with SMTP id r196mr4117809lfe.52.1512141611383; Fri, 01 Dec 2017 07:20:11 -0800 (PST) Received: from tdu.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id j1sm1177674lfe.66.2017.12.01.07.20.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Dec 2017 07:20:10 -0800 (PST) From: Tomasz Duszynski To: dev@dpdk.org Cc: mw@semihalf.com, jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com, jianbo.liu@arm.com, Tomasz Duszynski Date: Fri, 1 Dec 2017 16:19:50 +0100 Message-Id: <1512141592-16695-6-git-send-email-tdu@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512141592-16695-1-git-send-email-tdu@semihalf.com> References: <1512048743-23749-1-git-send-email-tdu@semihalf.com> <1512141592-16695-1-git-send-email-tdu@semihalf.com> Subject: [dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add extra error logs in a few places. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c index 40f2ead..127ce44 100644 --- a/drivers/net/mrvl/mrvl_ethdev.c +++ b/drivers/net/mrvl/mrvl_ethdev.c @@ -426,8 +426,10 @@ mrvl_dev_start(struct rte_eth_dev *dev) priv->bpool_min_size = priv->nb_rx_queues * MRVL_BURST_SIZE * 2; ret = pp2_ppio_init(&priv->ppio_params, &priv->ppio); - if (ret) + if (ret) { + RTE_LOG(ERR, PMD, "Failed to init ppio\n"); return ret; + } /* * In case there are some some stale uc/mc mac addresses flush them @@ -462,17 +464,20 @@ mrvl_dev_start(struct rte_eth_dev *dev) if (mrvl_qos_cfg) { ret = mrvl_start_qos_mapping(priv); if (ret) { - pp2_ppio_deinit(priv->ppio); - return ret; + RTE_LOG(ERR, PMD, "Failed to setup QoS mapping\n"); + goto out; } } ret = mrvl_dev_set_link_up(dev); - if (ret) + if (ret) { + RTE_LOG(ERR, PMD, "Failed to set link up\n"); goto out; + } return 0; out: + RTE_LOG(ERR, PMD, "Failed to start device\n"); pp2_ppio_deinit(priv->ppio); return ret; }