From patchwork Wed Dec 6 14:48:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 31946 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC8994A63; Wed, 6 Dec 2017 15:48:55 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0087.outbound.protection.outlook.com [104.47.0.87]) by dpdk.org (Postfix) with ESMTP id 22C472B99; Wed, 6 Dec 2017 15:48:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=naeaUU5schu3KkHTQJBTqSUUO0kkF9mwrnjQ1hOzuL8=; b=JOEFH4LgNyydIOrP1oF5ZLHzp41YCiCLmXGZA2fNBNG50aXaV8chPawLVbErmRD+92wKcR//nGEZxaY7fVyoXlmmYhzS6hiktsr4vzxlSSg3cK/sSxIs4YBq6eNArw1VKvNSjltsu4It6Qg98vxgvW+1qE/IuPg9QWdr6RR51Ho= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Wed, 6 Dec 2017 14:48:51 +0000 From: Matan Azrad To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 6 Dec 2017 14:48:06 +0000 Message-Id: <1512571693-15338-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1512571693-15338-1-git-send-email-matan@mellanox.com> References: <1511871570-16826-1-git-send-email-matan@mellanox.com> <1512571693-15338-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:3:cf::13) To HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdd49492-9985-4775-9653-08d53cb8777e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286); SRVR:HE1PR0502MB3659; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 3:LcODsknOIHr4aIo6PPsjDe67O/huZ74PI0cbQnNYnfmLnmaxrUnJaQFsJBD4f3MVgdZXQ+lobRVlXTbo+Si6iLZYZELcnSrrtAB5KqDi4fXjiHFfc2aqGiUy6BTEYCwZzAWvR4B7Wz03iiCaTF+VKwZrRhLmvkNJMnzhB26nEuafvwaAm5f9Wogfp/c7qoRm2ItYL4RKii8KEIxyw6+RHrX7LndOZGKwakaL+AKSNxKxyYru0CER3NtMtXFlNi08; 25:k/uQy/S0DV04hPtmewnvV57KR7BjQDBWr6lnZr91kI/mICZiedja4rq+9aeTTXQGcTXApd6u0cPhWydyUMF7C1VCCRg/HqxdLrvcxH/pl7fvNMhfxEEUd0S4tW1KtPvp39YQpx4j83sYBb+SYvWfLnv3cd+XPUcn1GznTxWS3xfYYnyBVdyhwLxheAIvdMi7w+VKn5HIHzgLWM0tJzQaQ5eO/xRErxLrmatFiqC42+E89hQn+xSpQRJRdv9JgQvfSAN1iKlQW44hSnTpkP9BgH80NVlQINHMkjgG4SliqRvqBCu/LbgM8Cf+Sz0WDrMjlWG3FixlKuD1eKBXkbaSlw==; 31:CmxB/EMNu1q0fqPWG8+p7eNgA/ugNlU7UhKZfwyDNprpQ3tC7bekfh5w+KwdVi/SxeIkiz0Yyz9lkmmaEeIciXkAOnCltqQXvuZff62PV+2kSV+Yzq83nLY8xjmt5LVibOmTinu6dw2rZCXwEWn8mXRHV45mLQeu36yM/iVsXRIHWp0cNauWDEi4QCQ1eoxVwTdFmEfsBlR9cN5Xgipm5haWnr39ZYTn0KCXzBKpKt8= X-MS-TrafficTypeDiagnostic: HE1PR0502MB3659: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 20:nk9YFo3sE++VDu4sDkj4OmVdCwO4H+fd1y7KbdrhGNix5CWChnpvddaenOiSSu61DJ1vEVXUwyfgim0Y4/LmI1R6qmy4YVNnlwd8pIVsco9edC5TJMUqHmQQOcM9+SrYNYvVCeFnY2VX7X9FRVyEjETH3kYB51PP4CVZW3XOQ5uXw0jv4Movm8ieMaN+0bTcJscZszOSJTcP5R8a5u3Q0b/rC/YIIAgzJSq0i91OYr3mOLMTF6fgHKopo+Lr/vi8QfgL1SB1RH3d5p3GDoNEKdi9uvEplecNrraC4fOxAEWe1CzCggmWILlf+SpHT6vpwG9iSWbCDz9VUPI4AOMpBW7Kadj5ZmdOXifxI7m5IgFb/5p4P8Oc6GJZkFAKirxZj0MrJU37Y1h4g4Pg9fE5iDbVmn97YG3CJP4zvJo7w905ggAB+UOcCPk5xOCVRjyjnd3b9AMOo4x7Wjb/hAy6lHbEIel5/4FIGjtwIYp22MaXUhyhvvOR5KCbDGLENFoJ; 4:nIFXSX4D/Gu8Lu67BwEFAGEYljHyQlMUagE5J0E6nV5P/267nMhLhv7CMu1xK/mWy62OpU5+iiwEa81X22hFSd6Cma8rb64Rl/zo5TGBjnaeu8H3ztwnYyOiMCVbq8U0JKgOKWntn5cvnfepTzJioe7T1HKQrGuVf0fOcLloxtKyBnV6sZkG+IxxAaxZB5lH87D/kGCxBJx/i/bxwvCjBgCLXzIeuFlD//msVSu8XaHjQKiyBv6U+I70Nb3mF/wUMRML+mcwZFW867z9Q5w7cA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123564025)(201703131423075)(201703011903075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011); SRVR:HE1PR0502MB3659; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0502MB3659; X-Forefront-PRVS: 05134F8B4F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7966004)(366004)(39860400002)(346002)(376002)(189003)(199004)(6916009)(2950100002)(6116002)(4326008)(16526018)(6666003)(3846002)(47776003)(8936002)(76176011)(508600001)(8676002)(81166006)(101416001)(97736004)(33026002)(86362001)(55016002)(4720700003)(21086003)(81156014)(105586002)(7736002)(66066001)(25786009)(2906002)(69596002)(305945005)(5660300001)(106356001)(33646002)(50226002)(51416003)(50466002)(16586007)(7696005)(52116002)(316002)(53936002)(68736007)(36756003)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3659; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0502MB3659; 23:uwZVpdTgLGuQGYHaTgPNetWLxzFiJGyJieqn2cq?= dtzkULKDKgd4myWYF2NVzi1o4SO4IokpR94xcP8OdU/ogVTe1atJtIaaI6181c479tlTt1nvAQYonu1tahzdZ0YAmMwYZ3vEsNJW6IlF5O70bG4YwrmSbKjd1/hGXj57R0hw3HpqwsmnVNj7RJ/CaQhYSC3EiLVuydGXh+pTqTBbiQ6mwgaD7bAUWXkfyvfLmntoOCSmag0yRYc2fZsHv8U38JvA9gzWrWsAZ09nc4pYSV7RLOFZndVfWfx0kZ5rr3S7iRvygcAJgWe7+xMrc8yECks2air0gjQcmWlRcj7yIdQ/YbAGtAmi79L+PF4auB0nqFAT82DEEzLoq8C8chgq06xQDZwN6Ey+7Xt0+Ig/S90nIbqd4uNeCWV1dwKFc3dZjtp37RiqzjfwCWsHN4lWh009n3KMSS88rxa1hdatWWT37RV8O1O3Fkzn8WDH4M5PBCxYkexUllokP3ElKtyakKfDGaeKzGWoajp4okZa/NDD9YlYyIOuaGPaatPWBsoJ8lEy5Ip09ziPYrLCFy7zkhjJ/hqWbCpM6AvCJ8DI+PxJFCdLYyh6CeBWn3HvraAAM7hofmqdyZRR+b/ZhT8hvLZ9IrQW9tXII3r4afDA0+wygouEd1UtM2fajQDz3UE6n86kEiOFAcfwRuusPZ5rdw6AJAj+ebPFVT3fXmAIo2UIb0iYXCrzOFShLhScOBq5HlX1sEZnlDidp5Iv/7EwN10ZNVJ5L2TdpmTSDak3GKYIhhWwHvpTgXqYVU4ATml7k+XBzbpF/u2qW7fS+RzSd+4mfYQUm0srdgJHtpdNqTMnjkCj5tfrk4g82vogf5GTZTAbIuEv0sGpO1y+y9DAVMgGCTdQzQOsyv7h5I7hcWShL+pjaVefSwWqmclDwV7zFakRYp3X8FCjFr2vCrz39M4hihZlmRzmSpgPEgmFRYtx+HxSN3hlNG8P1gyQsI3G/Tm1JADvW4/y+tbBd7oSuXo851L6IYdmTTpHDNgnlJ3XSJi89skCXAKnck6KZ/bLU2+rEAypsCByBm3ItYGGUSka4RC7aiNEeDyfRi/n+GR99Qs91oBE6EYggmM2bWDuBQG8pkikfVXSn4BXROrb+ X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 6:+fgK5b+WryZA6CcMpjoAyLSdDr4j9AfdThNOyal5WQfhjzmwp6ULDWhO/kEftJ72DXjFhZfcrWKyfZGAZ33FLYkvgAhBnm/dfox4np1klO1jmGAv16hzAE+FI7OqWZFLRDa8aDpRz9afz3qdQRK2FWoy8SpyD25EQt1W5WHr5FdDWChW+gQaWGhlpdZ1ETnHX9g8TOffomS4z08ebyC8JZQDtC17+u4jWiT9vqBPT3woBlXtQnKEC1SCkxEsRbUjXu7007wZVPVA7CU/0bDlTRKsXyHrleQrNlNwVpyjmWN869Xf4syGkIv7qxW3JBrLFO/UqGKf1t6R3biKd4TmI7SqjIoHWBZy6YPpROIfZ6I=; 5:dSG+3oJ1aPnGqFuYMGJ6HeHUX24DuFT4Asu7QIVyGiKFcf/P4mmKgI7JX6s9D447eqQpqRdaOvW+U40ICdsRGD/M6d1F4XNVuhTuQ+iSsmZRl9J8UG1cL5h+S83gGGEpWLhqzwzU5PGjNUigpU9a4jPdwZiGnmzYdgf/SF5VK0s=; 24:lu4duOM9an/r2/ry6DdgjE1s2rAh7m0qbj7vQ4B+yp4bsw9S7air7/HRYBDAxhDwJ1jvw3hluH+IE+lJ40KWCd2i4o+2WJ91h5Ik3oRCr0U=; 7:HB1ix/ThUoqQ7gbpGtxGkAnHlRMy7iwKyaArP43iFsaUcOIlw2ZBxGPt/v1PjgHn86DtbF8/9EenZ3u82DhSU18YOd/eTVlEvQdC9DqEmxRBAjIt3SdxcLcAssGalGrCR6bKCLvXthjCk3SMoc1kgCGcGV71ZamQBbCihYxGU1oPw6wnwkQatbxIC3ma43VzSvpwFFMsEdiuDoN6siA+xzrDyc+UluRMmnxkrau27FS97KsviOnF70NQq9MbkNrM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2017 14:48:51.2664 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdd49492-9985-4775-9653-08d53cb8777e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3659 Subject: [dpdk-dev] [PATCH v2 1/8] net/mlx4: fix Tx packet drop application report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When invalid lkey is sent to HW, HW sends an error notification in completion function. The previous code wouldn't crash but doesn't add any application report in case of completion error, so application cannot know that packet actually was dropped in case of invalid lkey. Return back the lkey validation to Tx path. Fixes: 2eee458746bc ("net/mlx4: remove error flows from Tx fast path") Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index 2bfa8b1..0d008ed 100644 --- a/drivers/net/mlx4/mlx4_rxtx.c +++ b/drivers/net/mlx4/mlx4_rxtx.c @@ -468,7 +468,6 @@ struct pv { /* Memory region key (big endian) for this memory pool. */ lkey = mlx4_txq_mp2mr(txq, mlx4_txq_mb2mp(sbuf)); dseg->lkey = rte_cpu_to_be_32(lkey); -#ifndef NDEBUG /* Calculate the needed work queue entry size for this packet */ if (unlikely(dseg->lkey == rte_cpu_to_be_32((uint32_t)-1))) { /* MR does not exist. */ @@ -486,7 +485,6 @@ struct pv { (sq->head & sq->txbb_cnt) ? 0 : 1); return -1; } -#endif /* NDEBUG */ if (likely(sbuf->data_len)) { byte_count = rte_cpu_to_be_32(sbuf->data_len); } else { @@ -636,7 +634,6 @@ struct pv { /* Memory region key (big endian). */ lkey = mlx4_txq_mp2mr(txq, mlx4_txq_mb2mp(buf)); dseg->lkey = rte_cpu_to_be_32(lkey); -#ifndef NDEBUG if (unlikely(dseg->lkey == rte_cpu_to_be_32((uint32_t)-1))) { /* MR does not exist. */ @@ -655,7 +652,6 @@ struct pv { elt->buf = NULL; break; } -#endif /* NDEBUG */ /* Never be TXBB aligned, no need compiler barrier. */ dseg->byte_count = rte_cpu_to_be_32(buf->data_len); /* Fill the control parameters for this packet. */