diff mbox

[dpdk-dev] i40e: fix flag sent to mac_address_write

Message ID 1515624018-12555-1-git-send-email-iryzhov@nfware.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation fail Compilation issues

Commit Message

Igor Ryzhov Jan. 10, 2018, 10:40 p.m. UTC 
  Use the same value as in Linux driver.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Xing, Beilei Jan. 11, 2018, 8:12 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov
> Sent: Thursday, January 11, 2018 6:40 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: fix flag sent to mac_address_write

Prefix with net/i40e:

> 
> Use the same value as in Linux driver.

Fixes line is needed.
Thanks for the patch.

> 
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 285d92b..93b9dd0 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -10795,8 +10795,7 @@ static void i40e_set_default_mac_addr(struct
> rte_eth_dev *dev,
>  		return;
>  	}
> 
> -	/* Flags: 0x3 updates port address */
> -	i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes,
> NULL);
> +	i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL,
> +mac_addr->addr_bytes, NULL);
>  }
> 
>  static int
> --
> 2.6.4
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 285d92b..93b9dd0 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10795,8 +10795,7 @@  static void i40e_set_default_mac_addr(struct rte_eth_dev *dev,
 		return;
 	}
 
-	/* Flags: 0x3 updates port address */
-	i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes, NULL);
+	i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL, mac_addr->addr_bytes, NULL);
 }
 
 static int