diff mbox

[dpdk-dev,v2] net/i40e: fix flag sent to mac_address_write

Message ID 1515665247-14772-1-git-send-email-iryzhov@nfware.com (mailing list archive)
State Superseded, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Igor Ryzhov Jan. 11, 2018, 10:07 a.m. UTC 
  Use the same value as in Linux driver.

Fixes: e18e01e92c29 ("i40e: support default MAC address setting")
Cc: stable@dpdk.org

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
v2:
* fix checkpatch warning (long line)
* fix commit subject
* add Fixes line
* CC to stable
---
 drivers/net/i40e/i40e_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Xing, Beilei Jan. 12, 2018, 2:22 a.m. UTC | #1 
> -----Original Message-----
> From: Igor Ryzhov [mailto:iryzhov@nfware.com]
> Sent: Thursday, January 11, 2018 6:07 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix flag sent to mac_address_write
> 
> Use the same value as in Linux driver.

Sorry for missing the comment in v1 patch, but could you please detail the commit log?

> 
> Fixes: e18e01e92c29 ("i40e: support default MAC address setting")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Igor Ryzhov Jan. 15, 2018, 8:32 a.m. UTC | #2 
Sure.

Sent v3.

On Fri, Jan 12, 2018 at 5:22 AM, Xing, Beilei <beilei.xing@intel.com> wrote:

>
>
> > -----Original Message-----
> > From: Igor Ryzhov [mailto:iryzhov@nfware.com]
> > Sent: Thursday, January 11, 2018 6:07 PM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org
> > Subject: [PATCH v2] net/i40e: fix flag sent to mac_address_write
> >
> > Use the same value as in Linux driver.
>
> Sorry for missing the comment in v1 patch, but could you please detail the
> commit log?
>
> >
> > Fixes: e18e01e92c29 ("i40e: support default MAC address setting")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 285d92b..055b9e8 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10795,8 +10795,8 @@  static void i40e_set_default_mac_addr(struct rte_eth_dev *dev,
 		return;
 	}
 
-	/* Flags: 0x3 updates port address */
-	i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes, NULL);
+	i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL,
+				  mac_addr->addr_bytes, NULL);
 }
 
 static int