[dpdk-dev] app/testpmd: fix FDIR issue
Checks
Commit Message
This patch fixes issue during dealing with flow
director filter.
Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter")
Cc: stable@dpdk.org
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
app/test-pmd/cmdline.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, February 8, 2018 8:36 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix FDIR issue
>
> This patch fixes issue during dealing with flow
> director filter.
>
> Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> app/test-pmd/cmdline.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b4522f4..d1dc1de 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -9900,11 +9900,11 @@ struct cmd_flow_director_result {
> uint16_t port_dst;
> cmdline_fixed_string_t verify_tag;
> uint32_t verify_tag_value;
> - cmdline_ipaddr_t tos;
> + cmdline_fixed_string_t tos;
> uint8_t tos_value;
> - cmdline_ipaddr_t proto;
> + cmdline_fixed_string_t proto;
> uint8_t proto_value;
> - cmdline_ipaddr_t ttl;
> + cmdline_fixed_string_t ttl;
> uint8_t ttl_value;
> cmdline_fixed_string_t vlan;
> uint16_t vlan_value;
> @@ -10515,7 +10515,7 @@ cmdline_parse_inst_t cmd_add_del_sctp_flow_director = {
> (void *)&cmd_flow_director_flow_type,
> (void *)&cmd_flow_director_src,
> (void *)&cmd_flow_director_ip_src,
> - (void *)&cmd_flow_director_port_dst,
> + (void *)&cmd_flow_director_port_src,
> (void *)&cmd_flow_director_dst,
> (void *)&cmd_flow_director_ip_dst,
> (void *)&cmd_flow_director_port_dst,
Good catch, thanks!
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> > This patch fixes issue during dealing with flow
> > director filter.
> >
> > Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>
> Good catch, thanks!
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied, thanks
@@ -9900,11 +9900,11 @@ struct cmd_flow_director_result {
uint16_t port_dst;
cmdline_fixed_string_t verify_tag;
uint32_t verify_tag_value;
- cmdline_ipaddr_t tos;
+ cmdline_fixed_string_t tos;
uint8_t tos_value;
- cmdline_ipaddr_t proto;
+ cmdline_fixed_string_t proto;
uint8_t proto_value;
- cmdline_ipaddr_t ttl;
+ cmdline_fixed_string_t ttl;
uint8_t ttl_value;
cmdline_fixed_string_t vlan;
uint16_t vlan_value;
@@ -10515,7 +10515,7 @@ cmdline_parse_inst_t cmd_add_del_sctp_flow_director = {
(void *)&cmd_flow_director_flow_type,
(void *)&cmd_flow_director_src,
(void *)&cmd_flow_director_ip_src,
- (void *)&cmd_flow_director_port_dst,
+ (void *)&cmd_flow_director_port_src,
(void *)&cmd_flow_director_dst,
(void *)&cmd_flow_director_ip_dst,
(void *)&cmd_flow_director_port_dst,