diff mbox

[dpdk-dev] net/mrvl: convert license headers to SPDX tags

Message ID 1520588391-18110-1-git-send-email-tdu@semihalf.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tomasz Duszynski March 9, 2018, 9:39 a.m. UTC 
  Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/net/mrvl/Makefile      | 35 ++++-------------------------------
 drivers/net/mrvl/mrvl_ethdev.c | 36 ++++--------------------------------
 drivers/net/mrvl/mrvl_ethdev.h | 36 ++++--------------------------------
 drivers/net/mrvl/mrvl_qos.c    | 36 ++++--------------------------------
 drivers/net/mrvl/mrvl_qos.h    | 36 ++++--------------------------------
 5 files changed, 20 insertions(+), 159 deletions(-)

Comments

Ferruh Yigit March 9, 2018, 10:05 a.m. UTC | #1 
On 3/9/2018 9:39 AM, Tomasz Duszynski wrote:
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
>  drivers/net/mrvl/Makefile      | 35 ++++-------------------------------
>  drivers/net/mrvl/mrvl_ethdev.c | 36 ++++--------------------------------
>  drivers/net/mrvl/mrvl_ethdev.h | 36 ++++--------------------------------
>  drivers/net/mrvl/mrvl_qos.c    | 36 ++++--------------------------------
>  drivers/net/mrvl/mrvl_qos.h    | 36 ++++--------------------------------
>  5 files changed, 20 insertions(+), 159 deletions(-)
> 
> diff --git a/drivers/net/mrvl/Makefile b/drivers/net/mrvl/Makefile
> index f75e53c..41ae6ec 100644
> --- a/drivers/net/mrvl/Makefile
> +++ b/drivers/net/mrvl/Makefile
> @@ -1,34 +1,7 @@
> -#   BSD LICENSE
> -#
> -#   Copyright(c) 2017 Marvell International Ltd.
> -#   Copyright(c) 2017 Semihalf.
> -#   All rights reserved.

<...>

> +# Copyright(c) 2018 Marvell International Ltd.
> +# Copyright(c) 2018 Semihalf.
> +# All rights reserved.

Hi Tomasz,

Related to the Copyright year update (2017 -> 2018), I am definitely not right
person for legal issues,

but as far as I know that year indicates the year that copyright starts, I
assume you don't want to start your copyright from beginning 2018 but you want
to extend it, for that case year part should be "start - extended", like:
# Copyright(c) 2017-2018 Marvell International Ltd.

cc'ed Hemant who know more than me about licensing.

Thanks,
ferruh
Hemant Agrawal March 9, 2018, 5:33 p.m. UTC | #2 
Hi,
On 3/9/2018 3:35 PM, Ferruh Yigit wrote:
> On 3/9/2018 9:39 AM, Tomasz Duszynski wrote:
>> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>> ---
>>   drivers/net/mrvl/Makefile      | 35 ++++-------------------------------
>>   drivers/net/mrvl/mrvl_ethdev.c | 36 ++++--------------------------------
>>   drivers/net/mrvl/mrvl_ethdev.h | 36 ++++--------------------------------
>>   drivers/net/mrvl/mrvl_qos.c    | 36 ++++--------------------------------
>>   drivers/net/mrvl/mrvl_qos.h    | 36 ++++--------------------------------
>>   5 files changed, 20 insertions(+), 159 deletions(-)
>>
>> diff --git a/drivers/net/mrvl/Makefile b/drivers/net/mrvl/Makefile
>> index f75e53c..41ae6ec 100644
>> --- a/drivers/net/mrvl/Makefile
>> +++ b/drivers/net/mrvl/Makefile
>> @@ -1,34 +1,7 @@
>> -#   BSD LICENSE
>> -#
>> -#   Copyright(c) 2017 Marvell International Ltd.
>> -#   Copyright(c) 2017 Semihalf.
>> -#   All rights reserved.
> 
> <...>
> 
>> +# Copyright(c) 2018 Marvell International Ltd.
>> +# Copyright(c) 2018 Semihalf.
>> +# All rights reserved.
> 
> Hi Tomasz,
> 
> Related to the Copyright year update (2017 -> 2018), I am definitely not right
> person for legal issues,
> 
> but as far as I know that year indicates the year that copyright starts, I
> assume you don't want to start your copyright from beginning 2018 but you want
> to extend it, for that case year part should be "start - extended", like:
> # Copyright(c) 2017-2018 Marvell International Ltd.
> 
> cc'ed Hemant who know more than me about licensing.

Well, as a DPDK contribution it is upto Marvell/Semihalf to change it.

However, Ferruh made a good suggestion here.

if nothing important is added, ideally the copyright year should not 
change. So, don't change the copyright  year or make it "Copyright(c) 
2017-2018" . It is not good for Marvell/Semihalf to just relinquish the 
2017 copyright for no good reason.

Regards,
Hemant


> 
> Thanks,
> ferruh
>
Tomasz Duszynski March 12, 2018, 7:01 a.m. UTC | #3 
On Fri, Mar 09, 2018 at 11:03:51PM +0530, Hemant Agrawal wrote:
> Hi,
> On 3/9/2018 3:35 PM, Ferruh Yigit wrote:
> >On 3/9/2018 9:39 AM, Tomasz Duszynski wrote:
> >>Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> >>---
> >>  drivers/net/mrvl/Makefile      | 35 ++++-------------------------------
> >>  drivers/net/mrvl/mrvl_ethdev.c | 36 ++++--------------------------------
> >>  drivers/net/mrvl/mrvl_ethdev.h | 36 ++++--------------------------------
> >>  drivers/net/mrvl/mrvl_qos.c    | 36 ++++--------------------------------
> >>  drivers/net/mrvl/mrvl_qos.h    | 36 ++++--------------------------------
> >>  5 files changed, 20 insertions(+), 159 deletions(-)
> >>
> >>diff --git a/drivers/net/mrvl/Makefile b/drivers/net/mrvl/Makefile
> >>index f75e53c..41ae6ec 100644
> >>--- a/drivers/net/mrvl/Makefile
> >>+++ b/drivers/net/mrvl/Makefile
> >>@@ -1,34 +1,7 @@
> >>-#   BSD LICENSE
> >>-#
> >>-#   Copyright(c) 2017 Marvell International Ltd.
> >>-#   Copyright(c) 2017 Semihalf.
> >>-#   All rights reserved.
> >
> ><...>
> >
> >>+# Copyright(c) 2018 Marvell International Ltd.
> >>+# Copyright(c) 2018 Semihalf.
> >>+# All rights reserved.
> >
> >Hi Tomasz,
> >
> >Related to the Copyright year update (2017 -> 2018), I am definitely not right
> >person for legal issues,
> >
> >but as far as I know that year indicates the year that copyright starts, I
> >assume you don't want to start your copyright from beginning 2018 but you want
> >to extend it, for that case year part should be "start - extended", like:
> ># Copyright(c) 2017-2018 Marvell International Ltd.
> >
> >cc'ed Hemant who know more than me about licensing.
>
> Well, as a DPDK contribution it is upto Marvell/Semihalf to change it.
>
> However, Ferruh made a good suggestion here.
>
> if nothing important is added, ideally the copyright year should not change.
> So, don't change the copyright  year or make it "Copyright(c) 2017-2018" .
> It is not good for Marvell/Semihalf to just relinquish the 2017 copyright
> for no good reason.
>
> Regards,
> Hemant

Fair enough. I'll send v2 with the year unchanged.

>
>
> >
> >Thanks,
> >ferruh
> >
>

--
- Tomasz Duszyński
De Lara Guarch, Pablo March 14, 2018, 10:51 a.m. UTC | #4 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Friday, March 9, 2018 9:40 AM
> To: dev@dpdk.org
> Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> jck@semihalf.com; jianbo.liu@arm.com; Tomasz Duszynski
> <tdu@semihalf.com>
> Subject: [dpdk-dev] [PATCH] net/mrvl: convert license headers to SPDX tags
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
Ferruh Yigit March 14, 2018, 3:36 p.m. UTC | #5 
On 3/14/2018 10:51 AM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
>> Sent: Friday, March 9, 2018 9:40 AM
>> To: dev@dpdk.org
>> Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>> jck@semihalf.com; jianbo.liu@arm.com; Tomasz Duszynski
>> <tdu@semihalf.com>
>> Subject: [dpdk-dev] [PATCH] net/mrvl: convert license headers to SPDX tags
>>
>> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> 
> Applied to dpdk-next-crypto.

Crypto one [1] merged into dpdk-next-crypto,
Net one v2 [2] merged into dpdk-next-net.

[1]
https://dpdk.org/ml/archives/dev/2018-March/092443.html

[2]
https://dpdk.org/ml/archives/dev/2018-March/092441.html
diff mbox

Patch

diff --git a/drivers/net/mrvl/Makefile b/drivers/net/mrvl/Makefile
index f75e53c..41ae6ec 100644
--- a/drivers/net/mrvl/Makefile
+++ b/drivers/net/mrvl/Makefile
@@ -1,34 +1,7 @@ 
-#   BSD LICENSE
-#
-#   Copyright(c) 2017 Marvell International Ltd.
-#   Copyright(c) 2017 Semihalf.
-#   All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-#     * Redistributions of source code must retain the above copyright
-#       notice, this list of conditions and the following disclaimer.
-#     * Redistributions in binary form must reproduce the above copyright
-#       notice, this list of conditions and the following disclaimer in
-#       the documentation and/or other materials provided with the
-#       distribution.
-#     * Neither the name of the copyright holder nor the names of its
-#       contributors may be used to endorse or promote products derived
-#       from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Marvell International Ltd.
+# Copyright(c) 2018 Semihalf.
+# All rights reserved.
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c
index 705c4bd..db21519 100644
--- a/drivers/net/mrvl/mrvl_ethdev.c
+++ b/drivers/net/mrvl/mrvl_ethdev.c
@@ -1,35 +1,7 @@ 
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2017 Marvell International Ltd.
- *   Copyright(c) 2017 Semihalf.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Semihalf nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Marvell International Ltd.
+ * Copyright(c) 2018 Semihalf.
+ * All rights reserved.
  */
 
 #include <rte_ethdev_driver.h>
diff --git a/drivers/net/mrvl/mrvl_ethdev.h b/drivers/net/mrvl/mrvl_ethdev.h
index f7afae5..a14dbd2 100644
--- a/drivers/net/mrvl/mrvl_ethdev.h
+++ b/drivers/net/mrvl/mrvl_ethdev.h
@@ -1,35 +1,7 @@ 
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2017 Marvell International Ltd.
- *   Copyright(c) 2017 Semihalf.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of the copyright holder nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Marvell International Ltd.
+ * Copyright(c) 2018 Semihalf.
+ * All rights reserved.
  */
 
 #ifndef _MRVL_ETHDEV_H_
diff --git a/drivers/net/mrvl/mrvl_qos.c b/drivers/net/mrvl/mrvl_qos.c
index fbb3681..4281b41 100644
--- a/drivers/net/mrvl/mrvl_qos.c
+++ b/drivers/net/mrvl/mrvl_qos.c
@@ -1,35 +1,7 @@ 
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2017 Marvell International Ltd.
- *   Copyright(c) 2017 Semihalf.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of the copyright holder nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Marvell International Ltd.
+ * Copyright(c) 2018 Semihalf.
+ * All rights reserved.
  */
 
 #include <stdint.h>
diff --git a/drivers/net/mrvl/mrvl_qos.h b/drivers/net/mrvl/mrvl_qos.h
index ae7508c..61048de 100644
--- a/drivers/net/mrvl/mrvl_qos.h
+++ b/drivers/net/mrvl/mrvl_qos.h
@@ -1,35 +1,7 @@ 
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2017 Marvell International Ltd.
- *   Copyright(c) 2017 Semihalf.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of the copyright holder nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Marvell International Ltd.
+ * Copyright(c) 2018 Semihalf.
+ * All rights reserved.
  */
 
 #ifndef _MRVL_QOS_H_