diff mbox

[dpdk-dev] assign QAT cryptodev to correct NUMA node

Message ID 1520618436-6089-1-git-send-email-lee.roberts@hpe.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Lee Roberts March 9, 2018, 6 p.m. UTC 
  rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
for its socket_id rather than the socket_id of the initializing process.

Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
---
 drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fiona Trahe March 9, 2018, 6:17 p.m. UTC | #1 
Hi Lee,
Thanks for investigating this.

> -----Original Message-----
> From: Lee Roberts [mailto:lee.roberts@hpe.com]
> Sent: Friday, March 9, 2018 6:01 PM
> To: Griffin, John <john.griffin@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; Lee Roberts <lee.roberts@hpe.com>
> Subject: [PATCH] assign QAT cryptodev to correct NUMA node
> 
> rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
> for its socket_id rather than the socket_id of the initializing process.
> 
> Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
De Lara Guarch, Pablo March 26, 2018, 9:03 a.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Trahe, Fiona
> Sent: Friday, March 9, 2018 6:18 PM
> To: Lee Roberts <lee.roberts@hpe.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA
> node
> 
> Hi Lee,
> Thanks for investigating this.
> 
> > -----Original Message-----
> > From: Lee Roberts [mailto:lee.roberts@hpe.com]
> > Sent: Friday, March 9, 2018 6:01 PM
> > To: Griffin, John <john.griffin@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> > Cc: dev@dpdk.org; Lee Roberts <lee.roberts@hpe.com>
> > Subject: [PATCH] assign QAT cryptodev to correct NUMA node
> >
> > rte_cryptodev_pmd_init_params should use NUMA node of the QAT
> device
> > for its socket_id rather than the socket_id of the initializing process.
> >
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Modified title to "crypto/qat: assign device to correct NUMA node"

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c
index bf83740..82641aa 100644
--- a/drivers/crypto/qat/rte_qat_cryptodev.c
+++ b/drivers/crypto/qat/rte_qat_cryptodev.c
@@ -130,7 +130,7 @@  static int crypto_qat_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 {
 	struct rte_cryptodev_pmd_init_params init_params = {
 		.name = "",
-		.socket_id = rte_socket_id(),
+		.socket_id = pci_dev->device.numa_node,
 		.private_data_size = sizeof(struct qat_pmd_private),
 		.max_nb_sessions = RTE_QAT_PMD_MAX_NB_SESSIONS
 	};