diff mbox

[dpdk-dev,v2] net/i40e: remove unnecessary FDIR mask configuration

Message ID 1522305238-50223-1-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Xing, Beilei March 29, 2018, 6:33 a.m. UTC 
  Remove unnecessary FDIR mask configuration, otherwise
flow directory mask will be changed when configuring
hash input set.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---

v2 change:
 - Rebase code base.

 drivers/net/i40e/rte_pmd_i40e.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Zhang, Helin March 30, 2018, 3:04 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Thursday, March 29, 2018 2:34 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/i40e: remove unnecessary FDIR mask
> configuration
> 
> Remove unnecessary FDIR mask configuration, otherwise flow directory mask
> will be changed when configuring hash input set.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin
diff mbox

Patch

diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index 5a837d7..9f9a650 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -3103,10 +3103,6 @@  rte_pmd_i40e_inset_set(uint16_t port, uint8_t pctype,
 		return -ENOTSUP;
 	}
 
-	/* Clear mask first */
-	for (i = 0; i < 2; i++)
-		i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype), 0);
-
 	inset_reg = inset->inset;
 	for (i = 0; i < 2; i++)
 		mask_reg[i] = (inset->mask[i].field_idx << 16) |