net/i40e: fix PPPoL2TP packet type parser issue

Message ID 1530754574-62601-1-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/i40e: fix PPPoL2TP packet type parser issue |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei July 5, 2018, 1:36 a.m. UTC
  Since PPPoL2TP profile is updated, PPPoL2TP packet type
parser will be false with the current parser function.
This patch fixes the issue.

Fixes: 11556c915a08 ("net/i40e: improve packet type parser")
Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Lin, Xueqin July 5, 2018, 6:32 a.m. UTC | #1
> -----Original Message-----
 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
 > Sent: Thursday, July 5, 2018 9:36 AM
 > To: Zhang, Qi Z <qi.z.zhang@intel.com>
 > Cc: dev@dpdk.org; stable@dpdk.org
 > Subject: [dpdk-dev] [PATCH] net/i40e: fix PPPoL2TP packet type parser
 > issue
 >
 > Since PPPoL2TP profile is updated, PPPoL2TP packet type parser will be
 > false with the current parser function.
 > This patch fixes the issue.
 >
 > Fixes: 11556c915a08 ("net/i40e: improve packet type parser")
 > Cc: stable@dpdk.org
 >
 > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Tested-by: Xueqin Lin <xueqin.lin@intel.com>
  
Qi Zhang July 9, 2018, 12:57 p.m. UTC | #2
> -----Original Message-----
> From: Lin, Xueqin
> Sent: Thursday, July 5, 2018 2:33 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: FW: [dpdk-dev] [PATCH] net/i40e: fix PPPoL2TP packet type parser
> issue
> 
> 
> 
>  > -----Original Message-----
>  > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing  > Sent:
> Thursday, July 5, 2018 9:36 AM  > To: Zhang, Qi Z <qi.z.zhang@intel.com>  >
> Cc: dev@dpdk.org; stable@dpdk.org  > Subject: [dpdk-dev] [PATCH] net/i40e:
> fix PPPoL2TP packet type parser  > issue  >  > Since PPPoL2TP profile is
> updated, PPPoL2TP packet type parser will be  > false with the current parser
> function.
>  > This patch fixes the issue.
>  >
>  > Fixes: 11556c915a08 ("net/i40e: improve packet type parser")  > Cc:
> stable@dpdk.org  >  

> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Tested-by: Xueqin Lin <xueqin.lin@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks!
Qi


>
  
Qi Zhang July 9, 2018, 12:58 p.m. UTC | #3
> -----Original Message-----
> From: Lin, Xueqin
> Sent: Thursday, July 5, 2018 2:33 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: FW: [dpdk-dev] [PATCH] net/i40e: fix PPPoL2TP packet type parser
> issue
> 
> 
> 
>  > -----Original Message-----
>  > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing  > Sent:
> Thursday, July 5, 2018 9:36 AM  > To: Zhang, Qi Z <qi.z.zhang@intel.com>  >
> Cc: dev@dpdk.org; stable@dpdk.org  > Subject: [dpdk-dev] [PATCH] net/i40e:
> fix PPPoL2TP packet type parser  > issue  >  > Since PPPoL2TP profile is
> updated, PPPoL2TP packet type parser will be  > false with the current parser
> function.
>  > This patch fixes the issue.
>  >
>  > Fixes: 11556c915a08 ("net/i40e: improve packet type parser")  > Cc:
> stable@dpdk.org  >  

> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Tested-by: Xueqin Lin <xueqin.lin@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks!
Qi
>
  

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index c47b9f5..54d9c5a 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12137,7 +12137,8 @@  i40e_update_customized_ptype(struct rte_eth_dev *dev, uint8_t *pkg,
 					ptype_mapping[i].sw_ptype |=
 						RTE_PTYPE_TUNNEL_GRENAT;
 					in_tunnel = true;
-				} else if (!strncasecmp(name, "L2TPV2CTL", 9)) {
+				} else if (!strncasecmp(name, "L2TPV2CTL", 9) ||
+					   !strncasecmp(name, "L2TPV2", 6)) {
 					ptype_mapping[i].sw_ptype |=
 						RTE_PTYPE_TUNNEL_L2TP;
 					in_tunnel = true;