diff mbox series

app/test: fix uninitialized port configuration

Message ID 1533046581-15591-1-git-send-email-radu.nicolau@intel.com (mailing list archive)
State Accepted, archived
Headers
Series app/test: fix uninitialized port configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Radu Nicolau July 31, 2018, 2:16 p.m. UTC 
  test_pmd_ring_pair_create_attach() uses an uninitialized
struct rte_eth_conf object

Fixes: 51f567129c94 ("app/test: add pmd_ring")
Cc: stable@dpdk.org

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 test/test/test_pmd_ring.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Iremonger, Bernard Aug. 1, 2018, 9:56 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Radu Nicolau
> Sent: Tuesday, July 31, 2018 3:16 PM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Nicolau, Radu <radu.nicolau@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration
> 
> test_pmd_ring_pair_create_attach() uses an uninitialized struct rte_eth_conf
> object
> 
> Fixes: 51f567129c94 ("app/test: add pmd_ring")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Thomas Monjalon Aug. 1, 2018, 2:09 p.m. UTC | #2 
> > test_pmd_ring_pair_create_attach() uses an uninitialized struct rte_eth_conf
> > object
> > 
> > Fixes: 51f567129c94 ("app/test: add pmd_ring")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/test/test/test_pmd_ring.c b/test/test/test_pmd_ring.c
index 2196201..19d7d20 100644
--- a/test/test/test_pmd_ring.c
+++ b/test/test/test_pmd_ring.c
@@ -218,6 +218,8 @@  test_pmd_ring_pair_create_attach(int portd, int porte)
 	struct rte_mbuf buf, *pbuf = &buf;
 	struct rte_eth_conf null_conf;
 
+	memset(&null_conf, 0, sizeof(struct rte_eth_conf));
+
 	if ((rte_eth_dev_configure(portd, 1, 1, &null_conf) < 0)
 		|| (rte_eth_dev_configure(porte, 1, 1, &null_conf) < 0)) {
 		printf("Configure failed for port\n");