diff mbox series

meter: remove experimental from profile APIs

Message ID 1533137449-23445-1-git-send-email-ktraynor@redhat.com (mailing list archive)
State Accepted, archived
Headers show
Series meter: remove experimental from profile APIs | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

Kevin Traynor Aug. 1, 2018, 3:30 p.m. UTC
As per guideline that new APIs must be experimental
for at least one release, it is now possible to remove
the experimental tag from:

rte_meter_srtcm_profile_config()
rte_meter_trtcm_profile_config()

Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 examples/qos_meter/Makefile            | 1 -
 examples/qos_meter/meson.build         | 1 -
 lib/librte_meter/rte_meter.c           | 4 ++--
 lib/librte_meter/rte_meter.h           | 5 ++---
 lib/librte_meter/rte_meter_version.map | 2 +-
 5 files changed, 5 insertions(+), 8 deletions(-)

Comments

Cristian Dumitrescu Aug. 1, 2018, 3:35 p.m. UTC | #1
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Wednesday, August 1, 2018 4:31 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Kevin Traynor <ktraynor@redhat.com>
> Subject: [PATCH] meter: remove experimental from profile APIs
> 
> As per guideline that new APIs must be experimental
> for at least one release, it is now possible to remove
> the experimental tag from:
> 
> rte_meter_srtcm_profile_config()
> rte_meter_trtcm_profile_config()
> 
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>  examples/qos_meter/Makefile            | 1 -
>  examples/qos_meter/meson.build         | 1 -
>  lib/librte_meter/rte_meter.c           | 4 ++--
>  lib/librte_meter/rte_meter.h           | 5 ++---
>  lib/librte_meter/rte_meter_version.map | 2 +-
>  5 files changed, 5 insertions(+), 8 deletions(-)
> 

Thanks, Kevin!

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thomas Monjalon Aug. 5, 2018, 11:16 p.m. UTC | #2
> > As per guideline that new APIs must be experimental
> > for at least one release, it is now possible to remove
> > the experimental tag from:
> > 
> > rte_meter_srtcm_profile_config()
> > rte_meter_trtcm_profile_config()
> > 
> > Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> 
> Thanks, Kevin!
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/examples/qos_meter/Makefile b/examples/qos_meter/Makefile
index 6da2407..46341b1 100644
--- a/examples/qos_meter/Makefile
+++ b/examples/qos_meter/Makefile
@@ -51,5 +51,4 @@  RTE_TARGET ?= x86_64-native-linuxapp-gcc
 include $(RTE_SDK)/mk/rte.vars.mk
 
-CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
diff --git a/examples/qos_meter/meson.build b/examples/qos_meter/meson.build
index 10cd4bc..ef7779f 100644
--- a/examples/qos_meter/meson.build
+++ b/examples/qos_meter/meson.build
@@ -8,5 +8,4 @@ 
 
 deps += 'meter'
-allow_experimental_apis = true
 sources = files(
 	'main.c', 'rte_policer.c'
diff --git a/lib/librte_meter/rte_meter.c b/lib/librte_meter/rte_meter.c
index 59af5ef..473f69a 100644
--- a/lib/librte_meter/rte_meter.c
+++ b/lib/librte_meter/rte_meter.c
@@ -31,5 +31,5 @@ 
 }
 
-int __rte_experimental
+int
 rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p,
 	struct rte_meter_srtcm_params *params)
@@ -69,5 +69,5 @@ 
 }
 
-int __rte_experimental
+int
 rte_meter_trtcm_profile_config(struct rte_meter_trtcm_profile *p,
 	struct rte_meter_trtcm_params *params)
diff --git a/lib/librte_meter/rte_meter.h b/lib/librte_meter/rte_meter.h
index 03d8056..58a0515 100644
--- a/lib/librte_meter/rte_meter.h
+++ b/lib/librte_meter/rte_meter.h
@@ -21,5 +21,4 @@ 
 
 #include <stdint.h>
-#include <rte_compat.h>
 
 /*
@@ -83,5 +82,5 @@  struct rte_meter_trtcm_params {
  *    0 upon success, error code otherwise
  */
-int __rte_experimental
+int
 rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p,
 	struct rte_meter_srtcm_params *params);
@@ -97,5 +96,5 @@  struct rte_meter_trtcm_params {
  *    0 upon success, error code otherwise
  */
-int __rte_experimental
+int
 rte_meter_trtcm_profile_config(struct rte_meter_trtcm_profile *p,
 	struct rte_meter_trtcm_params *params);
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index 9215d4c..cb79f0c 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -12,5 +12,5 @@  DPDK_2.0 {
 };
 
-EXPERIMENTAL {
+DPDK_18.08 {
 	global: