diff mbox series

[v2] ethdev: decrease log level for successful API

Message ID 1533235181-6199-1-git-send-email-ktraynor@redhat.com (mailing list archive)
State Accepted, archived
Headers show
Series [v2] ethdev: decrease log level for successful API | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

Kevin Traynor Aug. 2, 2018, 6:39 p.m. UTC
Change log level of messages from ERR to INFO where
the post condition of the API is success, but no action
was actually needed as the condition already existed.
e.g. calling rte_eth_dev_start() for a device that is
already started.

Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 lib/librte_ethdev/rte_ethdev.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Andrew Rybchenko Aug. 3, 2018, 8:04 a.m. UTC | #1
On 02.08.2018 21:39, Kevin Traynor wrote:
> Change log level of messages from ERR to INFO where
> the post condition of the API is success, but no action
> was actually needed as the condition already existed.
> e.g. calling rte_eth_dev_start() for a device that is
> already started.
>
> Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Thomas Monjalon Aug. 5, 2018, 1:29 p.m. UTC | #2
03/08/2018 10:04, Andrew Rybchenko:
> On 02.08.2018 21:39, Kevin Traynor wrote:
> > Change log level of messages from ERR to INFO where
> > the post condition of the API is success, but no action
> > was actually needed as the condition already existed.
> > e.g. calling rte_eth_dev_start() for a device that is
> > already started.
> >
> > Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index c7ab157..4c32025 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -797,5 +797,5 @@  struct rte_eth_dev *
 
 	if (dev->data->rx_queue_state[rx_queue_id] != RTE_ETH_QUEUE_STATE_STOPPED) {
-		RTE_ETHDEV_LOG(ERR,
+		RTE_ETHDEV_LOG(INFO,
 			"Queue %"PRIu16" of device with port_id=%"PRIu16" already started\n",
 			rx_queue_id, port_id);
@@ -824,5 +824,5 @@  struct rte_eth_dev *
 
 	if (dev->data->rx_queue_state[rx_queue_id] == RTE_ETH_QUEUE_STATE_STOPPED) {
-		RTE_ETHDEV_LOG(ERR,
+		RTE_ETHDEV_LOG(INFO,
 			"Queue %"PRIu16" of device with port_id=%"PRIu16" already stopped\n",
 			rx_queue_id, port_id);
@@ -857,5 +857,5 @@  struct rte_eth_dev *
 
 	if (dev->data->tx_queue_state[tx_queue_id] != RTE_ETH_QUEUE_STATE_STOPPED) {
-		RTE_ETHDEV_LOG(ERR,
+		RTE_ETHDEV_LOG(INFO,
 			"Queue %"PRIu16" of device with port_id=%"PRIu16" already started\n",
 			tx_queue_id, port_id);
@@ -882,5 +882,5 @@  struct rte_eth_dev *
 
 	if (dev->data->tx_queue_state[tx_queue_id] == RTE_ETH_QUEUE_STATE_STOPPED) {
-		RTE_ETHDEV_LOG(ERR,
+		RTE_ETHDEV_LOG(INFO,
 			"Queue %"PRIu16" of device with port_id=%"PRIu16" already stopped\n",
 			tx_queue_id, port_id);
@@ -1287,5 +1287,5 @@  struct rte_eth_dev *
 
 	if (dev->data->dev_started != 0) {
-		RTE_ETHDEV_LOG(ERR,
+		RTE_ETHDEV_LOG(INFO,
 			"Device with port_id=%"PRIu16" already started\n",
 			port_id);
@@ -1319,5 +1319,5 @@  struct rte_eth_dev *
 
 	if (dev->data->dev_started == 0) {
-		RTE_ETHDEV_LOG(ERR,
+		RTE_ETHDEV_LOG(INFO,
 			"Device with port_id=%"PRIu16" already stopped\n",
 			port_id);