[v3] net/i40e: add alarm handler

  This patch adds alarm handler, and then i40e
PF will use alarm handler instead of interrupt
handler when device is started and Rx interrupt
mode is disabled. This way will save CPU cycles
during receiving packets.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 67 ++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 65 insertions(+), 2 deletions(-)

v3 changes:
 - Replace interrupt handler with alarm handler when device is started.
v2 changes:
 - Remove PF interrupt handler only when multi-driver is enabled.
  

> -----Original Message-----
> From: Xing, Beilei
> Sent: Tuesday, September 11, 2018 11:36 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v3] net/i40e: add alarm handler
> 
> This patch adds alarm handler, and then i40e PF will use alarm handler instead
> of interrupt handler when device is started and Rx interrupt mode is disabled.
> This way will save CPU cycles during receiving packets.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
  

On 9/11/2018 4:35 AM, Beilei Xing wrote:
> This patch adds alarm handler, and then i40e
> PF will use alarm handler instead of interrupt
> handler when device is started and Rx interrupt
> mode is disabled. This way will save CPU cycles
> during receiving packets.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

> +static void
> +i40e_dev_alarm_handler(void *param)
> +{
> +	struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
> +	struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +	uint32_t icr0;
> +
> +	/* Disable interrupt */
> +	i40e_pf_disable_irq0(hw);
> +
> +	/* read out interrupt causes */
> +	icr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);
> +
> +	/* No interrupt event indicated */
> +	if (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK)) {
> +		PMD_DRV_LOG(INFO, "No interrupt event");

Hi Beilei, Qi,

This prints an "info" level log each 50ms which makes console unusable.

This patch already merged in master repo.
So can you please send another patch to remove the log?

Thanks,
ferruh
  

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, September 17, 2018 7:08 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: add alarm handler
> 
> On 9/11/2018 4:35 AM, Beilei Xing wrote:
> > This patch adds alarm handler, and then i40e PF will use alarm handler
> > instead of interrupt handler when device is started and Rx interrupt
> > mode is disabled. This way will save CPU cycles during receiving
> > packets.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> 
> <...>
> 
> > +static void
> > +i40e_dev_alarm_handler(void *param)
> > +{
> > +	struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
> > +	struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> > +	uint32_t icr0;
> > +
> > +	/* Disable interrupt */
> > +	i40e_pf_disable_irq0(hw);
> > +
> > +	/* read out interrupt causes */
> > +	icr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);
> > +
> > +	/* No interrupt event indicated */
> > +	if (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK)) {
> > +		PMD_DRV_LOG(INFO, "No interrupt event");
> 
> Hi Beilei, Qi,
> 
> This prints an "info" level log each 50ms which makes console unusable.
> 
> This patch already merged in master repo.
> So can you please send another patch to remove the log?

OK. I will send another patch.

> 
> Thanks,
> ferruh