[v2] net/i40e: remove driver log
Checks
Commit Message
Remove driver log when no interrupt event indicated
in alarm handler for both PF and VF, otherwise there
will be lots of prints which makes console unusable.
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
v2 changes:
- Also remove the driver log for VF.
drivers/net/i40e/i40e_ethdev.c | 4 +---
drivers/net/i40e/i40e_ethdev_vf.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
Comments
On 9/18/2018 6:44 AM, Beilei Xing wrote:
> Remove driver log when no interrupt event indicated
> in alarm handler for both PF and VF, otherwise there
> will be lots of prints which makes console unusable.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, September 18, 2018 9:04 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove driver log
>
> On 9/18/2018 6:44 AM, Beilei Xing wrote:
> > Remove driver log when no interrupt event indicated in alarm handler
> > for both PF and VF, otherwise there will be lots of prints which makes
> > console unusable.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net-intel
Thanks
Qi
@@ -6579,10 +6579,8 @@ i40e_dev_alarm_handler(void *param)
icr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);
/* No interrupt event indicated */
- if (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK)) {
- PMD_DRV_LOG(INFO, "No interrupt event");
+ if (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK))
goto done;
- }
if (icr0 & I40E_PFINT_ICR0_ECC_ERR_MASK)
PMD_DRV_LOG(ERR, "ICR0: unrecoverable ECC error");
if (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK)
@@ -1384,10 +1384,8 @@ i40evf_dev_alarm_handler(void *param)
icr0 = I40E_READ_REG(hw, I40E_VFINT_ICR01);
/* No interrupt event indicated */
- if (!(icr0 & I40E_VFINT_ICR01_INTEVENT_MASK)) {
- PMD_DRV_LOG(DEBUG, "No interrupt event, nothing to do");
+ if (!(icr0 & I40E_VFINT_ICR01_INTEVENT_MASK))
goto done;
- }
if (icr0 & I40E_VFINT_ICR01_ADMINQ_MASK) {
PMD_DRV_LOG(DEBUG, "ICR01_ADMINQ is reported");