net/i40e: update Rx checksum offload

Message ID 1537515374-40502-1-git-send-email-beilei.xing@intel.com (mailing list archive)
State Superseded, archived
Headers
Series net/i40e: update Rx checksum offload |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei Sept. 21, 2018, 7:36 a.m. UTC
  HW supports Rx scatter offload, this patch updates
Rx scatter offload for PF.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Ananyev, Konstantin Sept. 21, 2018, 8:15 a.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Friday, September 21, 2018 8:36 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload
> 
> HW supports Rx scatter offload, this patch updates
> Rx scatter offload for PF.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 24d73f2..37c9c08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3378,6 +3378,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>  		DEV_RX_OFFLOAD_TCP_CKSUM |
>  		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
>  		DEV_RX_OFFLOAD_KEEP_CRC |
> +		DEV_RX_OFFLOAD_SCATTER |
>  		DEV_RX_OFFLOAD_VLAN_EXTEND |
>  		DEV_RX_OFFLOAD_VLAN_FILTER |
>  		DEV_RX_OFFLOAD_JUMBO_FRAME;
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.5.5
  
Qi Zhang Sept. 21, 2018, 1:58 p.m. UTC | #2
> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Friday, September 21, 2018 4:16 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> > Sent: Friday, September 21, 2018 8:36 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload
> >
> > HW supports Rx scatter offload, this patch updates Rx scatter offload
> > for PF.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 24d73f2..37c9c08 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -3378,6 +3378,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> >  		DEV_RX_OFFLOAD_TCP_CKSUM |
> >  		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> >  		DEV_RX_OFFLOAD_KEEP_CRC |
> > +		DEV_RX_OFFLOAD_SCATTER |
> >  		DEV_RX_OFFLOAD_VLAN_EXTEND |
> >  		DEV_RX_OFFLOAD_VLAN_FILTER |
> >  		DEV_RX_OFFLOAD_JUMBO_FRAME;
> > --
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> > 2.5.5
  
Kevin Traynor Sept. 25, 2018, 3:35 p.m. UTC | #3
On 09/21/2018 08:36 AM, Beilei Xing wrote:
> HW supports Rx scatter offload, this patch updates
> Rx scatter offload for PF.
> 

Should this be for stable branch also?

> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 24d73f2..37c9c08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3378,6 +3378,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>  		DEV_RX_OFFLOAD_TCP_CKSUM |
>  		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
>  		DEV_RX_OFFLOAD_KEEP_CRC |
> +		DEV_RX_OFFLOAD_SCATTER |
>  		DEV_RX_OFFLOAD_VLAN_EXTEND |
>  		DEV_RX_OFFLOAD_VLAN_FILTER |
>  		DEV_RX_OFFLOAD_JUMBO_FRAME;
>
  
Ferruh Yigit Sept. 25, 2018, 3:50 p.m. UTC | #4
On 9/25/2018 4:35 PM, Kevin Traynor wrote:
> On 09/21/2018 08:36 AM, Beilei Xing wrote:
>> HW supports Rx scatter offload, this patch updates
>> Rx scatter offload for PF.
>>
> 
> Should this be for stable branch also?

I think it should, I will update in next-net, Thanks for reminder.

> 
>> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>> ---
>>  drivers/net/i40e/i40e_ethdev.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 24d73f2..37c9c08 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -3378,6 +3378,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>>  		DEV_RX_OFFLOAD_TCP_CKSUM |
>>  		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
>>  		DEV_RX_OFFLOAD_KEEP_CRC |
>> +		DEV_RX_OFFLOAD_SCATTER |
>>  		DEV_RX_OFFLOAD_VLAN_EXTEND |
>>  		DEV_RX_OFFLOAD_VLAN_FILTER |
>>  		DEV_RX_OFFLOAD_JUMBO_FRAME;
>>
>
  

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 24d73f2..37c9c08 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3378,6 +3378,7 @@  i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_KEEP_CRC |
+		DEV_RX_OFFLOAD_SCATTER |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
 		DEV_RX_OFFLOAD_VLAN_FILTER |
 		DEV_RX_OFFLOAD_JUMBO_FRAME;