net/i40e: update Tx offload mask

Message ID 1540275271-71330-1-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/i40e: update Tx offload mask |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei Oct. 23, 2018, 6:14 a.m. UTC
  Tx offload mask is updated in following commit:
commit 1037ed842c37 ("mbuf: fix Tx offload mask").
Currently, the new added offload flags will be
not supported in PMD and application will fail
to call PMD transmit prepare function.
This patch updates PMD Tx offload mask.

Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/net/i40e/i40e_rxtx.c | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Qi Zhang Oct. 24, 2018, 8:40 p.m. UTC | #1
> -----Original Message-----
> From: Xing, Beilei
> Sent: Tuesday, October 23, 2018 1:15 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/i40e: update Tx offload mask
> 
> Tx offload mask is updated in following commit:
> commit 1037ed842c37 ("mbuf: fix Tx offload mask").
> Currently, the new added offload flags will be not supported in PMD and
> application will fail to call PMD transmit prepare function.
> This patch updates PMD Tx offload mask.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
  
Xiaolong Ye Oct. 25, 2018, 5:35 a.m. UTC | #2
On 10/23, Beilei Xing wrote:
>Tx offload mask is updated in following commit:
>commit 1037ed842c37 ("mbuf: fix Tx offload mask").
>Currently, the new added offload flags will be
>not supported in PMD and application will fail

Shouldn't it be "the new added offlaod flags are not supported in PMD and xxxx"?

Thanks,
Xiaolong

>to call PMD transmit prepare function.
>This patch updates PMD Tx offload mask.
>
>Cc: stable@dpdk.org
>
>Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>---
> drivers/net/i40e/i40e_rxtx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
>index b2819f7..a827456 100644
>--- a/drivers/net/i40e/i40e_rxtx.c
>+++ b/drivers/net/i40e/i40e_rxtx.c
>@@ -55,6 +55,10 @@
> 		PKT_TX_OUTER_IP_CKSUM)
> 
> #define I40E_TX_OFFLOAD_MASK (  \
>+		PKT_TX_OUTER_IPV4 |	\
>+		PKT_TX_OUTER_IPV6 |	\
>+		PKT_TX_IPV4 |		\
>+		PKT_TX_IPV6 |		\
> 		PKT_TX_IP_CKSUM |       \
> 		PKT_TX_L4_MASK |        \
> 		PKT_TX_OUTER_IP_CKSUM | \
>-- 
>2.5.5
>
  

Patch

diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index b2819f7..a827456 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -55,6 +55,10 @@ 
 		PKT_TX_OUTER_IP_CKSUM)
 
 #define I40E_TX_OFFLOAD_MASK (  \
+		PKT_TX_OUTER_IPV4 |	\
+		PKT_TX_OUTER_IPV6 |	\
+		PKT_TX_IPV4 |		\
+		PKT_TX_IPV6 |		\
 		PKT_TX_IP_CKSUM |       \
 		PKT_TX_L4_MASK |        \
 		PKT_TX_OUTER_IP_CKSUM | \