diff mbox series

[v4] config: enable more than 128 cores for Arm64 platform

Message ID 1542872227-143453-1-git-send-email-joyce.kong@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series [v4] config: enable more than 128 cores for Arm64 platform | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Joyce Kong Nov. 22, 2018, 7:37 a.m. UTC
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128

The fix is to increase max_core to 256 on Arm64 platform.

Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
Cc: stable@dpdk.org

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
 config/arm/meson.build                     | 1 +
 config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
 2 files changed, 2 insertions(+)

Comments

Jerin Jacob Nov. 22, 2018, 11:04 a.m. UTC | #1
-----Original Message-----
> Date: Thu, 22 Nov 2018 15:37:07 +0800
> From: Joyce Kong <joyce.kong@arm.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
>  Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com,
>  stable@dpdk.org
> Subject: [PATCH v4] config: enable more than 128 cores for Arm64 platform
> X-Mailer: git-send-email 2.7.4
> 
> 
> When running dpdk applications on cores whose ids are bigger
> than original max_core setting, eal error as below:
> EAL: Detected 104 lcore(s)
> EAL: Detected 2 NUMA nodes
> EAL: invalid core list
> -l CORELIST core indexes between 0 and 128
> 
> The fix is to increase max_core to 256 on Arm64 platform.
> 
> Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>


Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  config/arm/meson.build                     | 1 +
>  config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index b755138..3f91725 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -46,6 +46,7 @@ flags_common_default = [
> 
>  flags_generic = [
>         ['RTE_MACHINE', '"armv8a"'],
> +       ['RTE_MAX_LCORE', 256],
>         ['RTE_CACHE_LINE_SIZE', 128]]
>  flags_cavium = [
>         ['RTE_MACHINE', '"thunderx"'],
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 1842744..a6ed90c 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -6,3 +6,4 @@
> 
>  CONFIG_RTE_TOOLCHAIN="gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=y
> +CONFIG_RTE_MAX_LCORE=256
> --
> 2.7.4
>
Thomas Monjalon Nov. 23, 2018, 12:49 a.m. UTC | #2
22/11/2018 12:04, Jerin Jacob:
> From: Joyce Kong <joyce.kong@arm.com>
> > 
> > When running dpdk applications on cores whose ids are bigger
> > than original max_core setting, eal error as below:
> > EAL: Detected 104 lcore(s)
> > EAL: Detected 2 NUMA nodes
> > EAL: invalid core list
> > -l CORELIST core indexes between 0 and 128
> > 
> > The fix is to increase max_core to 256 on Arm64 platform.
> > 
> > Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> 
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks

Note: Arm64 replace by arm64 to comply with Honnappa's naming recommendation.
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index b755138..3f91725 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -46,6 +46,7 @@  flags_common_default = [
 
 flags_generic = [
 	['RTE_MACHINE', '"armv8a"'],
+	['RTE_MAX_LCORE', 256],
 	['RTE_CACHE_LINE_SIZE', 128]]
 flags_cavium = [
 	['RTE_MACHINE', '"thunderx"'],
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 1842744..a6ed90c 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -6,3 +6,4 @@ 
 
 CONFIG_RTE_TOOLCHAIN="gcc"
 CONFIG_RTE_TOOLCHAIN_GCC=y
+CONFIG_RTE_MAX_LCORE=256