diff mbox series

[1/4] devtools: do not complain when reordering symbols

Message ID 1556894060-13573-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [1/4] devtools: do not complain when reordering symbols |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand May 3, 2019, 2:34 p.m. UTC 
  No need to shout when we are just reordering symbols in a section.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 devtools/check-symbol-change.sh | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Ray Kinsella May 3, 2019, 4:15 p.m. UTC | #1 
Hi David,

Do you have this script wired into the DPDK CI?
Or is this purely for testing before packaging?

Ray K

On 03/05/2019 15:34, David Marchand wrote:
> No need to shout when we are just reordering symbols in a section.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  devtools/check-symbol-change.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 40eb953..8da7650 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -121,6 +121,12 @@ check_for_rule_violations()
>  				continue
>  			fi
>  
> +			# This symbol is moving inside a section, nothing to do
> +			if [ "$oldsecname" = "$secname" ]
> +			then
> +				continue
> +			fi
> +
>  			# This symbol is moving between two sections (the
>  			# original section is not experimental).
>  			# This can be legit, just warn.
>
David Marchand May 3, 2019, 5:12 p.m. UTC | #2 
Hello Ray,

On Fri, May 3, 2019 at 6:16 PM Ray Kinsella <mdr@ashroe.eu> wrote:

> Do you have this script wired into the DPDK CI?
> Or is this purely for testing before packaging?
>

Iirc, Thomas has this script running on the server side.

See for example the report for this very patch on the dpdk-test ml:
http://mails.dpdk.org/archives/test-report/2019-May/081948.html

Which is seen in patchwork as:
http://patchwork.dpdk.org/patch/53255/

"ci/checkpatch success coding style OK"
diff mbox series

Patch

diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 40eb953..8da7650 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -121,6 +121,12 @@  check_for_rule_violations()
 				continue
 			fi
 
+			# This symbol is moving inside a section, nothing to do
+			if [ "$oldsecname" = "$secname" ]
+			then
+				continue
+			fi
+
 			# This symbol is moving between two sections (the
 			# original section is not experimental).
 			# This can be legit, just warn.