[1/5] test/table: remove duplicate macro

Message ID 1559129358-2935-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Headers
Series [1/5] test/table: remove duplicate macro |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail Compilation issues

Commit Message

David Marchand May 29, 2019, 11:29 a.m. UTC
  No need for this macro here, take it from librte_net.

Fixes: 24ac604ef746 ("net: add rte prefix to IP defines")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/test_table_acl.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
  

Comments

Olivier Matz May 29, 2019, 2:25 p.m. UTC | #1
On Wed, May 29, 2019 at 01:29:14PM +0200, David Marchand wrote:
> No need for this macro here, take it from librte_net.
> 
> Fixes: 24ac604ef746 ("net: add rte prefix to IP defines")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
  

Patch

diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c
index e01e1f9..cb039c0 100644
--- a/app/test/test_table_acl.c
+++ b/app/test/test_table_acl.c
@@ -2,16 +2,12 @@ 
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
+#include <rte_ip.h>
 #include <rte_string_fns.h>
 #include <rte_hexdump.h>
 #include "test_table.h"
 #include "test_table_acl.h"
 
-#define RTE_IPv4(a, b, c, d) ((uint32_t)(((a) & 0xff) << 24) |		\
-	(((b) & 0xff) << 16) |						\
-	(((c) & 0xff) << 8) |						\
-	((d) & 0xff))
-
 /*
  * Rule and trace formats definitions.
  **/