[1/9] eal: hide internal hotplug symbol
Checks
Commit Message
This api was experimental and not properly marked in the map file.
But looking more closely, this is just an internal wrapper for EAL init.
Hide it in the hotplug code.
Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/common/hotplug_mp.c | 2 +-
lib/librte_eal/common/hotplug_mp.h | 9 +++++++++
lib/librte_eal/common/include/rte_eal.h | 9 ---------
lib/librte_eal/linux/eal/eal.c | 3 ++-
4 files changed, 12 insertions(+), 11 deletions(-)
Comments
On Thu, 27 Jun 2019 13:33:47 +0200
David Marchand <david.marchand@redhat.com> wrote:
> This api was experimental and not properly marked in the map file.
> But looking more closely, this is just an internal wrapper for EAL init.
> Hide it in the hotplug code.
>
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
@@ -438,7 +438,7 @@ int eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)
return 0;
}
-int rte_mp_dev_hotplug_init(void)
+int eal_mp_dev_hotplug_init(void)
{
int ret;
@@ -29,6 +29,15 @@ struct eal_dev_mp_req {
};
/**
+ * Register all mp action callbacks for hotplug.
+ *
+ * @return
+ * 0 on success, negative on error.
+ */
+int
+eal_mp_dev_hotplug_init(void);
+
+/**
* This is a synchronous wrapper for secondary process send
* request to primary process, this is invoked when an attach
* or detach request is issued from primary process.
@@ -409,15 +409,6 @@ typedef int (*rte_mp_async_reply_t)(const struct rte_mp_msg *request,
rte_mp_reply(struct rte_mp_msg *msg, const char *peer);
/**
- * Register all mp action callbacks for hotplug.
- *
- * @return
- * 0 on success, negative on error.
- */
-int __rte_experimental
-rte_mp_dev_hotplug_init(void);
-
-/**
* Usage function typedef used by the application usage function.
*
* Use this function typedef to define and call rte_set_application_usage_hook()
@@ -59,6 +59,7 @@
#include "eal_hugepages.h"
#include "eal_options.h"
#include "eal_vfio.h"
+#include "hotplug_mp.h"
#define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
@@ -1062,7 +1063,7 @@ static void rte_eal_init_alert(const char *msg)
}
/* register multi-process action callbacks for hotplug */
- if (rte_mp_dev_hotplug_init() < 0) {
+ if (eal_mp_dev_hotplug_init() < 0) {
rte_eal_init_alert("failed to register mp callback for hotplug");
return -1;
}