From patchwork Tue Jul 9 08:44:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 56260 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E5A61B955; Tue, 9 Jul 2019 10:45:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AD5FD1B953 for ; Tue, 9 Jul 2019 10:45:03 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x698fD7b005057; Tue, 9 Jul 2019 01:45:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=1+SvEaMziwPR/TYhmdphpeRvc9PjedkNKDpMxURqJfU=; b=ZmdwNnDJYs6uliP8ROvTMaiMi7Z2vneSNXYboViZ+HVMLWcfJd31jQVCIgKg/VYwYs9v fDP8hjtYN/yh1bua83/PWKQoYFA220QiIkeUBprD5Q8wo7w9zBDITpFImf78tzFM+xOA kmgClj+HyLucpUtUBmPIX8s/yx++K8Bhi5Wn3ziuxySJ5ruRXK9bXzGTAE+pX7XDQFo6 KuCmwHZW5iQbfxlT0BkHIcG7J3SzpHWaKx/F1Efw/jjbkbbV/rlNLP5dJYFNpcKYaCXF pk/txQrCvl82QytEnvdcIzlqJThB6MHggWyesJHf7c7+vrnHq698vtkUNvJJAtayUjyB 9g== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2tmn10gje9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2019 01:45:02 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 9 Jul 2019 01:45:00 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 9 Jul 2019 01:45:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+SvEaMziwPR/TYhmdphpeRvc9PjedkNKDpMxURqJfU=; b=Ga3M9bhTj1Az+c3j2gtnR0lV8LOBiF0bRSrQv3k9P5O9UFObalGNbom2DeGqPQ2s8zY34IOPBFDQ6MdEvcfzU9I2Gs1U3O+JX2S0vC1OQRbtRx7cXms4c1T6h/u7QnLYUZukENfnn9OK0yBGzOm6Ic6PqJmr0ETqT0VaNRaQoqs= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by MN2PR18MB2896.namprd18.prod.outlook.com (20.179.22.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.16; Tue, 9 Jul 2019 08:44:56 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18%7]) with mapi id 15.20.2073.008; Tue, 9 Jul 2019 08:44:56 +0000 From: Harman Kalra To: "olivier.matz@6wind.com" , "reshma.pattan@intel.com" , "thomas@monjalon.net" CC: "arybchenko@solarflare.com" , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Harman Kalra Thread-Topic: [PATCH v3] app/pdump: enforcing pdump to use sw mempool Thread-Index: AQHVNjKVpXkMc0HuDEa48tRscyjn7g== Date: Tue, 9 Jul 2019 08:44:56 +0000 Message-ID: <1562661870-24471-1-git-send-email-hkalra@marvell.com> References: <20190705155007.mvw5fktyyf4xddal@platinum> In-Reply-To: <20190705155007.mvw5fktyyf4xddal@platinum> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::33) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:3e::21) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e367f5c1-e206-4145-0e13-08d70449b79c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR18MB2896; x-ms-traffictypediagnostic: MN2PR18MB2896: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-forefront-prvs: 0093C80C01 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(189003)(199004)(66066001)(8676002)(86362001)(81156014)(2201001)(25786009)(305945005)(8936002)(81166006)(6486002)(71200400001)(107886003)(71190400001)(7736002)(476003)(2501003)(26005)(316002)(53936002)(68736007)(6512007)(50226002)(110136005)(54906003)(186003)(2906002)(76176011)(256004)(66556008)(64756008)(486006)(102836004)(36756003)(52116002)(386003)(55236004)(6506007)(99286004)(4744005)(66946007)(2616005)(6116002)(446003)(14444005)(66446008)(66476007)(3846002)(478600001)(11346002)(73956011)(14454004)(4326008)(5660300002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2896; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: sobm9VIwMvQnF5nXZAfpkqpi/L7b/MPEGN2ua7Pm8jHJSJvoP036Gxj9fdQ15oS4LbVyxZqaglAKT30/HIuFryX0pmQHXB7oWlvf/L7Lr0QTfWJ5oU2oO+t+R1TfD+35pi0yzezBaC+Egs/BEeVQ2J1dtTYB1hVpOFdVOzK83iL7ysbvSb46LzLr21ds7KbO+W+9Dt2NYLdYV4N+oPInCR0GujVXtY46YQA8pm+L76wzxINW2VAijhdesMCQq4btgY0ZNn3D3yFZtuIPqmE92+9eJhJsLpTHE4MJHBH4YCKh8QGAq4jwUg/CX8kNdHfjeUxsPxQdQmYkw86++dE3kVJk0NGhXZ2UJov8ctJ8/FcPFeFHb7BtNOiVZYYpORDyVim+Sx4wHEVNilQPJskWBFz/hfeiCz2tvoFRjXGKyYo= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e367f5c1-e206-4145-0e13-08d70449b79c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2019 08:44:56.0813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hkalra@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2896 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-09_04:, , signatures=0 Subject: [dpdk-dev] [PATCH v3] app/pdump: enforcing pdump to use sw mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A secondary process cannot access HW mempool already initiazed by primary, and neither it can setup its own HW mempool due to its own restrictions. Since dpdk-pdump creates mempool for managing its local mbufs, SW mempool is capable enough to solve this purpose. Signed-off-by: Harman Kalra --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index 80dc924cf..cd0986aee 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -604,11 +604,11 @@ create_mp_ring_vdev(void) mbuf_pool = rte_mempool_lookup(mempool_name); if (mbuf_pool == NULL) { /* create mempool */ - mbuf_pool = rte_pktmbuf_pool_create(mempool_name, + mbuf_pool = rte_pktmbuf_pool_create_by_ops(mempool_name, pt->total_num_mbufs, MBUF_POOL_CACHE_SIZE, 0, pt->mbuf_data_size, - rte_socket_id()); + rte_socket_id(), "ring_mp_mc"); if (mbuf_pool == NULL) { cleanup_rings(); rte_exit(EXIT_FAILURE,