diff mbox series

[v3] doc: update cross build tool version

Message ID 1574922779-14683-1-git-send-email-joyce.kong@arm.com (mailing list archive)
State Accepted, archived
Headers show
Series [v3] doc: update cross build tool version | expand

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Joyce Kong Nov. 28, 2019, 6:32 a.m. UTC
Update the cross build tool version to gcc8.3.

Fixes: 01add9da25cd ("doc: add cross compiling guide")
Cc: stable@dpdk.org

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---

v3:
1. Remove the fix for numactl issue, Ali Alnubani has a similar fix http://patches.dpdk.org/patch/63355/.
2. Some minor changes in description.

 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

Comments

Jerin Jacob Nov. 28, 2019, 11:04 a.m. UTC | #1
On Thu, Nov 28, 2019 at 3:33 PM Joyce Kong <joyce.kong@arm.com> wrote:
>
> Update the cross build tool version to gcc8.3.
>
> Fixes: 01add9da25cd ("doc: add cross compiling guide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>

With the following suggested tile change:
doc: update arm64 cross build tool version

Acked-by: Jerin Jacob <jerinj@marvell.com>



> ---
>
> v3:
> 1. Remove the fix for numactl issue, Ali Alnubani has a similar fix http://patches.dpdk.org/patch/63355/.
> 2. Some minor changes in description.
>
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index e799b0b..d8b9dea 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -16,19 +16,21 @@ Obtain the cross tool chain
>  The latest cross compile tool chain can be downloaded from:
>  https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads.
>
> -Following is the step to get the version 8.2, latest one at the time of this writing.
> +It is always recommended to check and get the latest compiler tool from the page and use
> +it to generate better code. As of this writing 8.3-2019.03 is the newest, the following
> +description is an example of this version.
>
>  .. code-block:: console
>
> -   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.2-2019.01/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
> +   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
>
>  Unzip and add into the PATH
>  ---------------------------
>
>  .. code-block:: console
>
> -   tar -xvf gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
> -   export PATH=$PATH:<cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/bin
> +   tar -xvf gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
> +   export PATH=$PATH:<cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/bin
>
>  .. note::
>
> @@ -71,9 +73,9 @@ Copy the NUMA header files and lib to the cross compiler's directories:
>
>  .. code-block:: console
>
> -   cp <numa_install_dir>/include/numa*.h <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/bin/../aarch64-linux-gnu/libc/usr/include/
> -   cp <numa_install_dir>/lib/libnuma.a <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.2/
> -   cp <numa_install_dir>/lib/libnuma.so <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.2/
> +   cp <numa_install_dir>/include/numa*.h <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/aarch64-linux-gnu/libc/usr/include/
> +   cp <numa_install_dir>/lib/libnuma.a <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.3.0/
> +   cp <numa_install_dir>/lib/libnuma.so <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.3.0/
>
>  .. _configure_and_cross_compile_dpdk_build:
>
> --
> 2.7.4
>
Thomas Monjalon Nov. 28, 2019, 9:32 p.m. UTC | #2
28/11/2019 12:04, Jerin Jacob:
> On Thu, Nov 28, 2019 at 3:33 PM Joyce Kong <joyce.kong@arm.com> wrote:
> >
> > Update the cross build tool version to gcc8.3.
> >
> > Fixes: 01add9da25cd ("doc: add cross compiling guide")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> 
> With the following suggested tile change:
> doc: update arm64 cross build tool version
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks
diff mbox series

Patch

diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index e799b0b..d8b9dea 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -16,19 +16,21 @@  Obtain the cross tool chain
 The latest cross compile tool chain can be downloaded from:
 https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads.
 
-Following is the step to get the version 8.2, latest one at the time of this writing.
+It is always recommended to check and get the latest compiler tool from the page and use
+it to generate better code. As of this writing 8.3-2019.03 is the newest, the following
+description is an example of this version.
 
 .. code-block:: console
 
-   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.2-2019.01/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
+   wget https://developer.arm.com/-/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
 
 Unzip and add into the PATH
 ---------------------------
 
 .. code-block:: console
 
-   tar -xvf gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu.tar.xz
-   export PATH=$PATH:<cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/bin
+   tar -xvf gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
+   export PATH=$PATH:<cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/bin
 
 .. note::
 
@@ -71,9 +73,9 @@  Copy the NUMA header files and lib to the cross compiler's directories:
 
 .. code-block:: console
 
-   cp <numa_install_dir>/include/numa*.h <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/bin/../aarch64-linux-gnu/libc/usr/include/
-   cp <numa_install_dir>/lib/libnuma.a <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.2/
-   cp <numa_install_dir>/lib/libnuma.so <cross_install_dir>/gcc-arm-8.2-2019.01-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.2/
+   cp <numa_install_dir>/include/numa*.h <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/aarch64-linux-gnu/libc/usr/include/
+   cp <numa_install_dir>/lib/libnuma.a <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.3.0/
+   cp <numa_install_dir>/lib/libnuma.so <cross_install_dir>/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/8.3.0/
 
 .. _configure_and_cross_compile_dpdk_build: