diff mbox series

[v3] net/vhost: fix return value of vhost creates not checked

Message ID 1578367548-15596-1-git-send-email-wangyunjian@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series [v3] net/vhost: fix return value of vhost creates not checked |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Yunjian Wang Jan. 7, 2020, 3:25 a.m. UTC 
  The function eth_dev_vhost_create() could return errors,
the return value need to be checked.

Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
v3:
 * Add newline at the end of the error message
v2:
 * Change function eth_dev_vhost_create return 0 on success
---
 drivers/net/vhost/rte_eth_vhost.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Tiwei Bie Jan. 7, 2020, 5:08 a.m. UTC | #1 
On Tue, Jan 07, 2020 at 11:25:48AM +0800, Yunjian Wang wrote:
> The function eth_dev_vhost_create() could return errors,
> the return value need to be checked.
> 
> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v3:
>  * Add newline at the end of the error message
> v2:
>  * Change function eth_dev_vhost_create return 0 on success
> ---
>  drivers/net/vhost/rte_eth_vhost.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Maxime Coquelin Jan. 9, 2020, 3:50 p.m. UTC | #2 
On 1/7/20 6:08 AM, Tiwei Bie wrote:
> On Tue, Jan 07, 2020 at 11:25:48AM +0800, Yunjian Wang wrote:
>> The function eth_dev_vhost_create() could return errors,
>> the return value need to be checked.
>>
>> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
>> v3:
>>  * Add newline at the end of the error message
>> v2:
>>  * Change function eth_dev_vhost_create return 0 on success
>> ---
>>  drivers/net/vhost/rte_eth_vhost.c | 8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
> 


Applied to dpdk-next-virtio/master.

Thanks,
Maxime
diff mbox series

Patch

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 46f01a7..a635889 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1302,7 +1302,7 @@  struct vhost_xstats_name_off {
 	}
 
 	rte_eth_dev_probing_finish(eth_dev);
-	return data->port_id;
+	return 0;
 
 error:
 	if (internal) {
@@ -1455,8 +1455,10 @@  struct vhost_xstats_name_off {
 	if (dev->device.numa_node == SOCKET_ID_ANY)
 		dev->device.numa_node = rte_socket_id();
 
-	eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
-		flags, disable_flags);
+	ret = eth_dev_vhost_create(dev, iface_name, queues,
+				   dev->device.numa_node, flags, disable_flags);
+	if (ret == -1)
+		VHOST_LOG(ERR, "Failed to create %s\n", name);
 
 out_free:
 	rte_kvargs_free(kvlist);