net/mlx5: fix legacy non inline multi packet session

Message ID 1581529748-21677-1-git-send-email-viacheslavo@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: fix legacy non inline multi packet session |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Slava Ovsiienko Feb. 12, 2020, 5:49 p.m. UTC
  The commit being fixed introduced the different format
for the transmitting descriptor multi-packet session for
ConnectX-4LX. The session was assumed always opened if
not-inlinable packet was encountered. The patch checks
whether the inline multi-packet is opened and it allows
to proceed with normal packets (non inlined) successfully.

Fixes: 82a506b404b0 ("net/mlx5: fix the legacy multi packet write session")

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Raslan Darawsheh Feb. 13, 2020, 9:38 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Wednesday, February 12, 2020 7:49 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix legacy non inline multi packet session
> 
> The commit being fixed introduced the different format
> for the transmitting descriptor multi-packet session for
> ConnectX-4LX. The session was assumed always opened if
> not-inlinable packet was encountered. The patch checks
> whether the inline multi-packet is opened and it allows
> to proceed with normal packets (non inlined) successfully.
> 
> Fixes: 82a506b404b0 ("net/mlx5: fix the legacy multi packet write session")
> 
Added Cc: stable@dpdk.org

> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 86e0fab..b55db4f 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -4341,6 +4341,7 @@ enum mlx5_txcmp_code {
>  			 * intermix for legacy MPW sessions.
>  			 */
>  			if (MLX5_TXOFF_CONFIG(MPW) &&
> +			    part != room &&
>  			    loc->wqe_last->dseg[0].bcount == RTE_BE32(0))
>  				break;
>  			/*
> --
> 1.8.3.1


Patch applied next-net-mlx,

Kindest regards,
Raslan Darawsheh
  
Ferruh Yigit Feb. 13, 2020, 11:30 a.m. UTC | #2
On 2/13/2020 9:38 AM, Raslan Darawsheh wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>> Sent: Wednesday, February 12, 2020 7:49 PM
>> To: dev@dpdk.org
>> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
>> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
>> Subject: [PATCH] net/mlx5: fix legacy non inline multi packet session
>>
>> The commit being fixed introduced the different format
>> for the transmitting descriptor multi-packet session for
>> ConnectX-4LX. The session was assumed always opened if
>> not-inlinable packet was encountered. The patch checks
>> whether the inline multi-packet is opened and it allows
>> to proceed with normal packets (non inlined) successfully.
>>
>> Fixes: 82a506b404b0 ("net/mlx5: fix the legacy multi packet write session")
>>
> Added Cc: stable@dpdk.org
> 
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>> ---
>>  drivers/net/mlx5/mlx5_rxtx.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
>> index 86e0fab..b55db4f 100644
>> --- a/drivers/net/mlx5/mlx5_rxtx.c
>> +++ b/drivers/net/mlx5/mlx5_rxtx.c
>> @@ -4341,6 +4341,7 @@ enum mlx5_txcmp_code {
>>  			 * intermix for legacy MPW sessions.
>>  			 */
>>  			if (MLX5_TXOFF_CONFIG(MPW) &&
>> +			    part != room &&
>>  			    loc->wqe_last->dseg[0].bcount == RTE_BE32(0))
>>  				break;
>>  			/*
>> --
>> 1.8.3.1
> 
> 
> Patch applied next-net-mlx,
> 

Squashed into relevant commit in next-net, thanks.
  

Patch

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 86e0fab..b55db4f 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -4341,6 +4341,7 @@  enum mlx5_txcmp_code {
 			 * intermix for legacy MPW sessions.
 			 */
 			if (MLX5_TXOFF_CONFIG(MPW) &&
+			    part != room &&
 			    loc->wqe_last->dseg[0].bcount == RTE_BE32(0))
 				break;
 			/*