diff mbox series

net/mlx5: fix inline packet size for ConnectX-4LX

Message ID 1582233513-3372-1-git-send-email-viacheslavo@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/mlx5: fix inline packet size for ConnectX-4LX |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation fail apply issues
ci/travis-robot success Travis build: passed

Commit Message

Slava Ovsiienko Feb. 20, 2020, 9:18 p.m. UTC 
  This patch does extra inline packet size check to tune
the ConnectX-4LX performance in the legacy Multi-Packet Write
mode.

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Matan Azrad Feb. 21, 2020, 7:37 a.m. UTC | #1 
From: Viacheslav Ovsiienko
> This patch does extra inline packet size check to tune the ConnectX-4LX
> performance in the legacy Multi-Packet Write mode.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Slava, Don't you think we want it for stable releases?

Besides it:
Acked-by: Matan Azrad <matan@mellanox.com>

>  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index b55db4f..0df811b 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
>  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
>  				goto pointer_empw;
>  			if (MLX5_TXOFF_CONFIG(MPW)) {
> +				if (dlen > txq->inlen_send)
> +					goto pointer_empw;
>  				tlen = dlen;
>  				if (part == room) {
>  					/* Open new inline MPW session. */
> --
> 1.8.3.1
Slava Ovsiienko Feb. 21, 2020, 7:39 a.m. UTC | #2 
> -----Original Message-----
> From: Matan Azrad <matan@mellanox.com>
> Sent: Friday, February 21, 2020 9:38
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>; ferruh.yigit@intel.com
> Subject: RE: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
> 
> 
> 
> From: Viacheslav Ovsiienko
> > This patch does extra inline packet size check to tune the
> > ConnectX-4LX performance in the legacy Multi-Packet Write mode.
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> Slava, Don't you think we want it for stable releases?
Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML.

> 
> Besides it:
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> >  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rxtx.c
> > b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644
> > --- a/drivers/net/mlx5/mlx5_rxtx.c
> > +++ b/drivers/net/mlx5/mlx5_rxtx.c
> > @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
> >  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
> >  				goto pointer_empw;
> >  			if (MLX5_TXOFF_CONFIG(MPW)) {
> > +				if (dlen > txq->inlen_send)
> > +					goto pointer_empw;
> >  				tlen = dlen;
> >  				if (part == room) {
> >  					/* Open new inline MPW session. */
> > --
> > 1.8.3.1
Ferruh Yigit Feb. 21, 2020, 9:44 a.m. UTC | #3 
On 2/21/2020 7:39 AM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Matan Azrad <matan@mellanox.com>
>> Sent: Friday, February 21, 2020 9:38
>> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
>> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
>> <thomas@monjalon.net>; ferruh.yigit@intel.com
>> Subject: RE: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
>>
>>
>>
>> From: Viacheslav Ovsiienko
>>> This patch does extra inline packet size check to tune the
>>> ConnectX-4LX performance in the legacy Multi-Packet Write mode.
>>>
>>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>>
>> Slava, Don't you think we want it for stable releases?
> Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML.

Is the fixed commit known? (fixes line)

> 
>>
>> Besides it:
>> Acked-by: Matan Azrad <matan@mellanox.com>
>>
>>>  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/net/mlx5/mlx5_rxtx.c
>>> b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644
>>> --- a/drivers/net/mlx5/mlx5_rxtx.c
>>> +++ b/drivers/net/mlx5/mlx5_rxtx.c
>>> @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
>>>  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
>>>  				goto pointer_empw;
>>>  			if (MLX5_TXOFF_CONFIG(MPW)) {
>>> +				if (dlen > txq->inlen_send)
>>> +					goto pointer_empw;
>>>  				tlen = dlen;
>>>  				if (part == room) {
>>>  					/* Open new inline MPW session. */
>>> --
>>> 1.8.3.1
>
Slava Ovsiienko Feb. 21, 2020, 9:51 a.m. UTC | #4 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, February 21, 2020 11:44
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
> 
> On 2/21/2020 7:39 AM, Slava Ovsiienko wrote:
> >> -----Original Message-----
> >> From: Matan Azrad <matan@mellanox.com>
> >> Sent: Friday, February 21, 2020 9:38
> >> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> >> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> >> <thomas@monjalon.net>; ferruh.yigit@intel.com
> >> Subject: RE: [PATCH] net/mlx5: fix inline packet size for
> >> ConnectX-4LX
> >>
> >>
> >>
> >> From: Viacheslav Ovsiienko
> >>> This patch does extra inline packet size check to tune the
> >>> ConnectX-4LX performance in the legacy Multi-Packet Write mode.
> >>>
> >>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> >>
> >> Slava, Don't you think we want it for stable releases?
> > Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML.
> 
> Is the fixed commit known? (fixes line)

Yes, sorry for missed "Fixes" tag
It should be:
Fixes: 7593cf1d3500 ("net/mlx5: fix legacy multi-packet write session")

With best regards, Slava
> 
> >
> >>
> >> Besides it:
> >> Acked-by: Matan Azrad <matan@mellanox.com>
> >>
> >>>  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/drivers/net/mlx5/mlx5_rxtx.c
> >>> b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644
> >>> --- a/drivers/net/mlx5/mlx5_rxtx.c
> >>> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> >>> @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
> >>>  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
> >>>  				goto pointer_empw;
> >>>  			if (MLX5_TXOFF_CONFIG(MPW)) {
> >>> +				if (dlen > txq->inlen_send)
> >>> +					goto pointer_empw;
> >>>  				tlen = dlen;
> >>>  				if (part == room) {
> >>>  					/* Open new inline MPW session. */
> >>> --
> >>> 1.8.3.1
> >
Ferruh Yigit Feb. 21, 2020, 10:07 a.m. UTC | #5 
On 2/21/2020 7:37 AM, Matan Azrad wrote:
> 
> 
> From: Viacheslav Ovsiienko
>> This patch does extra inline packet size check to tune the ConnectX-4LX
>> performance in the legacy Multi-Packet Write mode.
>>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> Slava, Don't you think we want it for stable releases?
> 
> Besides it:
> Acked-by: Matan Azrad <matan@mellanox.com>

    Fixes: 7593cf1d3500 ("net/mlx5: fix legacy multi-packet write session")
    Cc: stable@dpdk.org

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index b55db4f..0df811b 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -4281,6 +4281,8 @@  enum mlx5_txcmp_code {
 			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
 				goto pointer_empw;
 			if (MLX5_TXOFF_CONFIG(MPW)) {
+				if (dlen > txq->inlen_send)
+					goto pointer_empw;
 				tlen = dlen;
 				if (part == room) {
 					/* Open new inline MPW session. */