diff mbox series

[v1,01/15] net/mlx5: fix send queue doorbell typo

Message ID	1601561366-1821-2-git-send-email-michaelba@nvidia.com (mailing list archive)
State	Accepted, archived
Delegated to:	Raslan Darawsheh
Headers	From: Michael Baum <michaelba@nvidia.com> To: dev@dpdk.org Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, stable@dpdk.org Date: Thu, 1 Oct 2020 14:09:12 +0000 Message-Id: <1601561366-1821-2-git-send-email-michaelba@nvidia.com> In-Reply-To: <1601561366-1821-1-git-send-email-michaelba@nvidia.com> References: <1601561366-1821-1-git-send-email-michaelba@nvidia.com> Subject: [dpdk-dev] [PATCH v1 01/15] net/mlx5: fix send queue doorbell typo Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	mlx5 Tx DevX/Verbs separation \| [v1,00/15] mlx5 Tx DevX/Verbs separation [v1,01/15] net/mlx5: fix send queue doorbell typo [v1,02/15] net/mlx5: fix unused variable in Txq creation [v1,03/15] net/mlx5: mitigate Tx queue reference counters [v1,04/15] net/mlx5: reorder Tx queue DevX object creation [v1,05/15] net/mlx5: reorder Tx queue Verbs object creation [v1,06/15] net/mlx5: reposition the event queue number field [v1,07/15] net/mlx5: separate Tx queue object creations [v1,08/15] net/mlx5: share Tx control code [v1,09/15] net/mlx5: rearrange SQ and CQ creation in DevX module [v1,10/15] net/mlx5: rearrange QP creation in Verbs module [v1,11/15] net/mlx5: separate Tx queue object modification [v1,12/15] net/mlx5: share Tx queue object modification [v1,13/15] net/mlx5: remove Tx queue object type field [v1,14/15] net/mlx5: separate Rx queue state modification [v1,15/15] net/mlx5: remove Rx queue object type field

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Michael Baum Oct. 1, 2020, 2:09 p.m. UTC

  As part of SQ creation for Tx queue objects, a HW doorbell memory should
be allocated and mapped to the HW.

The SQ doorbell handler was wrongly saved on the CQ fields what caused
wrong doorbell release in the Tx queue object destroy flow.

Save the SQ doorbell handler in the SQ fields.

Fixes: 3a87b964edd3 ("net/mlx5: create Tx queues with DevX")
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/mlx5_txq.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index 1bb667d..fc730fa 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -1050,8 +1050,8 @@ 
 			dev->data->port_id, txq_data->idx);
 		goto error;
 	}
-	/* Allocate doorbell record for completion queue. */
-	txq_obj->cq_dbrec_offset = mlx5_get_dbr(sh->ctx,
+	/* Allocate doorbell record for send queue. */
+	txq_obj->sq_dbrec_offset = mlx5_get_dbr(sh->ctx,
 						&priv->dbrpgs,
 						&txq_obj->sq_dbrec_page);
 	if (txq_obj->sq_dbrec_offset < 0)
@@ -1076,9 +1076,9 @@ 
 	sq_attr.wq_attr.log_wq_stride = rte_log2_u32(MLX5_WQE_SIZE);
 	sq_attr.wq_attr.log_wq_sz = txq_data->wqe_n;
 	sq_attr.wq_attr.dbr_umem_valid = 1;
-	sq_attr.wq_attr.dbr_addr = txq_obj->cq_dbrec_offset;
+	sq_attr.wq_attr.dbr_addr = txq_obj->sq_dbrec_offset;
 	sq_attr.wq_attr.dbr_umem_id =
-			mlx5_os_get_umem_id(txq_obj->cq_dbrec_page->umem);
+			mlx5_os_get_umem_id(txq_obj->sq_dbrec_page->umem);
 	sq_attr.wq_attr.wq_umem_valid = 1;
 	sq_attr.wq_attr.wq_umem_id = mlx5_os_get_umem_id(txq_obj->sq_umem);
 	sq_attr.wq_attr.wq_umem_offset = (uintptr_t)txq_obj->sq_buf % page_size;