[07/10] examples/l3fwd: add function return value check
Checks
Commit Message
From: HongBo Zheng <zhenghongbo3@huawei.com>
Return value of a function 'rte_eth_macaddr_get' called at
l3fwd_eth_dev_port_setup is not checked, but it is usually
checked for this function.
This patch fix this problem.
Fixes: a65bf3d724df ("examples/l3fwd: add ethdev setup based on eventdev")
Cc: stable@dpdk.org
Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
examples/l3fwd/l3fwd_event.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On Mon, 19 Apr 2021 21:34:46 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:
> From: HongBo Zheng <zhenghongbo3@huawei.com>
>
> Return value of a function 'rte_eth_macaddr_get' called at
> l3fwd_eth_dev_port_setup is not checked, but it is usually
> checked for this function.
>
> This patch fix this problem.
>
> Fixes: a65bf3d724df ("examples/l3fwd: add ethdev setup based on eventdev")
> Cc: stable@dpdk.org
>
> Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
This looks correct, but only a buggy driver would never set macaddr.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
@@ -105,7 +105,11 @@ l3fwd_eth_dev_port_setup(struct rte_eth_conf *port_conf)
"Cannot adjust number of descriptors: err=%d, "
"port=%d\n", ret, port_id);
- rte_eth_macaddr_get(port_id, &ports_eth_addr[port_id]);
+ ret = rte_eth_macaddr_get(port_id, &ports_eth_addr[port_id]);
+ if (ret < 0)
+ rte_exit(EXIT_FAILURE,
+ "Cannot get MAC address: err=%d, port=%d\n",
+ ret, port_id);
print_ethaddr(" Address:", &ports_eth_addr[port_id]);
printf(", ");
print_ethaddr("Destination:",