diff mbox series

[v3] ci: update machine meson option to platform

Message ID 1633959641-28506-1-git-send-email-juraj.linkes@pantheon.tech (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v3] ci: update machine meson option to platform |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-spell-check-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Juraj Linkeš Oct. 11, 2021, 1:40 p.m. UTC 
  The way we're building DPDK in CI, with -Dmachine=default, has not been
updated when the option got replaced to preserve a backwards-complatible
build call to facilitate ABI verification between DPDK versions. Update
the call to use -Dplatform=generic, which is the most up to date way to
execute the same build which is now present in all DPDK versions the ABI
check verifies.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
v3: ci retest
---
 .ci/linux-build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aaron Conole Oct. 14, 2021, 12:26 p.m. UTC | #1 
Juraj Linkeš <juraj.linkes@pantheon.tech> writes:

> The way we're building DPDK in CI, with -Dmachine=default, has not been
> updated when the option got replaced to preserve a backwards-complatible
> build call to facilitate ABI verification between DPDK versions. Update
> the call to use -Dplatform=generic, which is the most up to date way to
> execute the same build which is now present in all DPDK versions the ABI
> check verifies.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

Looks like something didn't go well in the UNH environment w.r.t. the
windows compilation for this patch.  CC'd the CI list to take a look.
Thomas Monjalon Oct. 25, 2021, 3:42 p.m. UTC | #2 
14/10/2021 14:26, Aaron Conole:
> Juraj Linkeš <juraj.linkes@pantheon.tech> writes:
> 
> > The way we're building DPDK in CI, with -Dmachine=default, has not been
> > updated when the option got replaced to preserve a backwards-complatible
> > build call to facilitate ABI verification between DPDK versions. Update
> > the call to use -Dplatform=generic, which is the most up to date way to
> > execute the same build which is now present in all DPDK versions the ABI
> > check verifies.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> 
> Acked-by: Aaron Conole <aconole@redhat.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 91e43a975b..06aaa79100 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -77,7 +77,7 @@  else
     OPTS="$OPTS -Dexamples=all"
 fi
 
-OPTS="$OPTS -Dmachine=default"
+OPTS="$OPTS -Dplatform=generic"
 OPTS="$OPTS --default-library=$DEF_LIB"
 OPTS="$OPTS --buildtype=debugoptimized"
 OPTS="$OPTS -Dcheck_includes=true"