diff mbox series

examples/flow_classify: fix spelling when log error

Message ID 1642474174-3963-1-git-send-email-zhangchuanshe@icloudshield.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series examples/flow_classify: fix spelling when log error |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional fail Functional Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Chuanshe Zhang Jan. 18, 2022, 2:49 a.m. UTC 
  Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
---
 examples/flow_classify/flow_classify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Iremonger, Bernard Feb. 23, 2022, 4:05 p.m. UTC | #1 
Hi Chuanshe,

> -----Original Message-----
> From: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> Sent: Tuesday, January 18, 2022 2:50 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH] examples/flow_classify: fix spelling when log error
> 
> Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> ---
>  examples/flow_classify/flow_classify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/flow_classify/flow_classify.c
> b/examples/flow_classify/flow_classify.c
> index 6185b34..97708b7 100644
> --- a/examples/flow_classify/flow_classify.c
> +++ b/examples/flow_classify/flow_classify.c
> @@ -430,7 +430,7 @@ struct rte_flow_query_count count = {
>  			&ntuple_filter->dst_ip,
>  			&ntuple_filter->dst_ip_mask);
>  	if (ret != 0) {
> -		flow_classify_log("failed to read source address/mask:
> %s\n",
> +		flow_classify_log("failed to read destination address/mask:
> %s\n",
>  			in[CB_FLD_DST_ADDR]);
>  		return ret;
>  	}
> --
> 1.8.3.1

 
/dpdk_22_03/devtools# ./checkpatches.sh examples-flow_classify-fix-spelling-when-log-error.patch

### [PATCH] examples/flow_classify: fix spelling when log error
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

/dpdk_22_03/devtools# ./check-git-log.sh -1
Missing 'Fixes' tag:
        examples/flow_classify: fix spelling when log error


Otherwise, the fix looks good.

Regards,

Bernard.
Thomas Monjalon March 8, 2022, 11:43 a.m. UTC | #2 
23/02/2022 17:05, Iremonger, Bernard:
> Hi Chuanshe,
> 
> From: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> > 
> > Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> > ---
> > -		flow_classify_log("failed to read source address/mask:
> > %s\n",
> > +		flow_classify_log("failed to read destination address/mask:
> > %s\n",
> 
> ### [PATCH] examples/flow_classify: fix spelling when log error
> WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
> 
> /dpdk_22_03/devtools# ./check-git-log.sh -1
> Missing 'Fixes' tag:
>         examples/flow_classify: fix spelling when log error
> 
> Otherwise, the fix looks good.

Applied, thanks.
Iremonger, Bernard March 8, 2022, noon UTC | #3 
Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, March 8, 2022 11:44 AM
> To: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> Cc: dev@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: Re: [PATCH] examples/flow_classify: fix spelling when log error
> 
> 23/02/2022 17:05, Iremonger, Bernard:
> > Hi Chuanshe,
> >
> > From: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> > >
> > > Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> > > ---
> > > -		flow_classify_log("failed to read source address/mask:
> > > %s\n",
> > > +		flow_classify_log("failed to read destination address/mask:
> > > %s\n",
> >
> > ### [PATCH] examples/flow_classify: fix spelling when log error
> > WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> > appropriate one
> >
> > /dpdk_22_03/devtools# ./check-git-log.sh -1 Missing 'Fixes' tag:
> >         examples/flow_classify: fix spelling when log error
> >
> > Otherwise, the fix looks good.
> 
> Applied, thanks.
> 
You can add my ack to this patch
diff mbox series

Patch

diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c
index 6185b34..97708b7 100644
--- a/examples/flow_classify/flow_classify.c
+++ b/examples/flow_classify/flow_classify.c
@@ -430,7 +430,7 @@  struct rte_flow_query_count count = {
 			&ntuple_filter->dst_ip,
 			&ntuple_filter->dst_ip_mask);
 	if (ret != 0) {
-		flow_classify_log("failed to read source address/mask: %s\n",
+		flow_classify_log("failed to read destination address/mask: %s\n",
 			in[CB_FLD_DST_ADDR]);
 		return ret;
 	}