[v2] net/bonding: fix RSS not work for bonding
Checks
Commit Message
RSS don't work when bond_ethdev_configure called before
rte_eth_bond_slave_add.
e.g.:
dont't work(examples/bond/main.c):
rte_eth_bond_create()
rte_eth_dev_configure()
rte_eth_bond_slave_add()
rte_eth_dev_start()
work(testpmd):
rte_eth_bond_create()
rte_eth_bond_slave_add()
rte_eth_dev_configure()
rte_eth_dev_start()
Fixes: 6b1a001ec546 ("net/bonding: fix RSS key length")
Cc: stable@dpdk.org
Signed-off-by: Yu Wenjun <yuwenjun@cmss.chinamobile.com>
---
v2:
- Fixed patch format.
drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
1 file changed, 5 insertions(+)
Comments
On 1/18/2022 9:27 AM, Min Hu (Connor) wrote:
> 在 2022/1/18 17:18, Yu Wenjun 写道:
>> RSS don't work when bond_ethdev_configure called before
>> rte_eth_bond_slave_add.
>>
>> e.g.:
>> dont't work(examples/bond/main.c):
>> rte_eth_bond_create()
>> rte_eth_dev_configure()
>> rte_eth_bond_slave_add()
>> rte_eth_dev_start()
>>
>> work(testpmd):
>> rte_eth_bond_create()
>> rte_eth_bond_slave_add()
>> rte_eth_dev_configure()
>> rte_eth_dev_start()
>>
>> Fixes: 6b1a001ec546 ("net/bonding: fix RSS key length")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yu Wenjun <yuwenjun@cmss.chinamobile.com>
>
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
>
Updated commit log to include rss key length being 0 detail,
based on discussions in the mail list.
Applied to dpdk-next-net/main, thanks.
@@ -3504,6 +3504,11 @@ struct bwg_slave {
if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
struct rte_eth_rss_conf *rss_conf =
&dev->data->dev_conf.rx_adv_conf.rss_conf;
+
+ if (internals->rss_key_len == 0) {
+ internals->rss_key_len = sizeof(default_rss_key);
+ }
+
if (rss_conf->rss_key != NULL) {
if (internals->rss_key_len > rss_conf->rss_key_len) {
RTE_BOND_LOG(ERR, "Invalid rss key length(%u)",