[v2] config/arm: add armv7 native config

Message ID 1643105308-26026-1-git-send-email-juraj.linkes@pantheon.tech (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] config/arm: add armv7 native config |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing warning Testing issues
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Juraj Linkeš Jan. 25, 2022, 10:08 a.m. UTC
  Armv7 native build fails with this error:
../config/meson.build:364:1: ERROR: Problem encountered:
Number of CPU cores not specified.

This is because RTE_MAX_LCORE is not set. We also need to set
RTE_MAX_NUMA_NODES in armv7 native builds.

Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 config/arm/meson.build | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Thomas Monjalon Feb. 10, 2022, 4:34 p.m. UTC | #1
25/01/2022 11:08, Juraj Linkeš:
> Armv7 native build fails with this error:
> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
> 
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
> 
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied with backport tag, thanks.
  

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index c3a3f2faaf..a0e91c0f6b 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -434,6 +434,8 @@  if dpdk_conf.get('RTE_ARCH_32')
         # armv7 build
         dpdk_conf.set('RTE_ARCH_ARMv7', true)
         dpdk_conf.set('RTE_ARCH', 'armv7')
+        dpdk_conf.set('RTE_MAX_LCORE', 128)
+        dpdk_conf.set('RTE_MAX_NUMA_NODES', 1)
         # the minimum architecture supported, armv7-a, needs the following,
         machine_args += '-mfpu=neon'
     endif