| Message ID | 1651048206-282372-12-git-send-email-andy.pei@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Maxime Coquelin |
| Headers | show |
| Series | add virtio_blk device support to vdpa/ifc | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Pei, Andy <andy.pei@intel.com> > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Cao, > Gang <gang.cao@intel.com>; Liu, Changpeng <changpeng.liu@intel.com> > Subject: [PATCH v7 11/18] vdpa/ifc: add set vring state for blk device > > Set_vring_state op is mandatory, add set_vring_state for blk device. > Currently set_vring_state for blk device is not implemented. > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 99a6ab0..ca49bc3 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1290,6 +1290,16 @@ struct rte_vdpa_dev_info { > } > > static int > +ifcvf_blk_set_vring_state(int vid, int vring, int state) > +{ > + RTE_SET_USED(vid); > + RTE_SET_USED(vring); > + RTE_SET_USED(state); > + > + return 0; > +} > + > +static int > ifcvf_blk_get_protocol_features(struct rte_vdpa_device *vdev, > uint64_t *features) > { > @@ -1316,7 +1326,7 @@ struct rte_vdpa_dev_info { > .get_protocol_features = ifcvf_blk_get_protocol_features, > .dev_conf = ifcvf_dev_config, > .dev_close = ifcvf_dev_close, > - .set_vring_state = NULL, > + .set_vring_state = ifcvf_blk_set_vring_state, About naming in this driver, if you use two functions for net/blk and name the one for blk as XXX_blk_XXX. Better rename the net one as XXX_net_XXX. In this case, better to rename ifcvf_set_vring_state Thanks, Chenbo > .migration_done = NULL, > .get_vfio_group_fd = ifcvf_get_vfio_group_fd, > .get_vfio_device_fd = ifcvf_get_vfio_device_fd, > -- > 1.8.3.1
diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 99a6ab0..ca49bc3 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c @@ -1290,6 +1290,16 @@ struct rte_vdpa_dev_info { } static int +ifcvf_blk_set_vring_state(int vid, int vring, int state) +{ + RTE_SET_USED(vid); + RTE_SET_USED(vring); + RTE_SET_USED(state); + + return 0; +} + +static int ifcvf_blk_get_protocol_features(struct rte_vdpa_device *vdev, uint64_t *features) { @@ -1316,7 +1326,7 @@ struct rte_vdpa_dev_info { .get_protocol_features = ifcvf_blk_get_protocol_features, .dev_conf = ifcvf_dev_config, .dev_close = ifcvf_dev_close, - .set_vring_state = NULL, + .set_vring_state = ifcvf_blk_set_vring_state, .migration_done = NULL, .get_vfio_group_fd = ifcvf_get_vfio_group_fd, .get_vfio_device_fd = ifcvf_get_vfio_device_fd,
Set_vring_state op is mandatory, add set_vring_state for blk device. Currently set_vring_state for blk device is not implemented. Signed-off-by: Andy Pei <andy.pei@intel.com> --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)