diff mbox series

[v2] net/mlx5: fix verbs fd leak in the secondary process

Message ID 1657129733-12126-2-git-send-email-longli@linuxonhyperv.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v2] net/mlx5: fix verbs fd leak in the secondary process |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Long Li July 6, 2022, 5:48 p.m. UTC 
  From: Long Li <longli@microsoft.com>

FDs passed from rte_mp_msg are duplicated to the secondary process and
need to be closed.

Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API")
Signed-off-by: Long Li <longli@microsoft.com>
---
Change in v2: handle error case where mlx5_proc_priv_init() might fail

 drivers/net/mlx5/linux/mlx5_mp_os.c | 6 +++++-
 drivers/net/mlx5/linux/mlx5_os.c    | 8 +++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

Comments

Slava Ovsiienko July 7, 2022, 9:43 a.m. UTC | #1 
> -----Original Message-----
> From: longli@linuxonhyperv.com <longli@linuxonhyperv.com>
> Sent: Wednesday, July 6, 2022 20:49
> To: Matan Azrad <matan@nvidia.com>; Ferruh Yigit <ferruh.yigit@xilinx.com>
> Cc: dev@dpdk.org; Karanjot Singh <ksingh1@paloaltonetworks.com>; NBU-
> Contact-longli (EXTERNAL) <longli@microsoft.com>
> Subject: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process
> 
> From: Long Li <longli@microsoft.com>
> 
> FDs passed from rte_mp_msg are duplicated to the secondary process and need
> to be closed.
> 
> Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API")
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> Change in v2: handle error case where mlx5_proc_priv_init() might fail
> 
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

PS. Nice catch, thank you. Nice catch, thank you, Long
Raslan Darawsheh Aug. 14, 2022, 1:50 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: longli@linuxonhyperv.com <longli@linuxonhyperv.com>
> Sent: Wednesday, July 6, 2022 8:49 PM
> To: Matan Azrad <matan@nvidia.com>; Ferruh Yigit
> <ferruh.yigit@xilinx.com>
> Cc: dev@dpdk.org; Karanjot Singh <ksingh1@paloaltonetworks.com>; NBU-
> Contact-longli (EXTERNAL) <longli@microsoft.com>
> Subject: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process
> 
> From: Long Li <longli@microsoft.com>
> 
> FDs passed from rte_mp_msg are duplicated to the secondary process and
> need to be closed.
> 
> Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API")
> Signed-off-by: Long Li <longli@microsoft.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/linux/mlx5_mp_os.c b/drivers/net/mlx5/linux/mlx5_mp_os.c
index c448a3e9eb..0ba2208fe0 100644
--- a/drivers/net/mlx5/linux/mlx5_mp_os.c
+++ b/drivers/net/mlx5/linux/mlx5_mp_os.c
@@ -177,14 +177,18 @@  struct rte_mp_msg mp_res;
 			mlx5_tx_uar_uninit_secondary(dev);
 			mlx5_proc_priv_uninit(dev);
 			ret = mlx5_proc_priv_init(dev);
-			if (ret)
+			if (ret) {
+				close(mp_msg->fds[0]);
 				return -rte_errno;
+			}
 			ret = mlx5_tx_uar_init_secondary(dev, mp_msg->fds[0]);
 			if (ret) {
+				close(mp_msg->fds[0]);
 				mlx5_proc_priv_uninit(dev);
 				return -rte_errno;
 			}
 		}
+		close(mp_msg->fds[0]);
 		rte_mb();
 		mp_init_msg(&priv->mp_id, &mp_res, param->type);
 		res->result = 0;
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index c29fe3d92b..69ae3c944b 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -933,6 +933,7 @@  mlx5_dev_spawn(struct rte_device *dpdk_dev,
 	DRV_LOG(DEBUG, "naming Ethernet device \"%s\"", name);
 	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
 		struct mlx5_mp_id mp_id;
+		int fd;
 
 		eth_dev = rte_eth_dev_attach_secondary(name);
 		if (eth_dev == NULL) {
@@ -949,11 +950,12 @@  mlx5_dev_spawn(struct rte_device *dpdk_dev,
 			return NULL;
 		mlx5_mp_id_init(&mp_id, eth_dev->data->port_id);
 		/* Receive command fd from primary process */
-		err = mlx5_mp_req_verbs_cmd_fd(&mp_id);
-		if (err < 0)
+		fd = mlx5_mp_req_verbs_cmd_fd(&mp_id);
+		if (fd < 0)
 			goto err_secondary;
 		/* Remap UAR for Tx queues. */
-		err = mlx5_tx_uar_init_secondary(eth_dev, err);
+		err = mlx5_tx_uar_init_secondary(eth_dev, fd);
+		close(fd);
 		if (err)
 			goto err_secondary;
 		/*