diff mbox series

mbuf: remove use of now unnecessary extension keyword

Message ID 1699395284-8751-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series mbuf: remove use of now unnecessary extension keyword |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation fail Compilation issues
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Tyler Retzlaff Nov. 7, 2023, 10:14 p.m. UTC 
  Remove the use of __extension__ on nameless struct and union members
they are no longer necessary as they are standard in C11

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/mbuf/rte_mbuf_core.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Tyler Retzlaff Nov. 7, 2023, 11:07 p.m. UTC | #1 
this series will be withdrawn since the keyword was also applied to the
bitfields.

sorry for the noise

On Tue, Nov 07, 2023 at 02:14:44PM -0800, Tyler Retzlaff wrote:
> Remove the use of __extension__ on nameless struct and union members
> they are no longer necessary as they are standard in C11
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
>  lib/mbuf/rte_mbuf_core.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
> index 5688683..d335ed8 100644
> --- a/lib/mbuf/rte_mbuf_core.h
> +++ b/lib/mbuf/rte_mbuf_core.h
> @@ -525,7 +525,6 @@ struct rte_mbuf {
>  	 */
>  	union {
>  		uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
> -		__extension__
>  		struct {
>  			uint8_t l2_type:4;   /**< (Outer) L2 type. */
>  			uint8_t l3_type:4;   /**< (Outer) L3 type. */
> @@ -537,7 +536,6 @@ struct rte_mbuf {
>  				 * RTE_PTYPE_TUNNEL_ESP tunnel type is set
>  				 * on both Tx and Rx.
>  				 */
> -				__extension__
>  				struct {
>  					uint8_t inner_l2_type:4;
>  					/**< Inner L2 type. */
> @@ -614,7 +612,6 @@ struct rte_mbuf {
>  	/* fields to support TX offloads */
>  	union {
>  		uint64_t tx_offload;       /**< combined for easy fetch */
> -		__extension__
>  		struct {
>  			uint64_t l2_len:RTE_MBUF_L2_LEN_BITS;
>  			/**< L2 (MAC) Header Length for non-tunneling pkt.
> -- 
> 1.8.3.1
diff mbox series

Patch

diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index 5688683..d335ed8 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -525,7 +525,6 @@  struct rte_mbuf {
 	 */
 	union {
 		uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
-		__extension__
 		struct {
 			uint8_t l2_type:4;   /**< (Outer) L2 type. */
 			uint8_t l3_type:4;   /**< (Outer) L3 type. */
@@ -537,7 +536,6 @@  struct rte_mbuf {
 				 * RTE_PTYPE_TUNNEL_ESP tunnel type is set
 				 * on both Tx and Rx.
 				 */
-				__extension__
 				struct {
 					uint8_t inner_l2_type:4;
 					/**< Inner L2 type. */
@@ -614,7 +612,6 @@  struct rte_mbuf {
 	/* fields to support TX offloads */
 	union {
 		uint64_t tx_offload;       /**< combined for easy fetch */
-		__extension__
 		struct {
 			uint64_t l2_len:RTE_MBUF_L2_LEN_BITS;
 			/**< L2 (MAC) Header Length for non-tunneling pkt.