windows: install sched.h header
Checks
Commit Message
rte_os.h includes sched.h so install sched.h to allow DPDK installed to
DESTDIR to be usable.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/eal/windows/include/meson.build | 1 +
1 file changed, 1 insertion(+)
Comments
On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> DESTDIR to be usable.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
20/12/2023 10:11, Bruce Richardson:
> On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > DESTDIR to be usable.
Why other files don't need to be exported as well?
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
That's a fix which may need to be backported.
On Tue, Jan 30, 2024 at 05:52:54PM +0100, Thomas Monjalon wrote:
> 20/12/2023 10:11, Bruce Richardson:
> > On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > > DESTDIR to be usable.
>
> Why other files don't need to be exported as well?
after reviewing all other files it was found that only sched.h is being
included by an installed / public header. all other headers in
windows/include are used internally only.
>
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> That's a fix which may need to be backported.
found the commit that added sched.h and added a Fixes tag.
thanks!
@@ -6,4 +6,5 @@ includes += include_directories('.')
headers += files(
'rte_os.h',
'rte_windows.h',
+ 'sched.h',
)