From patchwork Mon Feb 12 21:49:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136614 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E261543AFE; Mon, 12 Feb 2024 22:50:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5BE7410E8; Mon, 12 Feb 2024 22:49:36 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 10D4540E13 for ; Mon, 12 Feb 2024 22:49:24 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id D62AD20B200C; Mon, 12 Feb 2024 13:49:22 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D62AD20B200C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707774562; bh=S8/6swJoNWfJgJC3M6AMUmF523e0cX7Sz2jJprtOMIg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r3yUzavS5BXPQr+1ZMU4Erv7QUmshLZvhcKc7KCWuAseG34j3oexAVJB7JQTiU7Ib OesuFECcpfV+g05SmRmUqhuTDnVh3n7hlPvz8HBVN63rh3XjmYCgwGwFCrx8zohDnD bDsWCmofDZN7CobDzzDEYaAHr7/LZYad8dEcTDBY= From: Tyler Retzlaff To: dev@dpdk.org Cc: Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , Tyler Retzlaff Subject: [PATCH 12/15] rawdev: use GCC and MSVC common VA ARGS extension Date: Mon, 12 Feb 2024 13:49:14 -0800 Message-Id: <1707774557-16012-13-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use ... and forward with __VA_ARGS__ instead of args... and args. Neither mechanism is conformant with the standard but the former works with both GCC and MSVC. Signed-off-by: Tyler Retzlaff Acked-by: Hemant Agrawal --- lib/rawdev/rte_rawdev_pmd.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h index 7173282..d66f438 100644 --- a/lib/rawdev/rte_rawdev_pmd.h +++ b/lib/rawdev/rte_rawdev_pmd.h @@ -30,15 +30,15 @@ #define RTE_LOGTYPE_RAWDEV librawdev_logtype /* Logging Macros */ -#define RTE_RDEV_LOG(level, fmt, args...) \ - RTE_LOG_LINE(level, RAWDEV, "%s(): " fmt, __func__, ##args) - -#define RTE_RDEV_ERR(fmt, args...) \ - RTE_RDEV_LOG(ERR, fmt, ## args) -#define RTE_RDEV_DEBUG(fmt, args...) \ - RTE_RDEV_LOG(DEBUG, fmt, ## args) -#define RTE_RDEV_INFO(fmt, args...) \ - RTE_RDEV_LOG(INFO, fmt, ## args) +#define RTE_RDEV_LOG(level, fmt, ...) \ + RTE_LOG_LINE(level, RAWDEV, "%s(): " fmt, __func__, ## __VA_ARGS__) + +#define RTE_RDEV_ERR(fmt, ...) \ + RTE_RDEV_LOG(ERR, fmt, ## __VA_ARGS__) +#define RTE_RDEV_DEBUG(fmt, ...) \ + RTE_RDEV_LOG(DEBUG, fmt, ## __VA_ARGS__) +#define RTE_RDEV_INFO(fmt, ...) \ + RTE_RDEV_LOG(INFO, fmt, ## __VA_ARGS__) /* Macros to check for valid device */