Message ID | 1710968771-16435-14-git-send-email-roretzla@linux.microsoft.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1368943D0A; Wed, 20 Mar 2024 22:07:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF5C442E6C; Wed, 20 Mar 2024 22:06:29 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E56C842DDE for <dev@dpdk.org>; Wed, 20 Mar 2024 22:06:14 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id A01A220B74CD; Wed, 20 Mar 2024 14:06:13 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A01A220B74CD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1710968773; bh=b0CvR0Ms+ktV4xCAojokBzjbkgut/rmWvHdmYLlNBeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JrK8Iyh6KjviJn2jmnOQ871rLz36bYl/GuqYI2Ht3ADuJzzEH7uMsMJMp/uXFvC9Y k3/mZSzIVYo3tvEvAez/JeBIWkkbMkAhPgX9rTK4nx9LEHZ6E5jkhiGH1i9vO8XC5I FOiGihaw7UDfKoNADWqt9VzrHhB24gIwxxbWDfkc= From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Byron Marohn <byron.marohn@intel.com>, Conor Walsh <conor.walsh@intel.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>, David Hunt <david.hunt@intel.com>, Jerin Jacob <jerinj@marvell.com>, Jingjing Wu <jingjing.wu@intel.com>, Kirill Rybalchenko <kirill.rybalchenko@intel.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>, Radu Nicolau <radu.nicolau@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Sivaprasad Tummala <sivaprasad.tummala@amd.com>, Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>, Vamsi Attunuru <vattunuru@marvell.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Yipeng Wang <yipeng1.wang@intel.com>, Yuying Zhang <Yuying.Zhang@intel.com>, Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: [PATCH 13/15] app/testpmd: pack structures when building with MSVC Date: Wed, 20 Mar 2024 14:06:09 -0700 Message-Id: <1710968771-16435-14-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
fix packing of structs when building with MSVC
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Tyler Retzlaff
March 20, 2024, 9:06 p.m. UTC
Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
app/test-pmd/csumonly.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Wed, Mar 20, 2024 at 02:06:09PM -0700, Tyler Retzlaff wrote: > Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing > when building with MSVC. > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > --- > app/test-pmd/csumonly.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index 6711dda..638e607 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -89,6 +89,7 @@ struct testpmd_offload_info { > }; > > /* simplified GRE header */ > +__rte_msvc_pack > struct simple_gre_hdr { > uint16_t flags; > uint16_t proto; Should not need to be packed, as no padding. However, if we don't mark this as packed could we hit problems if (for whatever reason) we ever receive a packet where the gre_hdr is not aligned on an even byte boundary? Does packing affect the minimum alignment requirements of the whole struct, as well as removing padding? /Bruce
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 6711dda..638e607 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -89,6 +89,7 @@ struct testpmd_offload_info { }; /* simplified GRE header */ +__rte_msvc_pack struct simple_gre_hdr { uint16_t flags; uint16_t proto;