diff mbox series

common/mlx5: fix unsigned signed mismatch warning

Message ID 1713222577-7382-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Awaiting Upstream
Delegated to: Raslan Darawsheh
Headers
Series common/mlx5: fix unsigned signed mismatch warning |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

Tyler Retzlaff April 15, 2024, 11:09 p.m. UTC 
  Use unsigned int for 2 loop indexes that are being compared against an
unsigned int struct field to avoid signed/unsigned mismatch warning.

Fixes: 718d166e5504 ("net/mlx5: create advanced RxQ table via DevX")
Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT")
Cc: dekelp@mellanox.com
Cc: matan@mellanox.com
Cc: stable@dpdk.org

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dariusz Sosnowski April 16, 2024, 10:04 a.m. UTC | #1 
> -----Original Message-----
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Sent: Tuesday, April 16, 2024 01:10
> To: dev@dpdk.org
> Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; Dekel Peled
> <dekelp@nvidia.com>; Matan Azrad <matan@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Tyler Retzlaff
> <roretzla@linux.microsoft.com>; dekelp@mellanox.com; Matan Azrad
> <matan@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] common/mlx5: fix unsigned signed mismatch warning
> 
> Use unsigned int for 2 loop indexes that are being compared against an
> unsigned int struct field to avoid signed/unsigned mismatch warning.
> 
> Fixes: 718d166e5504 ("net/mlx5: create advanced RxQ table via DevX")
> Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT")
> Cc: dekelp@mellanox.com
> Cc: matan@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Thanks,
Dariusz Sosnowski
Raslan Darawsheh April 29, 2024, 7:46 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Sent: Tuesday, April 16, 2024 2:10 AM
> To: dev@dpdk.org
> Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; Dekel Peled
> <dekelp@nvidia.com>; Matan Azrad <matan@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Tyler Retzlaff
> <roretzla@linux.microsoft.com>; dekelp@mellanox.com; Matan Azrad
> <matan@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] common/mlx5: fix unsigned signed mismatch warning
> 
> Use unsigned int for 2 loop indexes that are being compared against an
> unsigned int struct field to avoid signed/unsigned mismatch warning.
> 
> Fixes: 718d166e5504 ("net/mlx5: create advanced RxQ table via DevX")
> Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT")
> Cc: dekelp@mellanox.com
> Cc: matan@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 9b7abab..9952733 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -1816,7 +1816,7 @@  struct mlx5_devx_obj *
 	uint32_t out[MLX5_ST_SZ_DW(create_rqt_out)] = {0};
 	void *rqt_ctx;
 	struct mlx5_devx_obj *rqt = NULL;
-	int i;
+	unsigned int i;
 
 	in = mlx5_malloc(MLX5_MEM_ZERO, inlen, 0, SOCKET_ID_ANY);
 	if (!in) {
@@ -1869,7 +1869,7 @@  struct mlx5_devx_obj *
 	uint32_t out[MLX5_ST_SZ_DW(modify_rqt_out)] = {0};
 	uint32_t *in = mlx5_malloc(MLX5_MEM_ZERO, inlen, 0, SOCKET_ID_ANY);
 	void *rqt_ctx;
-	int i;
+	unsigned int i;
 	int ret;
 
 	if (!in) {