From patchwork Mon Jan 9 23:30:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 19037 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id BF82AF91F; Tue, 10 Jan 2017 00:31:53 +0100 (CET) Received: from mail-pf0-f170.google.com (mail-pf0-f170.google.com [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id 5D2073777 for ; Tue, 10 Jan 2017 00:30:36 +0100 (CET) Received: by mail-pf0-f170.google.com with SMTP id 189so22867617pfu.3 for ; Mon, 09 Jan 2017 15:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jsloscbnwjwphG5nD2mj2ctKDdSpN4RBz+L58/yL23o=; b=nQpbwZnBYXYZ/bLNGIOcf+hiHLnZKxKpbqpNBZp5eIefisJvjnv0lRZUOJCqBtC+ZC SxqEaAFCEvX5Fo5B8rlfldxbLtnlEst1RzP3kmmh9WVuyUjuZTDyrXK4eqDExanwUsJi n+FquChbWCsefGcS+KOfEbmfZiGA66HGLNCP6OrsS4EnIQxgNx6VkTu7acSprIm2LmQs GSJ1Ut9QBbmkcMEU/sqnWgqV6PWiwBmGEbPUD07AvuQcrraHQLOwYBmAl363MoFkQ9QL i9W/rtXmmLWJ8Cnjf7w8O+ifMl6qnGRf4/uepgdPlACppGbqZD2xDTAb5NNUw1is/aBq HLRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jsloscbnwjwphG5nD2mj2ctKDdSpN4RBz+L58/yL23o=; b=ZdNtpdM/+dnfiZG8vEAA3WbPbDkKXVmrp29XbFvA9GIqO+KbbGj6owtM9XUpASnrJ7 FT/HcTOlXGhj98oXdlu/u4bYk0ObxhssOpR1Szxqtw1lYpmVA/LxJFsP0jwcIxSONsK/ wOQnky/gmY08/qqgwgBVcR45+sstr3ZfVAKAP5e7dRO8D+0/ckAKeKCKwd+yF77OOg2S M5XYAa5YYM7M6bO+O19uB7SHrWik6ICMiTknXG5G5pVRj4URsl+varTZHvP18byKOU6n lhwUuQhKX+ZiMgJEQNjVpCJQPEttNaq6zyr3sISWewS3ltFyOAaXV6pWfdFMJtAM8KlI TU4A== X-Gm-Message-State: AIkVDXLBmAJvEY21AhT8cxAMLDQw1OfnkvEfplokkHMcnTkAPNAz/HeZ71AROORnCv/VQA== X-Received: by 10.98.80.205 with SMTP id g74mr211749pfj.151.1484004635438; Mon, 09 Jan 2017 15:30:35 -0800 (PST) Received: from xeon-e3.wavecable.com (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id s78sm12658pfk.82.2017.01.09.15.30.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 15:30:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 9 Jan 2017 15:30:21 -0800 Message-Id: <20170109233022.31154-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170109233022.31154-1-stephen@networkplumber.org> References: <20170109233022.31154-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 6/7] ixgbe: remove useless return X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If all goto's lead to a return, then better to get rid of goto. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev Acked-by: Wei Dai --- drivers/net/ixgbe/ixgbe_82599_bypass.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_82599_bypass.c b/drivers/net/ixgbe/ixgbe_82599_bypass.c index de9fa5a7..af55cc0a 100644 --- a/drivers/net/ixgbe/ixgbe_82599_bypass.c +++ b/drivers/net/ixgbe/ixgbe_82599_bypass.c @@ -73,7 +73,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) &eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to read Rx Rate Select RS0"); - goto out; + return; } eeprom_data = (eeprom_data & ~IXGBE_SFF_SOFT_RS_SELECT_MASK) & rs; @@ -83,7 +83,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to write Rx Rate Select RS0"); - goto out; + return; } /* Set RS1 */ @@ -92,7 +92,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) &eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to read Rx Rate Select RS1"); - goto out; + return; } eeprom_data = (eeprom_data & ~IXGBE_SFF_SOFT_RS_SELECT_MASK) & rs; @@ -102,10 +102,8 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to write Rx Rate Select RS1"); - goto out; + return; } -out: - return; } /**