diff mbox

[dpdk-dev,04/11] doc/howto: use corelist instead of coremask

Message ID 20170209181450.58466-5-keith.wiles@intel.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Wiles, Keith Feb. 9, 2017, 6:14 p.m. UTC 
  Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
 doc/guides/howto/flow_bifurcation.rst     | 2 +-
 doc/guides/howto/lm_bond_virtio_sriov.rst | 6 +++---
 doc/guides/howto/lm_virtio_vhost_user.rst | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

Comments

Igor Ryzhov Feb. 9, 2017, 11 p.m. UTC | #1 
Hello Keith,
comments inline below.

On Thu, Feb 9, 2017 at 9:14 PM, Keith Wiles <keith.wiles@intel.com> wrote:

> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  doc/guides/howto/flow_bifurcation.rst     | 2 +-
>  doc/guides/howto/lm_bond_virtio_sriov.rst | 6 +++---
>  doc/guides/howto/lm_virtio_vhost_user.rst | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/doc/guides/howto/flow_bifurcation.rst
> b/doc/guides/howto/flow_bifurcation.rst
> index 0d7226a..ad544ce 100644
> --- a/doc/guides/howto/flow_bifurcation.rst
> +++ b/doc/guides/howto/flow_bifurcation.rst
> @@ -126,7 +126,7 @@ The typical procedure to achieve this is as follows:
>
>     .. code-block:: console
>
> -       testpmd -c 0xff -n 4 -- -i -w 01:10.0 -w 01:10.1 --forward-mode=mac
> +       testpmd -l 0-7 -n 4 -- -i -w 01:10.0 -w 01:10.1 --forward-mode=mac
>
>  In this example, traffic matching the rules will go through the VF by
> matching
>  the filter rule. All other traffic, not matching the rules, will go
> through
> diff --git a/doc/guides/howto/lm_bond_virtio_sriov.rst
> b/doc/guides/howto/lm_bond_virtio_sriov.rst
> index 169b64e..bdf2749 100644
> --- a/doc/guides/howto/lm_bond_virtio_sriov.rst
> +++ b/doc/guides/howto/lm_bond_virtio_sriov.rst
> @@ -442,7 +442,7 @@ Setup Virtual Machine on host_server_1
>     # Memory
>     MEM=1536
>
> -   taskset -c 1-5 $KVM_PATH \
> +   taskset -l 1-5 $KVM_PATH \
>

-c is legal option for taskset utility, not -l.


>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -545,7 +545,7 @@ Setup Virtual Machine on host_server_2
>     # Memory
>     MEM=1536
>
> -   taskset -c 1-5 $KVM_PATH \
> +   taskset -l 1-5 $KVM_PATH \
>

Same as previous.


>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -641,7 +641,7 @@ Run testpmd in the Virtual Machine.
>     # use for bonding of virtio and vf tests in VM
>
>     /root/dpdk/x86_64-default-linuxapp-gcc/app/testpmd \
> -   -c f -n 4 --socket-mem 350 --  --i --port-topology=chained
> +   -l 0-3 -n 4 --socket-mem 350 --  --i --port-topology=chained
>
>  .. _lm_bond_virtio_sriov_switch_conf:
>
> diff --git a/doc/guides/howto/lm_virtio_vhost_user.rst
> b/doc/guides/howto/lm_virtio_vhost_user.rst
> index 0a0fcfc..7e440ff 100644
> --- a/doc/guides/howto/lm_virtio_vhost_user.rst
> +++ b/doc/guides/howto/lm_virtio_vhost_user.rst
> @@ -326,7 +326,7 @@ vm_virtio_vhost_user.sh
>     # Socket Path
>     SOCKET_PATH="/root/dpdk/host_scripts/usvhost"
>
> -   taskset -c 2-7 $KVM_PATH \
> +   taskset -l 2-7 $KVM_PATH \
>

Same.


>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -402,7 +402,7 @@ vm_virtio_vhost_user_migrate.sh
>     # Socket Path
>     SOCKET_PATH="/root/dpdk/host_scripts/usvhost"
>
> -   taskset -c 2-7 $KVM_PATH \
> +   taskset -l 2-7 $KVM_PATH \
>

Same.


>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -466,4 +466,4 @@ run_testpmd_in_vm.sh
>     # test system has 8 cpus (0-7), use cpus 2-7 for VM
>
>     /root/dpdk/x86_64-default-linuxapp-gcc/app/testpmd \
> -   -c 3f -n 4 --socket-mem 350 -- --burst=64 --i --disable-hw-vlan-filter
> +   -l 0-5 -n 4 --socket-mem 350 -- --burst=64 --i --disable-hw-vlan-filter
> --
> 2.8.0.GIT
>
>
Best regards,
Igor
Wiles, Keith Feb. 9, 2017, 11:20 p.m. UTC | #2 
> On Feb 9, 2017, at 5:00 PM, Igor Ryzhov <iryzhov@nfware.com> wrote:
> 
> Hello Keith,
> comments inline below.
> 
> On Thu, Feb 9, 2017 at 9:14 PM, Keith Wiles <keith.wiles@intel.com> wrote:
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  doc/guides/howto/flow_bifurcation.rst     | 2 +-
>  doc/guides/howto/lm_bond_virtio_sriov.rst | 6 +++---
>  doc/guides/howto/lm_virtio_vhost_user.rst | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/doc/guides/howto/flow_bifurcation.rst b/doc/guides/howto/flow_bifurcation.rst
> index 0d7226a..ad544ce 100644
> --- a/doc/guides/howto/flow_bifurcation.rst
> +++ b/doc/guides/howto/flow_bifurcation.rst
> @@ -126,7 +126,7 @@ The typical procedure to achieve this is as follows:
> 
>     .. code-block:: console
> 
> -       testpmd -c 0xff -n 4 -- -i -w 01:10.0 -w 01:10.1 --forward-mode=mac
> +       testpmd -l 0-7 -n 4 -- -i -w 01:10.0 -w 01:10.1 --forward-mode=mac
> 
>  In this example, traffic matching the rules will go through the VF by matching
>  the filter rule. All other traffic, not matching the rules, will go through
> diff --git a/doc/guides/howto/lm_bond_virtio_sriov.rst b/doc/guides/howto/lm_bond_virtio_sriov.rst
> index 169b64e..bdf2749 100644
> --- a/doc/guides/howto/lm_bond_virtio_sriov.rst
> +++ b/doc/guides/howto/lm_bond_virtio_sriov.rst
> @@ -442,7 +442,7 @@ Setup Virtual Machine on host_server_1
>     # Memory
>     MEM=1536
> 
> -   taskset -c 1-5 $KVM_PATH \
> +   taskset -l 1-5 $KVM_PATH \
> 
> -c is legal option for taskset utility, not -l.

OK will fix that one


>  
>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -545,7 +545,7 @@ Setup Virtual Machine on host_server_2
>     # Memory
>     MEM=1536
> 
> -   taskset -c 1-5 $KVM_PATH \
> +   taskset -l 1-5 $KVM_PATH \
> 
> Same as previous.
>  
>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -641,7 +641,7 @@ Run testpmd in the Virtual Machine.
>     # use for bonding of virtio and vf tests in VM
> 
>     /root/dpdk/x86_64-default-linuxapp-gcc/app/testpmd \
> -   -c f -n 4 --socket-mem 350 --  --i --port-topology=chained
> +   -l 0-3 -n 4 --socket-mem 350 --  --i --port-topology=chained
> 
>  .. _lm_bond_virtio_sriov_switch_conf:
> 
> diff --git a/doc/guides/howto/lm_virtio_vhost_user.rst b/doc/guides/howto/lm_virtio_vhost_user.rst
> index 0a0fcfc..7e440ff 100644
> --- a/doc/guides/howto/lm_virtio_vhost_user.rst
> +++ b/doc/guides/howto/lm_virtio_vhost_user.rst
> @@ -326,7 +326,7 @@ vm_virtio_vhost_user.sh
>     # Socket Path
>     SOCKET_PATH="/root/dpdk/host_scripts/usvhost"
> 
> -   taskset -c 2-7 $KVM_PATH \
> +   taskset -l 2-7 $KVM_PATH \
> 
> Same.
>  
>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -402,7 +402,7 @@ vm_virtio_vhost_user_migrate.sh
>     # Socket Path
>     SOCKET_PATH="/root/dpdk/host_scripts/usvhost"
> 
> -   taskset -c 2-7 $KVM_PATH \
> +   taskset -l 2-7 $KVM_PATH \
> 
> Same.
>  
>      -enable-kvm \
>      -m $MEM \
>      -smp $VCPUS_NR \
> @@ -466,4 +466,4 @@ run_testpmd_in_vm.sh
>     # test system has 8 cpus (0-7), use cpus 2-7 for VM
> 
>     /root/dpdk/x86_64-default-linuxapp-gcc/app/testpmd \
> -   -c 3f -n 4 --socket-mem 350 -- --burst=64 --i --disable-hw-vlan-filter
> +   -l 0-5 -n 4 --socket-mem 350 -- --burst=64 --i --disable-hw-vlan-filter
> --
> 2.8.0.GIT
> 
> 
> Best regards,
> Igor

Regards,
Keith
diff mbox

Patch

diff --git a/doc/guides/howto/flow_bifurcation.rst b/doc/guides/howto/flow_bifurcation.rst
index 0d7226a..ad544ce 100644
--- a/doc/guides/howto/flow_bifurcation.rst
+++ b/doc/guides/howto/flow_bifurcation.rst
@@ -126,7 +126,7 @@  The typical procedure to achieve this is as follows:
 
    .. code-block:: console
 
-       testpmd -c 0xff -n 4 -- -i -w 01:10.0 -w 01:10.1 --forward-mode=mac
+       testpmd -l 0-7 -n 4 -- -i -w 01:10.0 -w 01:10.1 --forward-mode=mac
 
 In this example, traffic matching the rules will go through the VF by matching
 the filter rule. All other traffic, not matching the rules, will go through
diff --git a/doc/guides/howto/lm_bond_virtio_sriov.rst b/doc/guides/howto/lm_bond_virtio_sriov.rst
index 169b64e..bdf2749 100644
--- a/doc/guides/howto/lm_bond_virtio_sriov.rst
+++ b/doc/guides/howto/lm_bond_virtio_sriov.rst
@@ -442,7 +442,7 @@  Setup Virtual Machine on host_server_1
    # Memory
    MEM=1536
 
-   taskset -c 1-5 $KVM_PATH \
+   taskset -l 1-5 $KVM_PATH \
     -enable-kvm \
     -m $MEM \
     -smp $VCPUS_NR \
@@ -545,7 +545,7 @@  Setup Virtual Machine on host_server_2
    # Memory
    MEM=1536
 
-   taskset -c 1-5 $KVM_PATH \
+   taskset -l 1-5 $KVM_PATH \
     -enable-kvm \
     -m $MEM \
     -smp $VCPUS_NR \
@@ -641,7 +641,7 @@  Run testpmd in the Virtual Machine.
    # use for bonding of virtio and vf tests in VM
 
    /root/dpdk/x86_64-default-linuxapp-gcc/app/testpmd \
-   -c f -n 4 --socket-mem 350 --  --i --port-topology=chained
+   -l 0-3 -n 4 --socket-mem 350 --  --i --port-topology=chained
 
 .. _lm_bond_virtio_sriov_switch_conf:
 
diff --git a/doc/guides/howto/lm_virtio_vhost_user.rst b/doc/guides/howto/lm_virtio_vhost_user.rst
index 0a0fcfc..7e440ff 100644
--- a/doc/guides/howto/lm_virtio_vhost_user.rst
+++ b/doc/guides/howto/lm_virtio_vhost_user.rst
@@ -326,7 +326,7 @@  vm_virtio_vhost_user.sh
    # Socket Path
    SOCKET_PATH="/root/dpdk/host_scripts/usvhost"
 
-   taskset -c 2-7 $KVM_PATH \
+   taskset -l 2-7 $KVM_PATH \
     -enable-kvm \
     -m $MEM \
     -smp $VCPUS_NR \
@@ -402,7 +402,7 @@  vm_virtio_vhost_user_migrate.sh
    # Socket Path
    SOCKET_PATH="/root/dpdk/host_scripts/usvhost"
 
-   taskset -c 2-7 $KVM_PATH \
+   taskset -l 2-7 $KVM_PATH \
     -enable-kvm \
     -m $MEM \
     -smp $VCPUS_NR \
@@ -466,4 +466,4 @@  run_testpmd_in_vm.sh
    # test system has 8 cpus (0-7), use cpus 2-7 for VM
 
    /root/dpdk/x86_64-default-linuxapp-gcc/app/testpmd \
-   -c 3f -n 4 --socket-mem 350 -- --burst=64 --i --disable-hw-vlan-filter
+   -l 0-5 -n 4 --socket-mem 350 -- --burst=64 --i --disable-hw-vlan-filter