diff mbox

[dpdk-dev,v2,1/2] net/i40e: enable VF untag drop

Message ID 20170313045543.65464-2-qi.z.zhang@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Qi Zhang March 13, 2017, 4:55 a.m. UTC 
  Add a new private API to support the untag drop enable/disable
for specific VF.
Add a flag "untag_drop" in i40e_vsi to help track the untag drop
status, so it prevent error from i40e_aq_remove_vlan when call
rte_pmd_i40e_set_vf_vlan_untag_drop twice.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
V2:
- Add a flag "untag_drop" in i40e_vsi to track the untag drop status.

 drivers/net/i40e/i40e_ethdev.c  | 54 +++++++++++++++++++++++++++++++++++++++++
 drivers/net/i40e/i40e_ethdev.h  |  1 +
 drivers/net/i40e/rte_pmd_i40e.h | 18 ++++++++++++++
 3 files changed, 73 insertions(+)
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 303027b..304b02b 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -11212,3 +11212,57 @@  rte_pmd_i40e_reset_vf_stats(uint8_t port,
 
 	return 0;
 }
+
+int rte_pmd_i40e_set_vf_vlan_untag_drop(uint8_t port,
+					uint16_t vf_id,
+					uint8_t on)
+{
+	struct rte_eth_dev *dev;
+	struct i40e_pf *pf;
+	struct i40e_vsi *vsi;
+	struct i40e_aqc_add_remove_vlan_element_data vlan_data = {0};
+	struct i40e_hw *hw;
+	int ret = 0;
+
+	RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+
+	dev = &rte_eth_devices[port];
+
+	if (!is_device_supported(dev, &rte_i40e_pmd))
+		return -ENOTSUP;
+
+	pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+
+	if (vf_id >= pf->vf_num || !pf->vfs) {
+		PMD_DRV_LOG(ERR, "Invalid VF ID.");
+		return -EINVAL;
+	}
+
+	vsi = pf->vfs[vf_id].vsi;
+	if (!vsi) {
+		PMD_DRV_LOG(ERR, "Invalid VSI.");
+		return -EINVAL;
+	}
+
+
+	hw = I40E_VSI_TO_HW(vsi);
+	vlan_data.vlan_tag = 0;
+	vlan_data.vlan_flags = 0x1;
+
+	if (on && !vsi->untag_drop) {
+		ret = i40e_aq_add_vlan(hw, vsi->seid, &vlan_data, 1, NULL);
+		if (ret != I40E_SUCCESS)
+			PMD_DRV_LOG(ERR, "Failed to add vlan filter");
+		else
+			vsi->untag_drop = 1;
+	} else if (!on && vsi->untag_drop) {
+		ret = i40e_aq_remove_vlan(hw, vsi->seid,
+					&vlan_data, 1, NULL);
+		if (ret != I40E_SUCCESS)
+			PMD_DRV_LOG(ERR, "Failed to remove vlan filter");
+		else
+			vsi->untag_drop = 0;
+	}
+
+	return ret;
+}
diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
index f545850..25d0c49 100644
--- a/drivers/net/i40e/i40e_ethdev.h
+++ b/drivers/net/i40e/i40e_ethdev.h
@@ -365,6 +365,7 @@  struct i40e_vsi {
 	uint8_t enabled_tc; /* The traffic class enabled */
 	uint8_t vlan_anti_spoof_on; /* The VLAN anti-spoofing enabled */
 	struct i40e_bw_info bw_info; /* VSI bandwidth information */
+	uint8_t untag_drop; /* VLAN untagged drop enable/disable status */
 };
 
 struct pool_entry {
diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h
index a0ad88c..895e2cc 100644
--- a/drivers/net/i40e/rte_pmd_i40e.h
+++ b/drivers/net/i40e/rte_pmd_i40e.h
@@ -332,4 +332,22 @@  int rte_pmd_i40e_get_vf_stats(uint8_t port,
 int rte_pmd_i40e_reset_vf_stats(uint8_t port,
 				uint16_t vf_id);
 
+/**
+ * Enable/Disable VF untag drop
+ *
+ * @param port
+ *    The port identifier of the Ethernet device.
+ * @param vf_id
+ *    VF on witch to enable/disable
+ * @param on
+ *    Enable or Disable
+ * @retura
+ *  - (0) if successful.
+ *  -(-ENODEVE) if *port* invalid
+ *  -(-EINVAL) if bad parameter.
+ */
+int rte_pmd_i40e_set_vf_vlan_untag_drop(uint8_t port,
+					uint16_t vf_id,
+					uint8_t on);
+
 #endif /* _PMD_I40E_H_ */