From patchwork Thu Oct 5 15:06:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 29760 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEB771B25B; Thu, 5 Oct 2017 17:06:56 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 606931B219 for ; Thu, 5 Oct 2017 17:06:52 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.224.233]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 3072030C00C; Thu, 5 Oct 2017 08:06:51 -0700 (PDT) Received: from C02PT1RBG8WP.wifi.broadcom.net (c02pt1rbg8wp.wifi.broadcom.net [10.45.51.51]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id CDCF581EAD; Thu, 5 Oct 2017 08:06:50 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Thu, 5 Oct 2017 10:06:46 -0500 Message-Id: <20171005150646.3188-5-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.13.5 (Apple Git-94) In-Reply-To: <20171005150646.3188-1-ajit.khaparde@broadcom.com> References: <20171005142803.2143-1-ajit.khaparde@broadcom.com> <20171005150646.3188-1-ajit.khaparde@broadcom.com> Subject: [dpdk-dev] [PATCH v2 4/4] net/bnxt: fix some unnecessary parentheses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch removes some unnecessary parentheses from the code. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------ drivers/net/bnxt/bnxt_filter.c | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index c559a9db8..636f09a66 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1734,9 +1734,9 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp, STAILQ_FOREACH(mfilter, &vnic0->filter, next) { if ((!memcmp(efilter->mac_addr.addr_bytes, mfilter->l2_addr, ETHER_ADDR_LEN) && - (mfilter->flags == - HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) && - (mfilter->ethertype == efilter->ether_type))) { + mfilter->flags == + HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP && + mfilter->ethertype == efilter->ether_type)) { match = 1; break; } @@ -1745,9 +1745,9 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp, STAILQ_FOREACH(mfilter, &vnic->filter, next) if ((!memcmp(efilter->mac_addr.addr_bytes, mfilter->l2_addr, ETHER_ADDR_LEN) && - (mfilter->ethertype == efilter->ether_type) && - (mfilter->flags == - HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) { + mfilter->ethertype == efilter->ether_type && + mfilter->flags == + HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX)) { match = 1; break; } diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index 3eaa7e45a..d470be259 100644 --- a/drivers/net/bnxt/bnxt_filter.c +++ b/drivers/net/bnxt/bnxt_filter.c @@ -612,7 +612,7 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_item pattern[], if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] || vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] || - (vxlan_spec->flags != 0x8)) { + vxlan_spec->flags != 0x8) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item, @@ -659,8 +659,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_item pattern[], return -rte_errno; } - if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) || - (nvgre_spec->protocol != 0x6558)) { + if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 || + nvgre_spec->protocol != 0x6558) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item,