diff mbox

[dpdk-dev] devtools: rename build dependency of mlx drivers

Message ID 20171011132858.1863-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Thomas Monjalon Oct. 11, 2017, 1:28 p.m. UTC 
  The Mellanox drivers were requiring MOFED at compilation time.
It is now possible to use the upstream rdma-core package.
So the dependency option is renamed in the build tool.

Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 devtools/test-build.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Nélio Laranjeiro Oct. 11, 2017, 2:39 p.m. UTC | #1 
On Wed, Oct 11, 2017 at 03:28:58PM +0200, Thomas Monjalon wrote:
> The Mellanox drivers were requiring MOFED at compilation time.
> It is now possible to use the upstream rdma-core package.
> So the dependency option is renamed in the build tool.
> 
> Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/test-build.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index c6dfaf0a8..34fba9b96 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -39,7 +39,7 @@ default_path=$PATH
>  # - DPDK_DEP_ARCHIVE
>  # - DPDK_DEP_CFLAGS
>  # - DPDK_DEP_LDFLAGS
> -# - DPDK_DEP_MOFED (y/[n])
> +# - DPDK_DEP_MLX (y/[n])
>  # - DPDK_DEP_NUMA ([y]/n)
>  # - DPDK_DEP_PCAP (y/[n])
>  # - DPDK_DEP_SSL (y/[n])
> @@ -121,7 +121,7 @@ reset_env ()
>  	unset DPDK_DEP_ARCHIVE
>  	unset DPDK_DEP_CFLAGS
>  	unset DPDK_DEP_LDFLAGS
> -	unset DPDK_DEP_MOFED
> +	unset DPDK_DEP_MLX
>  	unset DPDK_DEP_NUMA
>  	unset DPDK_DEP_PCAP
>  	unset DPDK_DEP_SSL
> @@ -167,7 +167,7 @@ config () # <directory> <target> <options>
>  		sed -ri             's,(BYPASS=)n,\1y,' $1/.config
>  		test "$DPDK_DEP_ARCHIVE" != y || \
>  		sed -ri       's,(RESOURCE_TAR=)n,\1y,' $1/.config
> -		test "$DPDK_DEP_MOFED" != y || \
> +		test "$DPDK_DEP_MLX" != y || \
>  		sed -ri           's,(MLX._PMD=)n,\1y,' $1/.config
>  		test "$DPDK_DEP_SZE" != y || \
>  		sed -ri       's,(PMD_SZEDATA2=)n,\1y,' $1/.config
> -- 
> 2.14.1
 
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Thomas Monjalon Nov. 7, 2017, 10:48 p.m. UTC | #2 
11/10/2017 16:39, Nélio Laranjeiro:
> On Wed, Oct 11, 2017 at 03:28:58PM +0200, Thomas Monjalon wrote:
> > The Mellanox drivers were requiring MOFED at compilation time.
> > It is now possible to use the upstream rdma-core package.
> > So the dependency option is renamed in the build tool.
> > 
> > Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>  
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied
diff mbox

Patch

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index c6dfaf0a8..34fba9b96 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -39,7 +39,7 @@  default_path=$PATH
 # - DPDK_DEP_ARCHIVE
 # - DPDK_DEP_CFLAGS
 # - DPDK_DEP_LDFLAGS
-# - DPDK_DEP_MOFED (y/[n])
+# - DPDK_DEP_MLX (y/[n])
 # - DPDK_DEP_NUMA ([y]/n)
 # - DPDK_DEP_PCAP (y/[n])
 # - DPDK_DEP_SSL (y/[n])
@@ -121,7 +121,7 @@  reset_env ()
 	unset DPDK_DEP_ARCHIVE
 	unset DPDK_DEP_CFLAGS
 	unset DPDK_DEP_LDFLAGS
-	unset DPDK_DEP_MOFED
+	unset DPDK_DEP_MLX
 	unset DPDK_DEP_NUMA
 	unset DPDK_DEP_PCAP
 	unset DPDK_DEP_SSL
@@ -167,7 +167,7 @@  config () # <directory> <target> <options>
 		sed -ri             's,(BYPASS=)n,\1y,' $1/.config
 		test "$DPDK_DEP_ARCHIVE" != y || \
 		sed -ri       's,(RESOURCE_TAR=)n,\1y,' $1/.config
-		test "$DPDK_DEP_MOFED" != y || \
+		test "$DPDK_DEP_MLX" != y || \
 		sed -ri           's,(MLX._PMD=)n,\1y,' $1/.config
 		test "$DPDK_DEP_SZE" != y || \
 		sed -ri       's,(PMD_SZEDATA2=)n,\1y,' $1/.config