[dpdk-dev] vhost: fetch again ring_addrs address after NUMA reallocation
Checks
Commit Message
In case of NUMA reallocation, the virtqueue struct is reallocated
on another socket, meaning that its address changes.
In translate_ring_addresses(), addr pointer was not fetched again
after the reallocation, so it pointed to freed memory.
This patch just fetch again addr pointer after the reallocation.
Reported-by: Yao, Lei A <lei.a.yao@intel.com>
Tested-by: Yao, Lei A <lei.a.yao@intel.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/librte_vhost/vhost_user.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote:
>In case of NUMA reallocation, the virtqueue struct is reallocated
>on another socket, meaning that its address changes.
>
>In translate_ring_addresses(), addr pointer was not fetched again
>after the reallocation, so it pointed to freed memory.
>
>This patch just fetch again addr pointer after the reallocation.
>
>Reported-by: Yao, Lei A <lei.a.yao@intel.com>
>Tested-by: Yao, Lei A <lei.a.yao@intel.com>
>Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>---
> lib/librte_vhost/vhost_user.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
13/10/2017 11:43, Jens Freimann:
> On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote:
> >In case of NUMA reallocation, the virtqueue struct is reallocated
> >on another socket, meaning that its address changes.
> >
> >In translate_ring_addresses(), addr pointer was not fetched again
> >after the reallocation, so it pointed to freed memory.
> >
> >This patch just fetch again addr pointer after the reallocation.
> >
> >Reported-by: Yao, Lei A <lei.a.yao@intel.com>
> >Tested-by: Yao, Lei A <lei.a.yao@intel.com>
> >Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
Applied, thanks
@@ -417,6 +417,7 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)
dev = numa_realloc(dev, vq_index);
vq = dev->virtqueue[vq_index];
+ addr = &vq->ring_addrs;
vq->avail = (struct vring_avail *)(uintptr_t)ring_addr_to_vva(dev,
vq, addr->avail_user_addr, sizeof(struct vring_avail));