From patchwork Wed Oct 18 07:19:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 30504 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 811141B5FD; Wed, 18 Oct 2017 09:19:59 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id D13DC1B5F6 for ; Wed, 18 Oct 2017 09:19:58 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from xuemingl@mellanox.com) with ESMTPS (AES256-SHA encrypted); 18 Oct 2017 09:19:56 +0200 Received: from dev-r630-06.mtbc.labs.mlnx (dev-r630-06.mtbc.labs.mlnx [10.12.205.180]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v9I7JtZq023178; Wed, 18 Oct 2017 10:19:56 +0300 Received: from dev-r630-06.mtbc.labs.mlnx (localhost [127.0.0.1]) by dev-r630-06.mtbc.labs.mlnx (8.14.7/8.14.7) with ESMTP id v9I7JspU178902; Wed, 18 Oct 2017 15:19:54 +0800 Received: (from xuemingl@localhost) by dev-r630-06.mtbc.labs.mlnx (8.14.7/8.14.7/Submit) id v9I7JoaQ178892; Wed, 18 Oct 2017 15:19:50 +0800 From: Xueming Li To: Keith Wiles Cc: dev@dpdk.org, Xueming Li Date: Wed, 18 Oct 2017 15:19:22 +0800 Message-Id: <20171018071922.178848-1-xuemingl@mellanox.com> X-Mailer: git-send-email 2.13.3 Subject: [dpdk-dev] [PktGen] remove mbuf refcnt verification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" To improve performance, dpdk drivers are using raw mbuf apis w/o refcnt reset when returning packet to pool. This patch remove refcnt validation when allocating mbufs from pool. Signed-off-by: Xueming Li --- lib/common/mbuf.h | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/lib/common/mbuf.h b/lib/common/mbuf.h index 706ff3f..4c86502 100644 --- a/lib/common/mbuf.h +++ b/lib/common/mbuf.h @@ -81,41 +81,21 @@ pg_pktmbuf_alloc_bulk(struct rte_mempool *pool, switch (count % 4) { case 0: while (idx != count) { -#ifdef RTE_ASSERT - RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#else - RTE_VERIFY(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#endif rte_mbuf_refcnt_set(mbufs[idx], 1); pktmbuf_reset(mbufs[idx]); idx++; /* fall-through */ case 3: -#ifdef RTE_ASSERT - RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#else - RTE_VERIFY(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#endif rte_mbuf_refcnt_set(mbufs[idx], 1); pktmbuf_reset(mbufs[idx]); idx++; /* fall-through */ case 2: -#ifdef RTE_ASSERT - RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#else - RTE_VERIFY(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#endif rte_mbuf_refcnt_set(mbufs[idx], 1); pktmbuf_reset(mbufs[idx]); idx++; /* fall-through */ case 1: -#ifdef RTE_ASSERT - RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#else - RTE_VERIFY(rte_mbuf_refcnt_read(mbufs[idx]) == 0); -#endif rte_mbuf_refcnt_set(mbufs[idx], 1); pktmbuf_reset(mbufs[idx]); idx++;