diff mbox

[dpdk-dev,v2] examples/l3fwd: fix NEON instructions

Message ID 20171030073126.1662-1-gprathyusha@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Guduri Prathyusha Oct. 30, 2017, 7:31 a.m. UTC 
  To group consecutive packets with same destination port in bursts of 4
neon intrinsic data types dp1 and dp2 are calculated such that if
dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: <a,b,c,d> and
dp2 should contain: <b,c,d,e> in the first iteration. dp1 should
be <e,f,g,h> and dp2 should be <f,g,h,i> in the next iteration.

Whereas the existing code incorrectly calculates dp1 as <d,e,f,g> from
second iteration.

This patch fixes the incorrect ARM NEON instructions on dp1.

Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation")

Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
---

v2:

* fix as suggested by Jianbo Liu
---
 examples/l3fwd/l3fwd_neon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jianbo Liu Oct. 30, 2017, 7:36 a.m. UTC | #1 
The 10/30/2017 13:01, Guduri Prathyusha wrote:
> To group consecutive packets with same destination port in bursts of 4
> neon intrinsic data types dp1 and dp2 are calculated such that if
> dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: <a,b,c,d> and
> dp2 should contain: <b,c,d,e> in the first iteration. dp1 should
> be <e,f,g,h> and dp2 should be <f,g,h,i> in the next iteration.
>
> Whereas the existing code incorrectly calculates dp1 as <d,e,f,g> from
> second iteration.
>
> This patch fixes the incorrect ARM NEON instructions on dp1.
>
> Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation")
>
> Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>

Acked-by: Jianbo Liu <jianbo.liu@arm.com>

> ---
>
> v2:
>
> * fix as suggested by Jianbo Liu
> ---
>  examples/l3fwd/l3fwd_neon.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h
> index 42d50d3c2..4bc161394 100644
> --- a/examples/l3fwd/l3fwd_neon.h
> +++ b/examples/l3fwd/l3fwd_neon.h
> @@ -192,7 +192,7 @@ send_packets_multi(struct lcore_conf *qconf, struct rte_mbuf **pkts_burst,
>                        * dp1:
>                        * <d[j], d[j+1], d[j+2], d[j+3], ... >
>                        */
> -                     dp1 = vextq_u16(dp1, dp1, FWDSTEP - 1);
> +                     dp1 = vextq_u16(dp2, dp1, FWDSTEP - 1);
>               }
>
>               /*
> --
> 2.14.1
>

--
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Jerin Jacob Nov. 2, 2017, 10:33 a.m. UTC | #2 
-----Original Message-----
> Date: Mon, 30 Oct 2017 15:36:15 +0800
> From: Jianbo Liu <Jianbo.Liu@arm.com>
> To: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> CC: tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> The 10/30/2017 13:01, Guduri Prathyusha wrote:
> > To group consecutive packets with same destination port in bursts of 4
> > neon intrinsic data types dp1 and dp2 are calculated such that if
> > dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: <a,b,c,d> and
> > dp2 should contain: <b,c,d,e> in the first iteration. dp1 should
> > be <e,f,g,h> and dp2 should be <f,g,h,i> in the next iteration.
> >
> > Whereas the existing code incorrectly calculates dp1 as <d,e,f,g> from
> > second iteration.
> >
> > This patch fixes the incorrect ARM NEON instructions on dp1.
> >
> > Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation")
> >
> > Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> 
> Acked-by: Jianbo Liu <jianbo.liu@arm.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Cc: Thomas Monjalon <thomas@monjalon.net> to add this patch in RC3

> 
> > ---
> >
> > v2:
> >
> > * fix as suggested by Jianbo Liu
> > ---
> >  examples/l3fwd/l3fwd_neon.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h
> > index 42d50d3c2..4bc161394 100644
> > --- a/examples/l3fwd/l3fwd_neon.h
> > +++ b/examples/l3fwd/l3fwd_neon.h
> > @@ -192,7 +192,7 @@ send_packets_multi(struct lcore_conf *qconf, struct rte_mbuf **pkts_burst,
> >                        * dp1:
> >                        * <d[j], d[j+1], d[j+2], d[j+3], ... >
> >                        */
> > -                     dp1 = vextq_u16(dp1, dp1, FWDSTEP - 1);
> > +                     dp1 = vextq_u16(dp2, dp1, FWDSTEP - 1);
> >               }
> >
> >               /*
> > --
> > 2.14.1
> >
> 
> --
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Ferruh Yigit Nov. 7, 2017, 8:05 a.m. UTC | #3 
On 11/2/2017 3:33 AM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 30 Oct 2017 15:36:15 +0800
>> From: Jianbo Liu <Jianbo.Liu@arm.com>
>> To: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
>> CC: tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions
>> User-Agent: Mutt/1.5.21 (2010-09-15)
>>
>> The 10/30/2017 13:01, Guduri Prathyusha wrote:
>>> To group consecutive packets with same destination port in bursts of 4
>>> neon intrinsic data types dp1 and dp2 are calculated such that if
>>> dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: <a,b,c,d> and
>>> dp2 should contain: <b,c,d,e> in the first iteration. dp1 should
>>> be <e,f,g,h> and dp2 should be <f,g,h,i> in the next iteration.
>>>
>>> Whereas the existing code incorrectly calculates dp1 as <d,e,f,g> from
>>> second iteration.
>>>
>>> This patch fixes the incorrect ARM NEON instructions on dp1.
>>>
>>> Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation")
>>>
>>> Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
>>
>> Acked-by: Jianbo Liu <jianbo.liu@arm.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied to dpdk/master, thanks.
diff mbox

Patch

diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h
index 42d50d3c2..4bc161394 100644
--- a/examples/l3fwd/l3fwd_neon.h
+++ b/examples/l3fwd/l3fwd_neon.h
@@ -192,7 +192,7 @@  send_packets_multi(struct lcore_conf *qconf, struct rte_mbuf **pkts_burst,
 			 * dp1:
 			 * <d[j], d[j+1], d[j+2], d[j+3], ... >
 			 */
-			dp1 = vextq_u16(dp1, dp1, FWDSTEP - 1);
+			dp1 = vextq_u16(dp2, dp1, FWDSTEP - 1);
 		}
 
 		/*