diff mbox

[dpdk-dev] net/i40e: fix incorrect return

Message ID 20180125060418.41759-1-qi.z.zhang@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Qi Zhang Jan. 25, 2018, 6:04 a.m. UTC 
  Fix incorrect function return.

Fixes: ecad87d22383e ("net/i40e: move RSS to flow API")

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qi Zhang Jan. 25, 2018, 6:10 a.m. UTC | #1 
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, January 25, 2018 2:04 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: [PATCH] net/i40e: fix incorrect return
> 
> Fix incorrect function return.
> 
> Fixes: ecad87d22383e ("net/i40e: move RSS to flow API")
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index c4df65df0..74b43290c 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>  							sizeof(uint32_t);
>  	}
> 
> -	return i40e_hw_rss_hash_set(pf, &rss_conf);
> +	i40e_hw_rss_hash_set(pf, &rss_conf);
> 
>  	rte_memcpy(rss_info,
>  		conf, sizeof(struct i40e_rte_flow_rss_conf));
> --
> 2.13.6
Nacked-by Qi Zhang <qi.z.zhang@intel.com> since its already be covered by Zhao Wei's previous fix.
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index c4df65df0..74b43290c 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -11681,7 +11681,7 @@  i40e_config_rss_filter(struct i40e_pf *pf,
 							sizeof(uint32_t);
 	}
 
-	return i40e_hw_rss_hash_set(pf, &rss_conf);
+	i40e_hw_rss_hash_set(pf, &rss_conf);
 
 	rte_memcpy(rss_info,
 		conf, sizeof(struct i40e_rte_flow_rss_conf));