diff mbox

[dpdk-dev,v2,01/10] net/enic: remove 'extern' in .h file function declarations

Message ID 20180306014634.28398-2-johndale@cisco.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

John Daley (johndale) March 6, 2018, 1:46 a.m. UTC 
  Signed-off-by: John Daley <johndale@cisco.com>
Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com>
---
 drivers/net/enic/enic.h | 80 ++++++++++++++++++++++++-------------------------
 1 file changed, 40 insertions(+), 40 deletions(-)

Comments

John Daley (johndale) March 8, 2018, 2:46 a.m. UTC | #1 
V2: rebase, submit as patchset instead of individual patches so they
apply correctly.
V3: try again submitting patches one at a time so they are applied
in order (tester seems to be applying patches in order received
instead of looking at patch ID).

Hyong Youb Kim (9):
  net/enic: allow the user to change RSS settings
  net/enic: heed the requested max Rx packet size
  net/enic: remove the VLAN filter handler
  net/enic: add Rx/Tx queue configuration getters
  net/enic: allocate stats DMA buffer upfront during probe
  net/enic: support Rx queue interrupts
  doc: describe Rx bytes counter behavior for enic
  net/enic: use memcpy to avoid strict aliasing warnings
  net/enic: support for meson

John Daley (1):
  net/enic: remove 'extern' in .h file function declarations

 doc/guides/nics/enic.rst          |  16 +-
 doc/guides/nics/features/enic.ini |   3 +
 drivers/net/enic/base/vnic_dev.c  |  24 ++-
 drivers/net/enic/base/vnic_dev.h  |   1 +
 drivers/net/enic/enic.h           | 120 +++++++-----
 drivers/net/enic/enic_clsf.c      |  21 +--
 drivers/net/enic/enic_ethdev.c    | 258 ++++++++++++++++++++++----
 drivers/net/enic/enic_main.c      | 373 ++++++++++++++++++++++++++++++--------
 drivers/net/enic/enic_res.c       |  23 ++-
 drivers/net/enic/enic_res.h       |   6 +
 drivers/net/enic/meson.build      |  19 ++
 drivers/net/meson.build           |   2 +-
 12 files changed, 686 insertions(+), 180 deletions(-)
 create mode 100644 drivers/net/enic/meson.build
Ferruh Yigit March 9, 2018, 4 p.m. UTC | #2 
On 3/8/2018 2:46 AM, John Daley wrote:
> V2: rebase, submit as patchset instead of individual patches so they
> apply correctly.
> V3: try again submitting patches one at a time so they are applied
> in order (tester seems to be applying patches in order received
> instead of looking at patch ID).
> 
> Hyong Youb Kim (9):
>   net/enic: allow the user to change RSS settings
>   net/enic: heed the requested max Rx packet size
>   net/enic: remove the VLAN filter handler
>   net/enic: add Rx/Tx queue configuration getters
>   net/enic: allocate stats DMA buffer upfront during probe
>   net/enic: support Rx queue interrupts
>   doc: describe Rx bytes counter behavior for enic
>   net/enic: use memcpy to avoid strict aliasing warnings
>   net/enic: support for meson
> 
> John Daley (1):
>   net/enic: remove 'extern' in .h file function declarations

Series applied to dpdk-next-net/master, thanks.

(typo in 2/10 fixed while applying)
Hyong Youb Kim (hyonkim) March 10, 2018, 12:49 a.m. UTC | #3 
On Fri, Mar 09, 2018 at 04:00:55PM +0000, Ferruh Yigit wrote:
[...]
> Series applied to dpdk-next-net/master, thanks.
> 
> (typo in 2/10 fixed while applying)

Thanks a lot for fixing that. Adding "build with assert enabled" to our checklist..

-Hyong
diff mbox

Patch

diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index c083985ee..e88af6bc9 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -220,54 +220,54 @@  enic_ring_incr(uint32_t n_descriptors, uint32_t idx)
 	return idx;
 }
 
-extern void enic_fdir_stats_get(struct enic *enic,
-	struct rte_eth_fdir_stats *stats);
-extern int enic_fdir_add_fltr(struct enic *enic,
-	struct rte_eth_fdir_filter *params);
-extern int enic_fdir_del_fltr(struct enic *enic,
-	struct rte_eth_fdir_filter *params);
-extern void enic_free_wq(void *txq);
-extern int enic_alloc_intr_resources(struct enic *enic);
-extern int enic_setup_finish(struct enic *enic);
-extern int enic_alloc_wq(struct enic *enic, uint16_t queue_idx,
-	unsigned int socket_id, uint16_t nb_desc);
-extern void enic_start_wq(struct enic *enic, uint16_t queue_idx);
-extern int enic_stop_wq(struct enic *enic, uint16_t queue_idx);
-extern void enic_start_rq(struct enic *enic, uint16_t queue_idx);
-extern int enic_stop_rq(struct enic *enic, uint16_t queue_idx);
-extern void enic_free_rq(void *rxq);
-extern int enic_alloc_rq(struct enic *enic, uint16_t queue_idx,
-	unsigned int socket_id, struct rte_mempool *mp,
-	uint16_t nb_desc, uint16_t free_thresh);
-extern int enic_set_rss_nic_cfg(struct enic *enic);
-extern int enic_set_vnic_res(struct enic *enic);
-extern int enic_enable(struct enic *enic);
-extern int enic_disable(struct enic *enic);
-extern void enic_remove(struct enic *enic);
-extern int enic_get_link_status(struct enic *enic);
-extern int enic_dev_stats_get(struct enic *enic,
-	struct rte_eth_stats *r_stats);
-extern void enic_dev_stats_clear(struct enic *enic);
-extern void enic_add_packet_filter(struct enic *enic);
+void enic_fdir_stats_get(struct enic *enic,
+			 struct rte_eth_fdir_stats *stats);
+int enic_fdir_add_fltr(struct enic *enic,
+		       struct rte_eth_fdir_filter *params);
+int enic_fdir_del_fltr(struct enic *enic,
+		       struct rte_eth_fdir_filter *params);
+void enic_free_wq(void *txq);
+int enic_alloc_intr_resources(struct enic *enic);
+int enic_setup_finish(struct enic *enic);
+int enic_alloc_wq(struct enic *enic, uint16_t queue_idx,
+		  unsigned int socket_id, uint16_t nb_desc);
+void enic_start_wq(struct enic *enic, uint16_t queue_idx);
+int enic_stop_wq(struct enic *enic, uint16_t queue_idx);
+void enic_start_rq(struct enic *enic, uint16_t queue_idx);
+int enic_stop_rq(struct enic *enic, uint16_t queue_idx);
+void enic_free_rq(void *rxq);
+int enic_alloc_rq(struct enic *enic, uint16_t queue_idx,
+		  unsigned int socket_id, struct rte_mempool *mp,
+		  uint16_t nb_desc, uint16_t free_thresh);
+int enic_set_rss_nic_cfg(struct enic *enic);
+int enic_set_vnic_res(struct enic *enic);
+int enic_enable(struct enic *enic);
+int enic_disable(struct enic *enic);
+void enic_remove(struct enic *enic);
+int enic_get_link_status(struct enic *enic);
+int enic_dev_stats_get(struct enic *enic,
+		       struct rte_eth_stats *r_stats);
+void enic_dev_stats_clear(struct enic *enic);
+void enic_add_packet_filter(struct enic *enic);
 int enic_set_mac_address(struct enic *enic, uint8_t *mac_addr);
 void enic_del_mac_address(struct enic *enic, int mac_index);
-extern unsigned int enic_cleanup_wq(struct enic *enic, struct vnic_wq *wq);
-extern void enic_send_pkt(struct enic *enic, struct vnic_wq *wq,
-			  struct rte_mbuf *tx_pkt, unsigned short len,
-			  uint8_t sop, uint8_t eop, uint8_t cq_entry,
-			  uint16_t ol_flags, uint16_t vlan_tag);
-
-extern void enic_post_wq_index(struct vnic_wq *wq);
-extern int enic_probe(struct enic *enic);
-extern int enic_clsf_init(struct enic *enic);
-extern void enic_clsf_destroy(struct enic *enic);
+unsigned int enic_cleanup_wq(struct enic *enic, struct vnic_wq *wq);
+void enic_send_pkt(struct enic *enic, struct vnic_wq *wq,
+		   struct rte_mbuf *tx_pkt, unsigned short len,
+		   uint8_t sop, uint8_t eop, uint8_t cq_entry,
+		   uint16_t ol_flags, uint16_t vlan_tag);
+
+void enic_post_wq_index(struct vnic_wq *wq);
+int enic_probe(struct enic *enic);
+int enic_clsf_init(struct enic *enic);
+void enic_clsf_destroy(struct enic *enic);
 uint16_t enic_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 			uint16_t nb_pkts);
 uint16_t enic_dummy_recv_pkts(void *rx_queue,
 			      struct rte_mbuf **rx_pkts,
 			      uint16_t nb_pkts);
 uint16_t enic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
-			       uint16_t nb_pkts);
+			uint16_t nb_pkts);
 uint16_t enic_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
 			uint16_t nb_pkts);
 int enic_set_mtu(struct enic *enic, uint16_t new_mtu);